diff mbox series

[v3] Bluetooth: btusb: fix bt fiwmare downloading failure issue for qca btsoc.

Message ID 1622541430-17072-1-git-send-email-zijuhu@codeaurora.org (mailing list archive)
State New, archived
Headers show
Series [v3] Bluetooth: btusb: fix bt fiwmare downloading failure issue for qca btsoc. | expand

Commit Message

Zijun Hu June 1, 2021, 9:57 a.m. UTC
From: Tim Jiang <tjiang@codeaurora.org>

This is btsoc timing issue, after host start to downloading bt firmware,
ep2 need time to switch from function acl to function dfu, so host add
20ms delay as workaround.

Signed-off-by: Tim Jiang <tjiang@codeaurora.org>
---
 drivers/bluetooth/btusb.c | 5 +++++
 1 file changed, 5 insertions(+)

Comments

bluez.test.bot@gmail.com June 1, 2021, 10:55 a.m. UTC | #1
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=491653

---Test result---

Test Summary:
CheckPatch                    PASS      0.85 seconds
GitLint                       FAIL      0.13 seconds
BuildKernel                   PASS      621.60 seconds
TestRunner: Setup             PASS      396.27 seconds
TestRunner: l2cap-tester      PASS      2.92 seconds
TestRunner: bnep-tester       PASS      2.09 seconds
TestRunner: mgmt-tester       PASS      28.56 seconds
TestRunner: rfcomm-tester     PASS      2.26 seconds
TestRunner: sco-tester        PASS      2.26 seconds
TestRunner: smp-tester        PASS      2.35 seconds
TestRunner: userchan-tester   PASS      2.17 seconds

Details
##############################
Test: CheckPatch - PASS - 0.85 seconds
Run checkpatch.pl script with rule in .checkpatch.conf


##############################
Test: GitLint - FAIL - 0.13 seconds
Run gitlint with rule in .gitlint
Bluetooth: btusb: fix bt fiwmare downloading failure issue for qca btsoc.
1: T1 Title exceeds max length (73>72): "Bluetooth: btusb: fix bt fiwmare downloading failure issue for qca btsoc."
1: T3 Title has trailing punctuation (.): "Bluetooth: btusb: fix bt fiwmare downloading failure issue for qca btsoc."


##############################
Test: BuildKernel - PASS - 621.60 seconds
Build Kernel with minimal configuration supports Bluetooth


##############################
Test: TestRunner: Setup - PASS - 396.27 seconds
Setup environment for running Test Runner


##############################
Test: TestRunner: l2cap-tester - PASS - 2.92 seconds
Run test-runner with l2cap-tester
Total: 40, Passed: 40 (100.0%), Failed: 0, Not Run: 0

##############################
Test: TestRunner: bnep-tester - PASS - 2.09 seconds
Run test-runner with bnep-tester
Total: 1, Passed: 1 (100.0%), Failed: 0, Not Run: 0

##############################
Test: TestRunner: mgmt-tester - PASS - 28.56 seconds
Run test-runner with mgmt-tester
Total: 433, Passed: 418 (96.5%), Failed: 0, Not Run: 15

##############################
Test: TestRunner: rfcomm-tester - PASS - 2.26 seconds
Run test-runner with rfcomm-tester
Total: 9, Passed: 9 (100.0%), Failed: 0, Not Run: 0

##############################
Test: TestRunner: sco-tester - PASS - 2.26 seconds
Run test-runner with sco-tester
Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0

##############################
Test: TestRunner: smp-tester - PASS - 2.35 seconds
Run test-runner with smp-tester
Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0

##############################
Test: TestRunner: userchan-tester - PASS - 2.17 seconds
Run test-runner with userchan-tester
Total: 3, Passed: 3 (100.0%), Failed: 0, Not Run: 0



---
Regards,
Linux Bluetooth
Marcel Holtmann June 2, 2021, 8:11 p.m. UTC | #2
Hi Zijun,

> This is btsoc timing issue, after host start to downloading bt firmware,
> ep2 need time to switch from function acl to function dfu, so host add
> 20ms delay as workaround.
> 
> Signed-off-by: Tim Jiang <tjiang@codeaurora.org>
> ---
> drivers/bluetooth/btusb.c | 5 +++++
> 1 file changed, 5 insertions(+)

patch has been applied to bluetooth-next tree.

Regards

Marcel
diff mbox series

Patch

diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 5245714..bd5242f 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -4065,6 +4065,11 @@  static int btusb_setup_qca_download_fw(struct hci_dev *hdev,
 	sent += size;
 	count -= size;
 
+	/* ep2 need time to switch from function acl to function dfu,
+	 * so we add 20ms delay here.
+	 */
+	msleep(20);
+
 	while (count) {
 		size = min_t(size_t, count, QCA_DFU_PACKET_LEN);