diff mbox series

[v1,1/3] dt-bindings: net: bluetooth: Add wlan-gpio entry for wcn6750

Message ID 1651228073-1999-2-git-send-email-quic_bgodavar@quicinc.com (mailing list archive)
State New, archived
Headers show
Series WAR to handle WCN6750 hardware issue | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/checkpatch success Checkpatch PASS
tedd_an/gitlint success Gitlint PASS
tedd_an/subjectprefix fail "Bluetooth: " is not specified in the subject
tedd_an/buildkernel success Build Kernel PASS
tedd_an/buildkernel32 success Build Kernel32 PASS
tedd_an/incremental_build success Pass
tedd_an/testrunnersetup success Test Runner Setup PASS
tedd_an/testrunnerl2cap-tester success Total: 40, Passed: 40 (100.0%), Failed: 0, Not Run: 0
tedd_an/testrunnerbnep-tester success Total: 1, Passed: 1 (100.0%), Failed: 0, Not Run: 0
tedd_an/testrunnermgmt-tester success Total: 493, Passed: 493 (100.0%), Failed: 0, Not Run: 0
tedd_an/testrunnerrfcomm-tester success Total: 10, Passed: 10 (100.0%), Failed: 0, Not Run: 0
tedd_an/testrunnersco-tester success Total: 12, Passed: 12 (100.0%), Failed: 0, Not Run: 0
tedd_an/testrunnersmp-tester success Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0
tedd_an/testrunneruserchan-tester success Total: 4, Passed: 4 (100.0%), Failed: 0, Not Run: 0

Commit Message

Balakrishna Godavarthi (QUIC) April 29, 2022, 10:27 a.m. UTC
This patch adds a wlan-gpio entry and its reference usage for
BT SoC wcn6750.

Signed-off-by: Sai Teja Aluvala <quic_saluvala@quicinc.com>
Signed-off-by: Balakrishna Godavarthi <quic_bgodavar@quicinc.com>
---
 Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

bluez.test.bot@gmail.com April 29, 2022, noon UTC | #1
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=636918

---Test result---

Test Summary:
CheckPatch                    PASS      4.79 seconds
GitLint                       PASS      3.01 seconds
SubjectPrefix                 FAIL      1.73 seconds
BuildKernel                   PASS      31.70 seconds
BuildKernel32                 PASS      28.95 seconds
Incremental Build with patchesPASS      49.95 seconds
TestRunner: Setup             PASS      484.37 seconds
TestRunner: l2cap-tester      PASS      17.17 seconds
TestRunner: bnep-tester       PASS      6.09 seconds
TestRunner: mgmt-tester       PASS      102.27 seconds
TestRunner: rfcomm-tester     PASS      9.76 seconds
TestRunner: sco-tester        PASS      9.61 seconds
TestRunner: smp-tester        PASS      9.27 seconds
TestRunner: userchan-tester   PASS      6.42 seconds

Details
##############################
Test: SubjectPrefix - FAIL - 1.73 seconds
Check subject contains "Bluetooth" prefix
"Bluetooth: " is not specified in the subject
"Bluetooth: " is not specified in the subject



---
Regards,
Linux Bluetooth
Marcel Holtmann April 29, 2022, 2:50 p.m. UTC | #2
Hi Balakrishna,

> This patch adds a wlan-gpio entry and its reference usage for
> BT SoC wcn6750.
> 
> Signed-off-by: Sai Teja Aluvala <quic_saluvala@quicinc.com>
> Signed-off-by: Balakrishna Godavarthi <quic_bgodavar@quicinc.com>
> ---
> Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml
> index f93c6e7..624f957 100644
> --- a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml
> +++ b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml
> @@ -24,6 +24,10 @@ properties:
>       - qcom,qca6390-bt
>       - qcom,wcn6750-bt
> 
> +  wlan-gpios:
> +    maxItems: 1
> +    description: gpio specifier used to wlan chip
> +
>   enable-gpios:
>     maxItems: 1
>     description: gpio specifier used to enable chip
> @@ -123,6 +127,7 @@ allOf:
>               - qcom,wcn6750-bt
>     then:
>       required:
> +        - wlan-gpios

why is this in the Bluetooth section? Why should Bluetooth care about any WiFi GPIO?

Regards

Marcel
Rob Herring (Arm) May 4, 2022, 8:31 p.m. UTC | #3
On Fri, Apr 29, 2022 at 03:57:51PM +0530, Balakrishna Godavarthi wrote:
> This patch adds a wlan-gpio entry and its reference usage for

wlan-gpios

> BT SoC wcn6750.
> 
> Signed-off-by: Sai Teja Aluvala <quic_saluvala@quicinc.com>
> Signed-off-by: Balakrishna Godavarthi <quic_bgodavar@quicinc.com>
> ---
>  Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml
> index f93c6e7..624f957 100644
> --- a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml
> +++ b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml
> @@ -24,6 +24,10 @@ properties:
>        - qcom,qca6390-bt
>        - qcom,wcn6750-bt
>  
> +  wlan-gpios:
> +    maxItems: 1
> +    description: gpio specifier used to wlan chip

How does one 'wlan' a chip?

> +
>    enable-gpios:
>      maxItems: 1
>      description: gpio specifier used to enable chip
> @@ -123,6 +127,7 @@ allOf:
>                - qcom,wcn6750-bt
>      then:
>        required:
> +        - wlan-gpios
>          - enable-gpios
>          - swctrl-gpios
>          - vddio-supply
> @@ -166,6 +171,7 @@ examples:
>              compatible = "qcom,wcn6750-bt";
>              pinctrl-names = "default";
>              pinctrl-0 = <&bt_en_default>;
> +            wlan-gpios = <&tlmm 84 GPIO_ACTIVE_HIGH>;
>              enable-gpios = <&tlmm 85 GPIO_ACTIVE_HIGH>;
>              swctrl-gpios = <&tlmm 86 GPIO_ACTIVE_HIGH>;
>              vddio-supply = <&vreg_l19b_1p8>;
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
> 
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml
index f93c6e7..624f957 100644
--- a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml
+++ b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml
@@ -24,6 +24,10 @@  properties:
       - qcom,qca6390-bt
       - qcom,wcn6750-bt
 
+  wlan-gpios:
+    maxItems: 1
+    description: gpio specifier used to wlan chip
+
   enable-gpios:
     maxItems: 1
     description: gpio specifier used to enable chip
@@ -123,6 +127,7 @@  allOf:
               - qcom,wcn6750-bt
     then:
       required:
+        - wlan-gpios
         - enable-gpios
         - swctrl-gpios
         - vddio-supply
@@ -166,6 +171,7 @@  examples:
             compatible = "qcom,wcn6750-bt";
             pinctrl-names = "default";
             pinctrl-0 = <&bt_en_default>;
+            wlan-gpios = <&tlmm 84 GPIO_ACTIVE_HIGH>;
             enable-gpios = <&tlmm 85 GPIO_ACTIVE_HIGH>;
             swctrl-gpios = <&tlmm 86 GPIO_ACTIVE_HIGH>;
             vddio-supply = <&vreg_l19b_1p8>;