| Message ID | 20200320131356.Bluez.v1.1.Ia3d21e293d18f903fa6e54918856e1dd5ffc904f@changeid (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Luiz Von Dentz |
| Headers | show |
| Series | [Bluez,v1] avdtp: fix delay report valid states | expand |
[re-sending as plain text] Hi Bluez Maintainers, Could you take a look at this proposal? Thank you! On Fri, 20 Mar 2020 at 13:14, Archie Pusaka <apusaka@google.com> wrote: > > From: Archie Pusaka <apusaka@chromium.org> > > According to AVDTP specification section 6.19, > avdtp_delayreport_cmd could also be received when the state of SEP > is open. > > Therefore, updating to accommodate such condition. > --- > > profiles/audio/avdtp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/profiles/audio/avdtp.c b/profiles/audio/avdtp.c > index 0e075f9ff..4b0e63384 100644 > --- a/profiles/audio/avdtp.c > +++ b/profiles/audio/avdtp.c > @@ -1936,6 +1936,7 @@ static gboolean avdtp_delayreport_cmd(struct avdtp *session, > stream = sep->stream; > > if (sep->state != AVDTP_STATE_CONFIGURED && > + sep->state != AVDTP_STATE_OPEN && > sep->state != AVDTP_STATE_STREAMING) { > err = AVDTP_BAD_STATE; > goto failed; > -- > 2.25.1.696.g5e7596f4ac-goog >
Hi Archie, On Thu, Mar 26, 2020 at 7:14 PM Archie Pusaka <apusaka@google.com> wrote: > > [re-sending as plain text] > Hi Bluez Maintainers, > > Could you take a look at this proposal? > > Thank you! > > > On Fri, 20 Mar 2020 at 13:14, Archie Pusaka <apusaka@google.com> wrote: > > > > From: Archie Pusaka <apusaka@chromium.org> > > > > According to AVDTP specification section 6.19, > > avdtp_delayreport_cmd could also be received when the state of SEP > > is open. > > > > Therefore, updating to accommodate such condition. > > --- > > > > profiles/audio/avdtp.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/profiles/audio/avdtp.c b/profiles/audio/avdtp.c > > index 0e075f9ff..4b0e63384 100644 > > --- a/profiles/audio/avdtp.c > > +++ b/profiles/audio/avdtp.c > > @@ -1936,6 +1936,7 @@ static gboolean avdtp_delayreport_cmd(struct avdtp *session, > > stream = sep->stream; > > > > if (sep->state != AVDTP_STATE_CONFIGURED && > > + sep->state != AVDTP_STATE_OPEN && > > sep->state != AVDTP_STATE_STREAMING) { > > err = AVDTP_BAD_STATE; > > goto failed; > > -- > > 2.25.1.696.g5e7596f4ac-goog > > Applied, thanks.
diff --git a/profiles/audio/avdtp.c b/profiles/audio/avdtp.c index 0e075f9ff..4b0e63384 100644 --- a/profiles/audio/avdtp.c +++ b/profiles/audio/avdtp.c @@ -1936,6 +1936,7 @@ static gboolean avdtp_delayreport_cmd(struct avdtp *session, stream = sep->stream; if (sep->state != AVDTP_STATE_CONFIGURED && + sep->state != AVDTP_STATE_OPEN && sep->state != AVDTP_STATE_STREAMING) { err = AVDTP_BAD_STATE; goto failed;
From: Archie Pusaka <apusaka@chromium.org> According to AVDTP specification section 6.19, avdtp_delayreport_cmd could also be received when the state of SEP is open. Therefore, updating to accommodate such condition. --- profiles/audio/avdtp.c | 1 + 1 file changed, 1 insertion(+)