Message ID | 20200912062357.23926-5-tedd.an@linux.intel.com (mailing list archive) |
---|---|
State | Accepted |
Delegated to: | Luiz Von Dentz |
Headers | show |
Series | None | expand |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. While we are preparing for reviewing the patches, we found the following issue/warning. Test Result: checkpatch Failed Outputs: WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'client/advertising.h', please use '/*' instead #38: FILE: client/advertising.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #38: FILE: client/advertising.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'client/agent.h', please use '/*' instead #56: FILE: client/agent.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #56: FILE: client/agent.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'client/display.h', please use '/*' instead #74: FILE: client/display.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #74: FILE: client/display.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'client/gatt.h', please use '/*' instead #92: FILE: client/gatt.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #92: FILE: client/gatt.h:1: +// SPDX-License-Identifier: GPL-2.0-or-later - total: 0 errors, 8 warnings, 36 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Your patch has style problems, please review. NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING SSCANF_TO_KSTRTO NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. --- Regards, Linux Bluetooth
diff --git a/client/advertising.c b/client/advertising.c index 1aa28e749..2bba5eca5 100644 --- a/client/advertising.c +++ b/client/advertising.c @@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0-or-later /* * * BlueZ - Bluetooth protocol stack for Linux diff --git a/client/advertising.h b/client/advertising.h index 9967e657b..b2c7a1244 100644 --- a/client/advertising.h +++ b/client/advertising.h @@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0-or-later /* * * BlueZ - Bluetooth protocol stack for Linux diff --git a/client/agent.c b/client/agent.c index 4def1b478..b1e36e5d1 100644 --- a/client/agent.c +++ b/client/agent.c @@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0-or-later /* * * BlueZ - Bluetooth protocol stack for Linux diff --git a/client/agent.h b/client/agent.h index 30f302cdc..3ee7526db 100644 --- a/client/agent.h +++ b/client/agent.h @@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0-or-later /* * * BlueZ - Bluetooth protocol stack for Linux diff --git a/client/display.c b/client/display.c index 05613865b..f3d451ed8 100644 --- a/client/display.c +++ b/client/display.c @@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0-or-later /* * * BlueZ - Bluetooth protocol stack for Linux diff --git a/client/display.h b/client/display.h index e991d191a..9e416e9f8 100644 --- a/client/display.h +++ b/client/display.h @@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0-or-later /* * * BlueZ - Bluetooth protocol stack for Linux diff --git a/client/gatt.c b/client/gatt.c index e5bab6dd0..3552491d8 100644 --- a/client/gatt.c +++ b/client/gatt.c @@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0-or-later /* * * BlueZ - Bluetooth protocol stack for Linux diff --git a/client/gatt.h b/client/gatt.h index 09ca618d3..da347e06d 100644 --- a/client/gatt.h +++ b/client/gatt.h @@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0-or-later /* * * BlueZ - Bluetooth protocol stack for Linux diff --git a/client/main.c b/client/main.c index da877b546..abe0cf307 100644 --- a/client/main.c +++ b/client/main.c @@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0-or-later /* * * BlueZ - Bluetooth protocol stack for Linux
From: Tedd Ho-Jeong An <tedd.an@intel.com> This patch adds SPDX License Identifier. ------------------------------------- License COUNT ------------------------------------- GPL-2.0-or-later : 9 License: GPL-2.0-or-later client/advertising.h client/display.c client/main.c client/display.h client/agent.h client/gatt.c client/agent.c client/advertising.c client/gatt.h --- client/advertising.c | 1 + client/advertising.h | 1 + client/agent.c | 1 + client/agent.h | 1 + client/display.c | 1 + client/display.h | 1 + client/gatt.c | 1 + client/gatt.h | 1 + client/main.c | 1 + 9 files changed, 9 insertions(+)