| Message ID | 20210513101806.5666-1-hildawu@realtek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Bluetooth: btusb: Add support USB ALT 3 for WBS | expand |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=481767 ---Test result--- Test Summary: CheckPatch PASS 0.55 seconds GitLint PASS 0.12 seconds BuildKernel PASS 586.21 seconds TestRunner: Setup PASS 384.10 seconds TestRunner: l2cap-tester PASS 2.74 seconds TestRunner: bnep-tester PASS 2.02 seconds TestRunner: mgmt-tester PASS 28.52 seconds TestRunner: rfcomm-tester PASS 2.23 seconds TestRunner: sco-tester PASS 2.13 seconds TestRunner: smp-tester PASS 2.35 seconds TestRunner: userchan-tester PASS 2.06 seconds Details ############################## Test: CheckPatch - PASS - 0.55 seconds Run checkpatch.pl script with rule in .checkpatch.conf ############################## Test: GitLint - PASS - 0.12 seconds Run gitlint with rule in .gitlint ############################## Test: BuildKernel - PASS - 586.21 seconds Build Kernel with minimal configuration supports Bluetooth ############################## Test: TestRunner: Setup - PASS - 384.10 seconds Setup environment for running Test Runner ############################## Test: TestRunner: l2cap-tester - PASS - 2.74 seconds Run test-runner with l2cap-tester Total: 40, Passed: 40 (100.0%), Failed: 0, Not Run: 0 ############################## Test: TestRunner: bnep-tester - PASS - 2.02 seconds Run test-runner with bnep-tester Total: 1, Passed: 1 (100.0%), Failed: 0, Not Run: 0 ############################## Test: TestRunner: mgmt-tester - PASS - 28.52 seconds Run test-runner with mgmt-tester Total: 416, Passed: 403 (96.9%), Failed: 0, Not Run: 13 ############################## Test: TestRunner: rfcomm-tester - PASS - 2.23 seconds Run test-runner with rfcomm-tester Total: 9, Passed: 9 (100.0%), Failed: 0, Not Run: 0 ############################## Test: TestRunner: sco-tester - PASS - 2.13 seconds Run test-runner with sco-tester Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0 ############################## Test: TestRunner: smp-tester - PASS - 2.35 seconds Run test-runner with smp-tester Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0 ############################## Test: TestRunner: userchan-tester - PASS - 2.06 seconds Run test-runner with userchan-tester Total: 3, Passed: 3 (100.0%), Failed: 0, Not Run: 0 --- Regards, Linux Bluetooth
Hi Hilda, > Because mSBC frames do not need to be aligned to the SCO packet > boundary. Using USB ALT 3 let HCI payload >= 60 bytes, let mSBC > data satisfy 60 Bytes avoid payload unaligned situation and fixed > some headset no voise issue. > > USB Alt 3 supported also need HFP support transparent MTU in 72 Bytes. > > Signed-off-by: hildawu <hildawu@realtek.com> please use real name here. > --- > drivers/bluetooth/btusb.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c > index 6f253378e893..872034e7a232 100644 > --- a/drivers/bluetooth/btusb.c > +++ b/drivers/bluetooth/btusb.c > @@ -1752,6 +1752,13 @@ static void btusb_work(struct work_struct *work) > * which work with WBS at all. > */ > new_alts = btusb_find_altsetting(data, 6) ? 6 : 1; > + /* Because mSBC frames do not need to be aligned to the > + * SCO packet boundary. If support the Alt 3, use the > + * Alt 3 for HCI payload >= 60 Bytes let air packet > + * data satisfy 60 bytes. > + */ > + if ((new_alts == 1) && (btusb_find_altsetting(data, 3))) > + new_alts = 3; if (new_alts == 1 && btusb_find_altsetting(..)) .. Regards Marcel
Hi Marcel, Thank you! I will propose a patch v2. Regards, Hilda -----Original Message----- From: Marcel Holtmann <marcel@holtmann.org> Sent: Thursday, May 13, 2021 11:13 PM To: Hilda Wu <hildawu@realtek.com> Cc: Johan Hedberg <johan.hedberg@gmail.com>; Luiz Augusto von Dentz <luiz.dentz@gmail.com>; Bluetooth Kernel Mailing List <linux-bluetooth@vger.kernel.org>; open list <linux-kernel@vger.kernel.org>; Max Chou <max.chou@realtek.com>; alex_lu@realsil.com.cn; KidmanLee <kidman@realtek.com> Subject: Re: [PATCH] Bluetooth: btusb: Add support USB ALT 3 for WBS Hi Hilda, > Because mSBC frames do not need to be aligned to the SCO packet > boundary. Using USB ALT 3 let HCI payload >= 60 bytes, let mSBC data > satisfy 60 Bytes avoid payload unaligned situation and fixed some > headset no voise issue. > > USB Alt 3 supported also need HFP support transparent MTU in 72 Bytes. > > Signed-off-by: hildawu <hildawu@realtek.com> please use real name here. > --- > drivers/bluetooth/btusb.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c > index 6f253378e893..872034e7a232 100644 > --- a/drivers/bluetooth/btusb.c > +++ b/drivers/bluetooth/btusb.c > @@ -1752,6 +1752,13 @@ static void btusb_work(struct work_struct *work) > * which work with WBS at all. > */ > new_alts = btusb_find_altsetting(data, 6) ? 6 : 1; > + /* Because mSBC frames do not need to be aligned to the > + * SCO packet boundary. If support the Alt 3, use the > + * Alt 3 for HCI payload >= 60 Bytes let air packet > + * data satisfy 60 bytes. > + */ > + if ((new_alts == 1) && (btusb_find_altsetting(data, 3))) > + new_alts = 3; if (new_alts == 1 && btusb_find_altsetting(..)) .. Regards Marcel ------Please consider the environment before printing this e-mail.
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index 6f253378e893..872034e7a232 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -1752,6 +1752,13 @@ static void btusb_work(struct work_struct *work) * which work with WBS at all. */ new_alts = btusb_find_altsetting(data, 6) ? 6 : 1; + /* Because mSBC frames do not need to be aligned to the + * SCO packet boundary. If support the Alt 3, use the + * Alt 3 for HCI payload >= 60 Bytes let air packet + * data satisfy 60 bytes. + */ + if ((new_alts == 1) && (btusb_find_altsetting(data, 3))) + new_alts = 3; } if (btusb_switch_alt_setting(hdev, new_alts) < 0)