| Message ID | 20210526173622.444397-1-hj.tedd.an@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [V2] Bluetooth: mgmt: Fix the command returns garbage parameter value | expand |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=489077 ---Test result--- Test Summary: CheckPatch PASS 0.48 seconds GitLint PASS 0.11 seconds BuildKernel PASS 514.56 seconds TestRunner: Setup PASS 337.70 seconds TestRunner: l2cap-tester PASS 2.52 seconds TestRunner: bnep-tester PASS 1.86 seconds TestRunner: mgmt-tester PASS 27.63 seconds TestRunner: rfcomm-tester PASS 2.04 seconds TestRunner: sco-tester PASS 1.98 seconds TestRunner: smp-tester PASS 2.07 seconds TestRunner: userchan-tester PASS 1.89 seconds Details ############################## Test: CheckPatch - PASS - 0.48 seconds Run checkpatch.pl script with rule in .checkpatch.conf ############################## Test: GitLint - PASS - 0.11 seconds Run gitlint with rule in .gitlint ############################## Test: BuildKernel - PASS - 514.56 seconds Build Kernel with minimal configuration supports Bluetooth ############################## Test: TestRunner: Setup - PASS - 337.70 seconds Setup environment for running Test Runner ############################## Test: TestRunner: l2cap-tester - PASS - 2.52 seconds Run test-runner with l2cap-tester Total: 40, Passed: 40 (100.0%), Failed: 0, Not Run: 0 ############################## Test: TestRunner: bnep-tester - PASS - 1.86 seconds Run test-runner with bnep-tester Total: 1, Passed: 1 (100.0%), Failed: 0, Not Run: 0 ############################## Test: TestRunner: mgmt-tester - PASS - 27.63 seconds Run test-runner with mgmt-tester Total: 427, Passed: 414 (97.0%), Failed: 0, Not Run: 13 ############################## Test: TestRunner: rfcomm-tester - PASS - 2.04 seconds Run test-runner with rfcomm-tester Total: 9, Passed: 9 (100.0%), Failed: 0, Not Run: 0 ############################## Test: TestRunner: sco-tester - PASS - 1.98 seconds Run test-runner with sco-tester Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0 ############################## Test: TestRunner: smp-tester - PASS - 2.07 seconds Run test-runner with smp-tester Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0 ############################## Test: TestRunner: userchan-tester - PASS - 1.89 seconds Run test-runner with userchan-tester Total: 3, Passed: 3 (100.0%), Failed: 0, Not Run: 0 --- Regards, Linux Bluetooth
Hi Tedd, > When the Get Device Flags command fails, it returns the error status > with the parameters filled with the garbage values. Although the > parameters are not used, it is better to fill with zero than the random > values. > > Signed-off-by: Tedd Ho-Jeong An <tedd.an@intel.com> > --- > net/bluetooth/mgmt.c | 2 ++ > 1 file changed, 2 insertions(+) patch has been applied to bluetooth-next tree. Regards Marcel
diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c index b44e19c69c44..91d36c3bf23e 100644 --- a/net/bluetooth/mgmt.c +++ b/net/bluetooth/mgmt.c @@ -4061,6 +4061,8 @@ static int get_device_flags(struct sock *sk, struct hci_dev *hdev, void *data, hci_dev_lock(hdev); + memset(&rp, 0, sizeof(rp)); + if (cp->addr.type == BDADDR_BREDR) { br_params = hci_bdaddr_list_lookup_with_flags(&hdev->whitelist, &cp->addr.bdaddr,