| Message ID | 20210528152645.25577-1-joakim.tjernlund@infinera.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/2] Bluetooth: btrtl: rename USB fw for RTL8761 | expand |
On Fri, May 28, 2021 at 05:26:44PM +0200, Joakim Tjernlund wrote: > From: Joakim Tjernlund <Joakim.Tjernlund@infinera.com> > > According Realteks own BT drivers firmware RTL8761B is for UART > and RTL8761BU is for USB. > > Change existing 8761B to UART and add an 8761BU entry for USB > > Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@infinera.com> > --- > drivers/bluetooth/btrtl.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c > index e7fe5fb22753..ccef8b2cfee2 100644 > --- a/drivers/bluetooth/btrtl.c > +++ b/drivers/bluetooth/btrtl.c > @@ -132,12 +132,19 @@ static const struct id_table ic_id_table[] = { > .cfg_name = "rtl_bt/rtl8761a_config" }, > > /* 8761B */ > - { IC_INFO(RTL_ROM_LMP_8761A, 0xb, 0xa, HCI_USB), > + { IC_INFO(RTL_ROM_LMP_8761A, 0xb, 0xa, HCI_UART), > .config_needed = false, > .has_rom_version = true, > .fw_name = "rtl_bt/rtl8761b_fw.bin", > .cfg_name = "rtl_bt/rtl8761b_config" }, > > + /* 8761BU */ > + { IC_INFO(RTL_ROM_LMP_8761A, 0xb, 0xa, HCI_USB), > + .config_needed = false, > + .has_rom_version = true, > + .fw_name = "rtl_bt/rtl8761bu_fw.bin", > + .cfg_name = "rtl_bt/rtl8761bu_config" }, > + > /* 8822C with UART interface */ > { IC_INFO(RTL_ROM_LMP_8822B, 0xc, 0xa, HCI_UART), > .config_needed = true, > -- > 2.31.1 > <formletter> This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly. </formletter>
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=490331
---Test result---
Test Summary:
CheckPatch FAIL 1.07 seconds
GitLint FAIL 0.24 seconds
BuildKernel PASS 672.40 seconds
TestRunner: Setup PASS 437.99 seconds
TestRunner: l2cap-tester PASS 3.25 seconds
TestRunner: bnep-tester PASS 2.24 seconds
TestRunner: mgmt-tester PASS 31.34 seconds
TestRunner: rfcomm-tester PASS 2.43 seconds
TestRunner: sco-tester PASS 2.33 seconds
TestRunner: smp-tester PASS 2.57 seconds
TestRunner: userchan-tester PASS 2.15 seconds
Details
##############################
Test: CheckPatch - FAIL - 1.07 seconds
Run checkpatch.pl script with rule in .checkpatch.conf
Bluetooth: btusb: Add 0x0b05:0x190e Realtek 8761BU (ASUS BT500) device.
ERROR: code indent should use tabs where possible
#48: FILE: drivers/bluetooth/btusb.c:437:
+^I ^I^I^I^I^I BTUSB_WIDEBAND_SPEECH },$
WARNING: please, no space before tabs
#48: FILE: drivers/bluetooth/btusb.c:437:
+^I ^I^I^I^I^I BTUSB_WIDEBAND_SPEECH },$
total: 1 errors, 1 warnings, 10 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
NOTE: Whitespace errors detected.
You may wish to use scripts/cleanpatch or scripts/cleanfile
"[PATCH] Bluetooth: btusb: Add 0x0b05:0x190e Realtek 8761BU (ASUS" has style problems, please review.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
##############################
Test: GitLint - FAIL - 0.24 seconds
Run gitlint with rule in .gitlint
Bluetooth: btusb: Add 0x0b05:0x190e Realtek 8761BU (ASUS BT500) device.
1: T3 Title has trailing punctuation (.): "Bluetooth: btusb: Add 0x0b05:0x190e Realtek 8761BU (ASUS BT500) device."
##############################
Test: BuildKernel - PASS - 672.40 seconds
Build Kernel with minimal configuration supports Bluetooth
##############################
Test: TestRunner: Setup - PASS - 437.99 seconds
Setup environment for running Test Runner
##############################
Test: TestRunner: l2cap-tester - PASS - 3.25 seconds
Run test-runner with l2cap-tester
Total: 40, Passed: 40 (100.0%), Failed: 0, Not Run: 0
##############################
Test: TestRunner: bnep-tester - PASS - 2.24 seconds
Run test-runner with bnep-tester
Total: 1, Passed: 1 (100.0%), Failed: 0, Not Run: 0
##############################
Test: TestRunner: mgmt-tester - PASS - 31.34 seconds
Run test-runner with mgmt-tester
Total: 433, Passed: 420 (97.0%), Failed: 0, Not Run: 13
##############################
Test: TestRunner: rfcomm-tester - PASS - 2.43 seconds
Run test-runner with rfcomm-tester
Total: 9, Passed: 9 (100.0%), Failed: 0, Not Run: 0
##############################
Test: TestRunner: sco-tester - PASS - 2.33 seconds
Run test-runner with sco-tester
Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0
##############################
Test: TestRunner: smp-tester - PASS - 2.57 seconds
Run test-runner with smp-tester
Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0
##############################
Test: TestRunner: userchan-tester - PASS - 2.15 seconds
Run test-runner with userchan-tester
Total: 3, Passed: 3 (100.0%), Failed: 0, Not Run: 0
---
Regards,
Linux Bluetooth
Hi Joakim, > According Realteks own BT drivers firmware RTL8761B is for UART > and RTL8761BU is for USB. > > Change existing 8761B to UART and add an 8761BU entry for USB > > Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@infinera.com> > --- > drivers/bluetooth/btrtl.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) patch has been applied to bluetooth-next tree. Regards Marcel
diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c index e7fe5fb22753..ccef8b2cfee2 100644 --- a/drivers/bluetooth/btrtl.c +++ b/drivers/bluetooth/btrtl.c @@ -132,12 +132,19 @@ static const struct id_table ic_id_table[] = { .cfg_name = "rtl_bt/rtl8761a_config" }, /* 8761B */ - { IC_INFO(RTL_ROM_LMP_8761A, 0xb, 0xa, HCI_USB), + { IC_INFO(RTL_ROM_LMP_8761A, 0xb, 0xa, HCI_UART), .config_needed = false, .has_rom_version = true, .fw_name = "rtl_bt/rtl8761b_fw.bin", .cfg_name = "rtl_bt/rtl8761b_config" }, + /* 8761BU */ + { IC_INFO(RTL_ROM_LMP_8761A, 0xb, 0xa, HCI_USB), + .config_needed = false, + .has_rom_version = true, + .fw_name = "rtl_bt/rtl8761bu_fw.bin", + .cfg_name = "rtl_bt/rtl8761bu_config" }, + /* 8822C with UART interface */ { IC_INFO(RTL_ROM_LMP_8822B, 0xc, 0xa, HCI_UART), .config_needed = true,