| Message ID | 20210531142450.30779-1-zhangqilong3@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] Bluetooth: btmtkuart: using pm_runtime_resume_and_get instead of pm_runtime_get_sync | expand |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=491203 ---Test result--- Test Summary: CheckPatch PASS 0.74 seconds GitLint FAIL 0.15 seconds BuildKernel PASS 529.81 seconds TestRunner: Setup PASS 359.79 seconds TestRunner: l2cap-tester PASS 2.65 seconds TestRunner: bnep-tester PASS 1.89 seconds TestRunner: mgmt-tester PASS 27.41 seconds TestRunner: rfcomm-tester PASS 2.08 seconds TestRunner: sco-tester PASS 2.06 seconds TestRunner: smp-tester PASS 2.14 seconds TestRunner: userchan-tester PASS 1.94 seconds Details ############################## Test: CheckPatch - PASS - 0.74 seconds Run checkpatch.pl script with rule in .checkpatch.conf ############################## Test: GitLint - FAIL - 0.15 seconds Run gitlint with rule in .gitlint Bluetooth: btmtkuart: using pm_runtime_resume_and_get instead of pm_runtime_get_sync 1: T1 Title exceeds max length (84>72): "Bluetooth: btmtkuart: using pm_runtime_resume_and_get instead of pm_runtime_get_sync" ############################## Test: BuildKernel - PASS - 529.81 seconds Build Kernel with minimal configuration supports Bluetooth ############################## Test: TestRunner: Setup - PASS - 359.79 seconds Setup environment for running Test Runner ############################## Test: TestRunner: l2cap-tester - PASS - 2.65 seconds Run test-runner with l2cap-tester Total: 40, Passed: 40 (100.0%), Failed: 0, Not Run: 0 ############################## Test: TestRunner: bnep-tester - PASS - 1.89 seconds Run test-runner with bnep-tester Total: 1, Passed: 1 (100.0%), Failed: 0, Not Run: 0 ############################## Test: TestRunner: mgmt-tester - PASS - 27.41 seconds Run test-runner with mgmt-tester Total: 433, Passed: 420 (97.0%), Failed: 0, Not Run: 13 ############################## Test: TestRunner: rfcomm-tester - PASS - 2.08 seconds Run test-runner with rfcomm-tester Total: 9, Passed: 9 (100.0%), Failed: 0, Not Run: 0 ############################## Test: TestRunner: sco-tester - PASS - 2.06 seconds Run test-runner with sco-tester Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0 ############################## Test: TestRunner: smp-tester - PASS - 2.14 seconds Run test-runner with smp-tester Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0 ############################## Test: TestRunner: userchan-tester - PASS - 1.94 seconds Run test-runner with userchan-tester Total: 3, Passed: 3 (100.0%), Failed: 0, Not Run: 0 --- Regards, Linux Bluetooth
Hi Zhang, > Using pm_runtime_resume_and_get is more appropriate > for simplifing code > > Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com> > --- > drivers/bluetooth/btmtkuart.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel
diff --git a/drivers/bluetooth/btmtkuart.c b/drivers/bluetooth/btmtkuart.c index 6c40bc75fb5b..e9d91d7c0db4 100644 --- a/drivers/bluetooth/btmtkuart.c +++ b/drivers/bluetooth/btmtkuart.c @@ -581,11 +581,9 @@ static int btmtkuart_open(struct hci_dev *hdev) /* Enable the power domain and clock the device requires */ pm_runtime_enable(dev); - err = pm_runtime_get_sync(dev); - if (err < 0) { - pm_runtime_put_noidle(dev); + err = pm_runtime_resume_and_get(dev); + if (err < 0) goto err_disable_rpm; - } err = clk_prepare_enable(bdev->clk); if (err < 0)
Using pm_runtime_resume_and_get is more appropriate for simplifing code Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com> --- drivers/bluetooth/btmtkuart.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)