| Message ID | 20210615200005.946131-1-alainm@chromium.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [Bluez] monitor: Adding missing device found flag in the parser | expand |
Hi Alain, > A new flag was added to the kernel implementation of the Device Found > event, but had not been added to the parser leading to an "Unknown device > flag" error in btmon. > > Reviewed-by: Yu Liu <yudiliu@google.com> > --- > > monitor/packet.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/monitor/packet.c b/monitor/packet.c > index 82513a63c..2c3a6cebf 100644 > --- a/monitor/packet.c > +++ b/monitor/packet.c > @@ -12033,6 +12033,7 @@ static const struct bitfield_data mgmt_device_flags_table[] = { > { 0, "Confirm Name" }, > { 1, "Legacy Pairing" }, > { 2, "Not Connectable" }, > + { 3, "Connection Locally Initiated" }, > { } please fix also the other }, so that they align. Regards Marcel
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=500957 ---Test result--- Test Summary: CheckPatch PASS 0.29 seconds GitLint PASS 0.12 seconds Prep - Setup ELL PASS 43.79 seconds Build - Prep PASS 0.10 seconds Build - Configure PASS 7.85 seconds Build - Make PASS 191.98 seconds Make Check PASS 9.61 seconds Make Distcheck PASS 226.34 seconds Build w/ext ELL - Configure PASS 7.96 seconds Build w/ext ELL - Make PASS 181.91 seconds Details ############################## Test: CheckPatch - PASS Desc: Run checkpatch.pl script with rule in .checkpatch.conf ############################## Test: GitLint - PASS Desc: Run gitlint with rule in .gitlint ############################## Test: Prep - Setup ELL - PASS Desc: Clone, build, and install ELL ############################## Test: Build - Prep - PASS Desc: Prepare environment for build ############################## Test: Build - Configure - PASS Desc: Configure the BlueZ source tree ############################## Test: Build - Make - PASS Desc: Build the BlueZ source tree ############################## Test: Make Check - PASS Desc: Run 'make check' ############################## Test: Make Distcheck - PASS Desc: Run distcheck to check the distribution ############################## Test: Build w/ext ELL - Configure - PASS Desc: Configure BlueZ source with '--enable-external-ell' configuration ############################## Test: Build w/ext ELL - Make - PASS Desc: Build BlueZ source with '--enable-external-ell' configuration --- Regards, Linux Bluetooth
diff --git a/monitor/packet.c b/monitor/packet.c index 82513a63c..2c3a6cebf 100644 --- a/monitor/packet.c +++ b/monitor/packet.c @@ -12033,6 +12033,7 @@ static const struct bitfield_data mgmt_device_flags_table[] = { { 0, "Confirm Name" }, { 1, "Legacy Pairing" }, { 2, "Not Connectable" }, + { 3, "Connection Locally Initiated" }, { } };
A new flag was added to the kernel implementation of the Device Found event, but had not been added to the parser leading to an "Unknown device flag" error in btmon. Reviewed-by: Yu Liu <yudiliu@google.com> --- monitor/packet.c | 1 + 1 file changed, 1 insertion(+)