| Message ID | 20210616130757.10084-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Bluetooth: btmrvl: remove redundant continue statement | expand |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=501579 ---Test result--- Test Summary: CheckPatch PASS 0.56 seconds GitLint PASS 0.10 seconds BuildKernel PASS 499.12 seconds TestRunner: Setup PASS 338.17 seconds TestRunner: l2cap-tester PASS 2.42 seconds TestRunner: bnep-tester PASS 1.89 seconds TestRunner: mgmt-tester PASS 27.60 seconds TestRunner: rfcomm-tester PASS 2.07 seconds TestRunner: sco-tester PASS 1.91 seconds TestRunner: smp-tester PASS 2.00 seconds TestRunner: userchan-tester PASS 1.88 seconds Details ############################## Test: CheckPatch - PASS - 0.56 seconds Run checkpatch.pl script with rule in .checkpatch.conf ############################## Test: GitLint - PASS - 0.10 seconds Run gitlint with rule in .gitlint ############################## Test: BuildKernel - PASS - 499.12 seconds Build Kernel with minimal configuration supports Bluetooth ############################## Test: TestRunner: Setup - PASS - 338.17 seconds Setup environment for running Test Runner ############################## Test: TestRunner: l2cap-tester - PASS - 2.42 seconds Run test-runner with l2cap-tester Total: 40, Passed: 40 (100.0%), Failed: 0, Not Run: 0 ############################## Test: TestRunner: bnep-tester - PASS - 1.89 seconds Run test-runner with bnep-tester Total: 1, Passed: 1 (100.0%), Failed: 0, Not Run: 0 ############################## Test: TestRunner: mgmt-tester - PASS - 27.60 seconds Run test-runner with mgmt-tester Total: 446, Passed: 433 (97.1%), Failed: 0, Not Run: 13 ############################## Test: TestRunner: rfcomm-tester - PASS - 2.07 seconds Run test-runner with rfcomm-tester Total: 9, Passed: 9 (100.0%), Failed: 0, Not Run: 0 ############################## Test: TestRunner: sco-tester - PASS - 1.91 seconds Run test-runner with sco-tester Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0 ############################## Test: TestRunner: smp-tester - PASS - 2.00 seconds Run test-runner with smp-tester Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0 ############################## Test: TestRunner: userchan-tester - PASS - 1.88 seconds Run test-runner with userchan-tester Total: 3, Passed: 3 (100.0%), Failed: 0, Not Run: 0 --- Regards, Linux Bluetooth
Hi Colin, > The continue statement in the for-loop has no effect, > remove it. > > Addresses-Coverity: ("Continue has no effect") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/bluetooth/btmrvl_sdio.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel
diff --git a/drivers/bluetooth/btmrvl_sdio.c b/drivers/bluetooth/btmrvl_sdio.c index 33d58b30c5ac..cddd350beba3 100644 --- a/drivers/bluetooth/btmrvl_sdio.c +++ b/drivers/bluetooth/btmrvl_sdio.c @@ -1461,9 +1461,7 @@ static void btmrvl_sdio_coredump(struct device *dev) BT_ERR("Allocated buffer not enough"); } - if (stat != RDWR_STATUS_DONE) { - continue; - } else { + if (stat == RDWR_STATUS_DONE) { BT_INFO("%s done: size=0x%tx", entry->mem_name, dbg_ptr - entry->mem_ptr);