diff mbox series

[BlueZ,v1] adv_monitor: Avoid skipping non-discoverable dev on Monitor match

Message ID 20210617215758.BlueZ.v1.1.Iaf42bf6ccbc1a06a9fb7f8da55bf7f2ef37349f2@changeid (mailing list archive)
State New, archived
Headers show
Series [BlueZ,v1] adv_monitor: Avoid skipping non-discoverable dev on Monitor match | expand

Commit Message

Manish Mandlik June 18, 2021, 4:58 a.m. UTC
Do no skip a non-discoverable device if it matches any Advertisement
Monitor.

Reviewed-by: mcchou@google.com
Reviewed-by: alainmichaud@google.com
Signed-off-by: Manish Mandlik <mmandlik@google.com>
---

 src/adapter.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

bluez.test.bot@gmail.com June 18, 2021, 5:40 a.m. UTC | #1
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=502943

---Test result---

Test Summary:
CheckPatch                    PASS      0.52 seconds
GitLint                       PASS      0.15 seconds
Prep - Setup ELL              PASS      47.36 seconds
Build - Prep                  PASS      0.11 seconds
Build - Configure             PASS      8.29 seconds
Build - Make                  PASS      203.05 seconds
Make Check                    PASS      8.86 seconds
Make Distcheck                PASS      243.32 seconds
Build w/ext ELL - Configure   PASS      8.30 seconds
Build w/ext ELL - Make        PASS      191.56 seconds

Details
##############################
Test: CheckPatch - PASS
Desc: Run checkpatch.pl script with rule in .checkpatch.conf

##############################
Test: GitLint - PASS
Desc: Run gitlint with rule in .gitlint

##############################
Test: Prep - Setup ELL - PASS
Desc: Clone, build, and install ELL

##############################
Test: Build - Prep - PASS
Desc: Prepare environment for build

##############################
Test: Build - Configure - PASS
Desc: Configure the BlueZ source tree

##############################
Test: Build - Make - PASS
Desc: Build the BlueZ source tree

##############################
Test: Make Check - PASS
Desc: Run 'make check'

##############################
Test: Make Distcheck - PASS
Desc: Run distcheck to check the distribution

##############################
Test: Build w/ext ELL - Configure - PASS
Desc: Configure BlueZ source with '--enable-external-ell' configuration

##############################
Test: Build w/ext ELL - Make - PASS
Desc: Build BlueZ source with '--enable-external-ell' configuration



---
Regards,
Linux Bluetooth
Luiz Augusto von Dentz June 24, 2021, 8:12 p.m. UTC | #2
Hi Manish,

On Thu, Jun 24, 2021 at 10:10 AM Manish Mandlik <mmandlik@google.com> wrote:
>
> Friendly reminder to review this patch.
>
> Regards,
> Manish.
>
>
> On Thu, Jun 17, 2021 at 9:58 PM Manish Mandlik <mmandlik@google.com> wrote:
>>
>> Do no skip a non-discoverable device if it matches any Advertisement
>> Monitor.
>>
>> Reviewed-by: mcchou@google.com
>> Reviewed-by: alainmichaud@google.com
>> Signed-off-by: Manish Mandlik <mmandlik@google.com>
>> ---
>>
>>  src/adapter.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/adapter.c b/src/adapter.c
>> index 98fc78f1e..2175120f4 100644
>> --- a/src/adapter.c
>> +++ b/src/adapter.c
>> @@ -6656,7 +6656,7 @@ static void update_found_devices(struct btd_adapter *adapter,
>>
>>         dev = btd_adapter_find_device(adapter, bdaddr, bdaddr_type);
>>         if (!dev) {
>> -               if (!discoverable) {
>> +               if (!discoverable && !matched_monitors) {
>>                         eir_data_free(&eir_data);
>>                         return;
>>                 }
>> --
>> 2.32.0.288.g62a8d224e6-goog
>>

Applied, thanks.
diff mbox series

Patch

diff --git a/src/adapter.c b/src/adapter.c
index 98fc78f1e..2175120f4 100644
--- a/src/adapter.c
+++ b/src/adapter.c
@@ -6656,7 +6656,7 @@  static void update_found_devices(struct btd_adapter *adapter,
 
 	dev = btd_adapter_find_device(adapter, bdaddr, bdaddr_type);
 	if (!dev) {
-		if (!discoverable) {
+		if (!discoverable && !matched_monitors) {
 			eir_data_free(&eir_data);
 			return;
 		}