[Bluez,20/62] monitor: Inclusive language in filtering devices

Message ID	20210813201256.Bluez.20.I63cb796d677d5bd085fc77cb1cb7164278b8e1cd@changeid (mailing list archive)
State	Superseded
Headers	show Return-Path: <linux-bluetooth-owner@kernel.org> Date: Fri, 13 Aug 2021 20:18:05 +0800 In-Reply-To: <20210813121848.3686029-1-apusaka@google.com> Message-Id: <20210813201256.Bluez.20.I63cb796d677d5bd085fc77cb1cb7164278b8e1cd@changeid> Mime-Version: 1.0 References: <20210813121848.3686029-1-apusaka@google.com> Subject: [Bluez PATCH 20/62] monitor: Inclusive language in filtering devices From: Archie Pusaka <apusaka@google.com> To: linux-bluetooth <linux-bluetooth@vger.kernel.org>, Luiz Augusto von Dentz <luiz.dentz@gmail.com> Cc: CrosBT Upstreaming <chromeos-bluetooth-upstreaming@chromium.org>, Archie Pusaka <apusaka@chromium.org> Content-Type: text/plain; charset="UTF-8" Precedence: bulk
Series	Inclusive language changes \| expand [Bluez,00/62] Inclusive language changes [Bluez,01/62] lib: Inclusive language in HCI commands and events [Bluez,02/62] lib: Inclusive language in consts and strings [Bluez,03/62] tools/hciconfig: Inclusive language update [Bluez,04/62] core: Inclusive language for l2cap [Bluez,05/62] core: Inclusive language for rfcomm [Bluez,06/62] lib: Inclusive language for filtering devices [Bluez,07/62] lib/mgmt: Inclusive language for LTK [Bluez,08/62] doc/mgmt: Inclusive language update [Bluez,09/62] btio: Inclusive language changes [Bluez,10/62] shared/ad: Inclusive language changes [Bluez,11/62] shared/hfp: Inclusive language changes [Bluez,12/62] monitor: Inclusive language in struct member [Bluez,13/62] monitor: Inclusive language in SMP related things [Bluez,14/62] monitor: Inclusive language in LE states [Bluez,15/62] monitor: Inclusive language in LL feature [Bluez,16/62] monitor: Inclusive language in link key transaction [Bluez,17/62] monitor: Inclusive language in peripheral broadcast [Bluez,18/62] monitor: Inclusive language in peripheral page response timeout [Bluez,19/62] monitor: Inclusive language in consts and strings [Bluez,20/62] monitor: Inclusive language in filtering devices [Bluez,21/62] emulator: Inclusive language in naming [Bluez,22/62] emulator: Inclusive language in strings [Bluez,23/62] emulator: Inclusive language in filtering device [Bluez,24/62] tools: Inclusive language in referring the central address [Bluez,25/62] tools/parser/hci: Inclusive language changes [Bluez,26/62] tools/parser/smp: Inclusive language changes [Bluez,27/62] tools/3dsp: Inclusive language changes [Bluez,28/62] tools/mgmt-tester: Inclusive language changes [Bluez,29/62] tools/bdaddr: Inclusive language changes [Bluez,30/62] tools/hciconfig: Inclusive language changes [Bluez,31/62] tools/meshctl: Inclusive language changes [Bluez,32/62] tools/mgmt-tester: Inclusive language changes [Bluez,33/62] tools/parser: Inclusive language in struct member [Bluez,34/62] tools/parser/lmp: Inclusive language changes [Bluez,35/62] tools/parser/avdtp: Inclusive language changes [Bluez,36/62] tools/parser/csr: Inclusive language changes [Bluez,37/62] tools/btpclientctl: Inclusive language changes [Bluez,38/62] tools/l2cap-tester: Inclusive language changes [Bluez,39/62] tools/hci-tester: Inclusive language changes [Bluez,40/62] tools/btiotest: Inclusive language changes [Bluez,41/62] tools/hcitool: Inclusive language changes, central peripheral [Bluez,42/62] tools/hcitool: Inclusive language changes, accept list [Bluez,43/62] tools/l2test: Inclusive language changes [Bluez,44/62] tools/rctest: Inclusive language changes [Bluez,45/62] tools/rfcomm: Inclusive language changes [Bluez,46/62] plugins/sixaxis: Inclusive language changes [Bluez,47/62] profiles/audio: Inclusive language changes [Bluez,48/62] profiles/health: Inclusive language changes [Bluez,49/62] sdp: Inclusive language changes [Bluez,50/62] adapter: Inclusive language for central and peripheral [Bluez,51/62] adapter: Inclusive language for storing LTK [Bluez,52/62] adapter: Inclusive language for device filtering [Bluez,53/62] client: Inclusive language changes [Bluez,54/62] mesh: Inclusive language changes [Bluez,55/62] tools/mesh: Inclusive language changes [Bluez,56/62] tools/mesh-gatt: Inclusive language changes [Bluez,57/62] unit/mesh: Inclusive language changes [Bluez,58/62] doc/mesh: Inclusive language changes [Bluez,59/62] android: Inclusive language for volume control [Bluez,60/62] android: Inclusive language for describing relation [Bluez,61/62] android: Inclusive language for filtering devices [Bluez,62/62] android: Inclusive language in storing LTK

diff --git a/emulator/btdev.c b/emulator/btdev.c index 159ebe6ec5..89f7701714 100644 --- a/emulator/btdev.c +++ b/emulator/btdev.c @@ -3492,11 +3492,11 @@ static int cmd_le_create_conn_complete(struct btdev *dev, const void *data, static int cmd_read_wl_size(struct btdev *dev, const void *data, uint8_t len) { - struct bt_hci_rsp_le_read_white_list_size rsp; + struct bt_hci_rsp_le_read_accept_list_size rsp; rsp.status = BT_HCI_ERR_SUCCESS; rsp.size = WL_SIZE; - cmd_complete(dev, BT_HCI_CMD_LE_READ_WHITE_LIST_SIZE, &rsp, + cmd_complete(dev, BT_HCI_CMD_LE_READ_ACCEPT_LIST_SIZE, &rsp, sizeof(rsp)); return 0; @@ -3544,7 +3544,7 @@ static int cmd_wl_clear(struct btdev *dev, const void *data, uint8_t len) wl_clear(dev); status = BT_HCI_ERR_SUCCESS; - cmd_complete(dev, BT_HCI_CMD_LE_CLEAR_WHITE_LIST, &status, + cmd_complete(dev, BT_HCI_CMD_LE_CLEAR_ACCEPT_LIST, &status, sizeof(status)); return 0; @@ -3561,7 +3561,7 @@ static void wl_add(struct btdev_wl *wl, uint8_t type, bdaddr_t *addr) static int cmd_add_wl(struct btdev *dev, const void *data, uint8_t len) { - const struct bt_hci_cmd_le_add_to_white_list *cmd = data; + const struct bt_hci_cmd_le_add_to_accept_list *cmd = data; uint8_t status; bool exists = false; int i, pos = -1; @@ -3597,14 +3597,14 @@ static int cmd_add_wl(struct btdev *dev, const void *data, uint8_t len) if (pos < 0) { cmd_status(dev, BT_HCI_ERR_MEM_CAPACITY_EXCEEDED, - BT_HCI_CMD_LE_ADD_TO_WHITE_LIST); + BT_HCI_CMD_LE_ADD_TO_ACCEPT_LIST); return 0; } wl_add(&dev->le_wl[pos], cmd->addr_type, (bdaddr_t *)&cmd->addr); status = BT_HCI_ERR_SUCCESS; - cmd_complete(dev, BT_HCI_CMD_LE_ADD_TO_WHITE_LIST, + cmd_complete(dev, BT_HCI_CMD_LE_ADD_TO_ACCEPT_LIST, &status, sizeof(status)); return 0; @@ -3612,7 +3612,7 @@ static int cmd_add_wl(struct btdev *dev, const void *data, uint8_t len) static int cmd_remove_wl(struct btdev *dev, const void *data, uint8_t len) { - const struct bt_hci_cmd_le_remove_from_white_list *cmd = data; + const struct bt_hci_cmd_le_remove_from_accept_list *cmd = data; uint8_t status; int i; char addr[18]; @@ -3652,7 +3652,7 @@ static int cmd_remove_wl(struct btdev *dev, const void *data, uint8_t len) return -EINVAL; status = BT_HCI_ERR_SUCCESS; - cmd_complete(dev, BT_HCI_CMD_LE_REMOVE_FROM_WHITE_LIST, + cmd_complete(dev, BT_HCI_CMD_LE_REMOVE_FROM_ACCEPT_LIST, &status, sizeof(status)); return 0; @@ -4237,10 +4237,10 @@ static int cmd_gen_dhkey(struct btdev *dev, const void *data, uint8_t len) cmd_set_scan_enable_complete), \ CMD(BT_HCI_CMD_LE_CREATE_CONN, cmd_le_create_conn, \ cmd_le_create_conn_complete), \ - CMD(BT_HCI_CMD_LE_READ_WHITE_LIST_SIZE, cmd_read_wl_size, NULL), \ - CMD(BT_HCI_CMD_LE_CLEAR_WHITE_LIST, cmd_wl_clear, NULL), \ - CMD(BT_HCI_CMD_LE_ADD_TO_WHITE_LIST, cmd_add_wl, NULL), \ - CMD(BT_HCI_CMD_LE_REMOVE_FROM_WHITE_LIST, cmd_remove_wl, NULL), \ + CMD(BT_HCI_CMD_LE_READ_ACCEPT_LIST_SIZE, cmd_read_wl_size, NULL), \ + CMD(BT_HCI_CMD_LE_CLEAR_ACCEPT_LIST, cmd_wl_clear, NULL), \ + CMD(BT_HCI_CMD_LE_ADD_TO_ACCEPT_LIST, cmd_add_wl, NULL), \ + CMD(BT_HCI_CMD_LE_REMOVE_FROM_ACCEPT_LIST, cmd_remove_wl, NULL), \ CMD(BT_HCI_CMD_LE_CONN_UPDATE, cmd_conn_update, \ cmd_conn_update_complete), \ CMD(BT_HCI_CMD_LE_READ_REMOTE_FEATURES, cmd_le_read_remote_features, \ diff --git a/emulator/le.c b/emulator/le.c index 4ffe3b16db..23f2579426 100644 --- a/emulator/le.c +++ b/emulator/le.c @@ -1211,12 +1211,12 @@ static void cmd_le_create_conn_cancel(struct bt_le *hci, static void cmd_le_read_white_list_size(struct bt_le *hci, const void *data, uint8_t size) { - struct bt_hci_rsp_le_read_white_list_size rsp; + struct bt_hci_rsp_le_read_accept_list_size rsp; rsp.status = BT_HCI_ERR_SUCCESS; rsp.size = hci->le_white_list_size; - cmd_complete(hci, BT_HCI_CMD_LE_READ_WHITE_LIST_SIZE, + cmd_complete(hci, BT_HCI_CMD_LE_READ_ACCEPT_LIST_SIZE, &rsp, sizeof(rsp)); } @@ -1228,14 +1228,14 @@ static void cmd_le_clear_white_list(struct bt_le *hci, clear_white_list(hci); status = BT_HCI_ERR_SUCCESS; - cmd_complete(hci, BT_HCI_CMD_LE_CLEAR_WHITE_LIST, + cmd_complete(hci, BT_HCI_CMD_LE_CLEAR_ACCEPT_LIST, &status, sizeof(status)); } static void cmd_le_add_to_white_list(struct bt_le *hci, const void *data, uint8_t size) { - const struct bt_hci_cmd_le_add_to_white_list *cmd = data; + const struct bt_hci_cmd_le_add_to_accept_list *cmd = data; uint8_t status; bool exists = false; int i, pos = -1; @@ -1243,7 +1243,7 @@ static void cmd_le_add_to_white_list(struct bt_le *hci, /* Valid range for address type is 0x00 to 0x01 */ if (cmd->addr_type > 0x01) { cmd_status(hci, BT_HCI_ERR_INVALID_PARAMETERS, - BT_HCI_CMD_LE_ADD_TO_WHITE_LIST); + BT_HCI_CMD_LE_ADD_TO_ACCEPT_LIST); return; } @@ -1259,13 +1259,13 @@ static void cmd_le_add_to_white_list(struct bt_le *hci, if (exists) { cmd_status(hci, BT_HCI_ERR_UNSPECIFIED_ERROR, - BT_HCI_CMD_LE_ADD_TO_WHITE_LIST); + BT_HCI_CMD_LE_ADD_TO_ACCEPT_LIST); return; } if (pos < 0) { cmd_status(hci, BT_HCI_ERR_MEM_CAPACITY_EXCEEDED, - BT_HCI_CMD_LE_ADD_TO_WHITE_LIST); + BT_HCI_CMD_LE_ADD_TO_ACCEPT_LIST); return; } @@ -1273,21 +1273,21 @@ static void cmd_le_add_to_white_list(struct bt_le *hci, memcpy(&hci->le_white_list[pos][1], cmd->addr, 6); status = BT_HCI_ERR_SUCCESS; - cmd_complete(hci, BT_HCI_CMD_LE_ADD_TO_WHITE_LIST, + cmd_complete(hci, BT_HCI_CMD_LE_ADD_TO_ACCEPT_LIST, &status, sizeof(status)); } static void cmd_le_remove_from_white_list(struct bt_le *hci, const void *data, uint8_t size) { - const struct bt_hci_cmd_le_remove_from_white_list *cmd = data; + const struct bt_hci_cmd_le_remove_from_accept_list *cmd = data; uint8_t status; int i, pos = -1; /* Valid range for address type is 0x00 to 0x01 */ if (cmd->addr_type > 0x01) { cmd_status(hci, BT_HCI_ERR_INVALID_PARAMETERS, - BT_HCI_CMD_LE_REMOVE_FROM_WHITE_LIST); + BT_HCI_CMD_LE_REMOVE_FROM_ACCEPT_LIST); return; } @@ -1302,7 +1302,7 @@ static void cmd_le_remove_from_white_list(struct bt_le *hci, if (pos < 0) { cmd_status(hci, BT_HCI_ERR_INVALID_PARAMETERS, - BT_HCI_CMD_LE_REMOVE_FROM_WHITE_LIST); + BT_HCI_CMD_LE_REMOVE_FROM_ACCEPT_LIST); return; } @@ -1310,7 +1310,7 @@ static void cmd_le_remove_from_white_list(struct bt_le *hci, memset(&hci->le_white_list[pos][1], 0, 6); status = BT_HCI_ERR_SUCCESS; - cmd_complete(hci, BT_HCI_CMD_LE_REMOVE_FROM_WHITE_LIST, + cmd_complete(hci, BT_HCI_CMD_LE_REMOVE_FROM_ACCEPT_LIST, &status, sizeof(status)); } @@ -1830,13 +1830,13 @@ static const struct { cmd_le_create_conn, 25, true }, { BT_HCI_CMD_LE_CREATE_CONN_CANCEL, cmd_le_create_conn_cancel, 0, true }, - { BT_HCI_CMD_LE_READ_WHITE_LIST_SIZE, + { BT_HCI_CMD_LE_READ_ACCEPT_LIST_SIZE, cmd_le_read_white_list_size, 0, true }, - { BT_HCI_CMD_LE_CLEAR_WHITE_LIST, + { BT_HCI_CMD_LE_CLEAR_ACCEPT_LIST, cmd_le_clear_white_list, 0, true }, - { BT_HCI_CMD_LE_ADD_TO_WHITE_LIST, + { BT_HCI_CMD_LE_ADD_TO_ACCEPT_LIST, cmd_le_add_to_white_list, 7, true }, - { BT_HCI_CMD_LE_REMOVE_FROM_WHITE_LIST, + { BT_HCI_CMD_LE_REMOVE_FROM_ACCEPT_LIST, cmd_le_remove_from_white_list, 7, true }, { BT_HCI_CMD_LE_ENCRYPT, cmd_le_encrypt, 32, true }, diff --git a/monitor/bt.h b/monitor/bt.h index 3144c25ff0..3150e82f3a 100644 --- a/monitor/bt.h +++ b/monitor/bt.h @@ -2072,22 +2072,22 @@ struct bt_hci_cmd_le_create_conn { #define BT_HCI_CMD_LE_CREATE_CONN_CANCEL 0x200e -#define BT_HCI_CMD_LE_READ_WHITE_LIST_SIZE 0x200f -struct bt_hci_rsp_le_read_white_list_size { +#define BT_HCI_CMD_LE_READ_ACCEPT_LIST_SIZE 0x200f +struct bt_hci_rsp_le_read_accept_list_size { uint8_t status; uint8_t size; } __attribute__ ((packed)); -#define BT_HCI_CMD_LE_CLEAR_WHITE_LIST 0x2010 +#define BT_HCI_CMD_LE_CLEAR_ACCEPT_LIST 0x2010 -#define BT_HCI_CMD_LE_ADD_TO_WHITE_LIST 0x2011 -struct bt_hci_cmd_le_add_to_white_list { +#define BT_HCI_CMD_LE_ADD_TO_ACCEPT_LIST 0x2011 +struct bt_hci_cmd_le_add_to_accept_list { uint8_t addr_type; uint8_t addr[6]; } __attribute__ ((packed)); -#define BT_HCI_CMD_LE_REMOVE_FROM_WHITE_LIST 0x2012 -struct bt_hci_cmd_le_remove_from_white_list { +#define BT_HCI_CMD_LE_REMOVE_FROM_ACCEPT_LIST 0x2012 +struct bt_hci_cmd_le_remove_from_accept_list { uint8_t addr_type; uint8_t addr[6]; } __attribute__ ((packed)); diff --git a/monitor/packet.c b/monitor/packet.c index 17da5a08d9..82763cc27b 100644 --- a/monitor/packet.c +++ b/monitor/packet.c @@ -2164,16 +2164,16 @@ static void print_adv_filter_policy(const char *label, uint8_t value) "Allow Connect Request from Any"; break; case 0x01: - str = "Allow Scan Request from White List Only, " + str = "Allow Scan Request from Accept List Only, " "Allow Connect Request from Any"; break; case 0x02: str = "Allow Scan Request from Any, " - "Allow Connect Request from White List Only"; + "Allow Connect Request from Accept List Only"; break; case 0x03: - str = "Allow Scan Request from White List Only, " - "Allow Connect Request from White List Only"; + str = "Allow Scan Request from Accept List Only, " + "Allow Connect Request from Accept List Only"; break; default: str = "Reserved"; @@ -6534,13 +6534,13 @@ static void print_scan_filter_policy(uint8_t policy) str = "Accept all advertisement"; break; case 0x01: - str = "Ignore not in white list"; + str = "Ignore not in accept list"; break; case 0x02: str = "Accept all advertisement, inc. directed unresolved RPA"; break; case 0x03: - str = "Ignore not in white list, exc. directed unresolved RPA"; + str = "Ignore not in accept list, exc. directed unresolved RPA"; break; default: str = "Reserved"; @@ -6579,10 +6579,10 @@ static void le_create_conn_cmd(const void *data, uint8_t size) switch (cmd->filter_policy) { case 0x00: - str = "White list is not used"; + str = "Accept list is not used"; break; case 0x01: - str = "White list is used"; + str = "Accept list is used"; break; default: str = "Reserved"; @@ -6605,25 +6605,25 @@ static void le_create_conn_cmd(const void *data, uint8_t size) print_slot_625("Max connection length", cmd->max_length); } -static void le_read_white_list_size_rsp(const void *data, uint8_t size) +static void le_read_accept_list_size_rsp(const void *data, uint8_t size) { - const struct bt_hci_rsp_le_read_white_list_size *rsp = data; + const struct bt_hci_rsp_le_read_accept_list_size *rsp = data; print_status(rsp->status); print_field("Size: %u", rsp->size); } -static void le_add_to_white_list_cmd(const void *data, uint8_t size) +static void le_add_to_accept_list_cmd(const void *data, uint8_t size) { - const struct bt_hci_cmd_le_add_to_white_list *cmd = data; + const struct bt_hci_cmd_le_add_to_accept_list *cmd = data; print_addr_type("Address type", cmd->addr_type); print_addr("Address", cmd->addr, cmd->addr_type); } -static void le_remove_from_white_list_cmd(const void *data, uint8_t size) +static void le_remove_from_accept_list_cmd(const void *data, uint8_t size) { - const struct bt_hci_cmd_le_remove_from_white_list *cmd = data; + const struct bt_hci_cmd_le_remove_from_accept_list *cmd = data; print_addr_type("Address type", cmd->addr_type); print_addr("Address", cmd->addr, cmd->addr_type); @@ -7562,10 +7562,10 @@ static void le_ext_create_conn_cmd(const void *data, uint8_t size) switch (cmd->filter_policy) { case 0x00: - str = "White list is not used"; + str = "Accept list is not used"; break; case 0x01: - str = "White list is used"; + str = "Accept list is used"; break; default: str = "Reserved"; @@ -8990,17 +8990,17 @@ static const struct opcode_data opcode_table[] = { { 0x200e, 213, "LE Create Connection Cancel", null_cmd, 0, true, status_rsp, 1, true }, - { 0x200f, 214, "LE Read White List Size", + { 0x200f, 214, "LE Read Accept List Size", null_cmd, 0, true, - le_read_white_list_size_rsp, 2, true }, - { 0x2010, 215, "LE Clear White List", + le_read_accept_list_size_rsp, 2, true }, + { 0x2010, 215, "LE Clear Accept List", null_cmd, 0, true, status_rsp, 1, true }, - { 0x2011, 216, "LE Add Device To White List", - le_add_to_white_list_cmd, 7, true, + { 0x2011, 216, "LE Add Device To Accept List", + le_add_to_accept_list_cmd, 7, true, status_rsp, 1, true }, - { 0x2012, 217, "LE Remove Device From White List", - le_remove_from_white_list_cmd, 7, true, + { 0x2012, 217, "LE Remove Device From Accept List", + le_remove_from_accept_list_cmd, 7, true, status_rsp, 1, true }, { 0x2013, 218, "LE Connection Update", le_conn_update_cmd, 14, true }, diff --git a/tools/hci-tester.c b/tools/hci-tester.c index 0fb74e69c7..645d89e721 100644 --- a/tools/hci-tester.c +++ b/tools/hci-tester.c @@ -337,12 +337,12 @@ static void test_read_local_supported_codecs(const void *test_data) static void test_le_read_white_list_size(const void *test_data) { - test_command(BT_HCI_CMD_LE_READ_WHITE_LIST_SIZE); + test_command(BT_HCI_CMD_LE_READ_ACCEPT_LIST_SIZE); } static void test_le_clear_white_list(const void *test_data) { - test_command(BT_HCI_CMD_LE_CLEAR_WHITE_LIST); + test_command(BT_HCI_CMD_LE_CLEAR_ACCEPT_LIST); } static void test_le_encrypt_complete(const void *data, uint8_t size, diff --git a/tools/mgmt-tester.c b/tools/mgmt-tester.c index e369d7488b..26d78360d7 100644 --- a/tools/mgmt-tester.c +++ b/tools/mgmt-tester.c @@ -4248,7 +4248,7 @@ static const struct generic_data add_device_success_6 = { .expect_alt_ev = MGMT_EV_DEVICE_ADDED, .expect_alt_ev_param = add_device_success_param_6, .expect_alt_ev_len = sizeof(add_device_success_param_6), - .expect_hci_command = BT_HCI_CMD_LE_ADD_TO_WHITE_LIST, + .expect_hci_command = BT_HCI_CMD_LE_ADD_TO_ACCEPT_LIST, .expect_hci_param = le_add_to_white_list_param, .expect_hci_len = sizeof(le_add_to_white_list_param), }; @@ -4418,7 +4418,7 @@ static const struct generic_data remove_device_success_7 = { .expect_param = remove_device_param_2, .expect_len = sizeof(remove_device_param_2), .expect_status = MGMT_STATUS_SUCCESS, - .expect_hci_command = BT_HCI_CMD_LE_REMOVE_FROM_WHITE_LIST, + .expect_hci_command = BT_HCI_CMD_LE_REMOVE_FROM_ACCEPT_LIST, .expect_hci_param = le_add_to_white_list_param, .expect_hci_len = sizeof(le_add_to_white_list_param), .expect_alt_ev = MGMT_EV_DEVICE_REMOVED,

[Bluez,20/62] monitor: Inclusive language in filtering devices

Commit Message

Patch