| Message ID | 20211013053935.BlueZ.v2.1.I7f6bdb9282c1e12ffc6c662674678f2b1cb69182@changeid (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Luiz Von Dentz |
| Headers | show |
| Series | Update Device Found event and add Adv Monitor Device Lost event | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/checkpatch | success | Checkpatch PASS |
| tedd_an/gitlint | success | Gitlint PASS |
| tedd_an/setupell | success | Setup ELL PASS |
| tedd_an/buildprep | success | Build Prep PASS |
| tedd_an/build | success | Build Configuration PASS |
| tedd_an/makecheck | success | Make Check PASS |
| tedd_an/makedistcheck | success | Make Distcheck PASS |
| tedd_an/build_extell | success | Build External ELL PASS |
| tedd_an/build_extell_make | success | Build Make with External ELL PASS |
Hi Manish, > Add a flag 'Device Tracked' to the existing 'Device Found' event to > indicate that the controller has started tracking the device matching > an Advertisement Monitor with handle 'Monitor_Handle'. > > Add a new event 'Adv Monitor Device Lost' to indicate that the > controller has stopped tracking that particular device. > > --- > > Changes in v2: > - Instead of creating a new 'Device Tracking' event, add a flag 'Device > Tracked' in the existing 'Device Found' event and add a new 'Device > Lost' event to indicate that the controller has stopped tracking that > device. > > doc/mgmt-api.txt | 32 +++++++++++++++++++++++++++++++- > 1 file changed, 31 insertions(+), 1 deletion(-) > > diff --git a/doc/mgmt-api.txt b/doc/mgmt-api.txt > index 5355fedb0..0fd884ed0 100644 > --- a/doc/mgmt-api.txt > +++ b/doc/mgmt-api.txt > @@ -107,7 +107,8 @@ Configuration command, Default Runtime Configuration Changed event, Get > Device Flags command, Set Device Flags command, Device Flags Changed event, > Read Advertisement Monitor Features command, Add Advertisement Patterns > Monitor command, Remove Advertisement Monitor command, Advertisement Monitor > -Added event and Advertisement Monitor Removed event. > +Added event, Advertisement Monitor Removed event, Updated Device Found event > +and Added Advertisement Monitor Device Lost event. > > > Example > @@ -4247,6 +4248,7 @@ Device Found Event > Address_Type (1 Octet) > RSSI (1 Octet) > Flags (4 Octets) > + Monitor_Handle (2 Octets) > EIR_Data_Length (2 Octets) > EIR_Data (0-65535 Octets) you can not do this. This breaks ABI. Regards Marcel
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=562679 ---Test result--- Test Summary: CheckPatch PASS 4.43 seconds GitLint PASS 2.88 seconds Prep - Setup ELL PASS 46.60 seconds Build - Prep PASS 0.52 seconds Build - Configure PASS 8.49 seconds Build - Make PASS 200.15 seconds Make Check PASS 10.19 seconds Make Distcheck PASS 239.36 seconds Build w/ext ELL - Configure PASS 8.59 seconds Build w/ext ELL - Make PASS 188.50 seconds --- Regards, Linux Bluetooth
Hi Marcel, Manish, On Wed, Oct 13, 2021 at 6:15 AM Marcel Holtmann <marcel@holtmann.org> wrote: > > Hi Manish, > > > Add a flag 'Device Tracked' to the existing 'Device Found' event to > > indicate that the controller has started tracking the device matching > > an Advertisement Monitor with handle 'Monitor_Handle'. > > > > Add a new event 'Adv Monitor Device Lost' to indicate that the > > controller has stopped tracking that particular device. > > > > --- > > > > Changes in v2: > > - Instead of creating a new 'Device Tracking' event, add a flag 'Device > > Tracked' in the existing 'Device Found' event and add a new 'Device > > Lost' event to indicate that the controller has stopped tracking that > > device. > > > > doc/mgmt-api.txt | 32 +++++++++++++++++++++++++++++++- > > 1 file changed, 31 insertions(+), 1 deletion(-) > > > > diff --git a/doc/mgmt-api.txt b/doc/mgmt-api.txt > > index 5355fedb0..0fd884ed0 100644 > > --- a/doc/mgmt-api.txt > > +++ b/doc/mgmt-api.txt > > @@ -107,7 +107,8 @@ Configuration command, Default Runtime Configuration Changed event, Get > > Device Flags command, Set Device Flags command, Device Flags Changed event, > > Read Advertisement Monitor Features command, Add Advertisement Patterns > > Monitor command, Remove Advertisement Monitor command, Advertisement Monitor > > -Added event and Advertisement Monitor Removed event. > > +Added event, Advertisement Monitor Removed event, Updated Device Found event > > +and Added Advertisement Monitor Device Lost event. > > > > > > Example > > @@ -4247,6 +4248,7 @@ Device Found Event > > Address_Type (1 Octet) > > RSSI (1 Octet) > > Flags (4 Octets) > > + Monitor_Handle (2 Octets) > > EIR_Data_Length (2 Octets) > > EIR_Data (0-65535 Octets) > > you can not do this. This breaks ABI. I was going to say that, we can't be adding parameters to existing commands/events as that is not backward compatible (old bluetoothd won't be able to parse them properly). That said, I wonder why it needs the handle though? Wouldn't a flag be enough to indicate that has been found via monitor filtering or do we need to know the exact monitor rule that has triggered it? Btw, afaik monitor handles as 1 octet not 2.
diff --git a/doc/mgmt-api.txt b/doc/mgmt-api.txt index 5355fedb0..0fd884ed0 100644 --- a/doc/mgmt-api.txt +++ b/doc/mgmt-api.txt @@ -107,7 +107,8 @@ Configuration command, Default Runtime Configuration Changed event, Get Device Flags command, Set Device Flags command, Device Flags Changed event, Read Advertisement Monitor Features command, Add Advertisement Patterns Monitor command, Remove Advertisement Monitor command, Advertisement Monitor -Added event and Advertisement Monitor Removed event. +Added event, Advertisement Monitor Removed event, Updated Device Found event +and Added Advertisement Monitor Device Lost event. Example @@ -4247,6 +4248,7 @@ Device Found Event Address_Type (1 Octet) RSSI (1 Octet) Flags (4 Octets) + Monitor_Handle (2 Octets) EIR_Data_Length (2 Octets) EIR_Data (0-65535 Octets) @@ -4263,6 +4265,7 @@ Device Found Event 1 Legacy Pairing 2 Not Connectable 3 Reserved (not in use) + 4 Device Tracked For the RSSI field a value of 127 indicates that the RSSI is not available. That can happen with Bluetooth 1.1 and earlier @@ -4285,6 +4288,10 @@ Device Found Event accept any connections. This can be indicated by Low Energy devices that are in broadcaster role. + The Device Tracked flag indicates that the controller has started + monitoring a particular device matching the Advertisement Monitor + with handle Monitor_Handle. + Discovering Event ================= @@ -4910,3 +4917,26 @@ Controller Resume Event Address_Type. Otherwise, Address and Address_Type will both be zero. This event will be sent to all management sockets. + + +Advertisement Monitor Device Lost Event +======================================= + + Event code: 0x002f + Controller Index: <controller_id> + Event Parameters: Monitor_Handle (2 Octets) + Address (6 Octets) + Address_Type (1 Octet) + + This event indicates that the controller has stopped tracking the + device that was being tracked by monitor with handle Monitor_Handle. + + The address of the device being tracked will be shared in Address and + Address_Type. + + Possible values for the Address_Type parameter: + 0 BR/EDR + 1 LE Public + 2 LE Random + + This event will be sent to all management sockets.