diff mbox series

[BlueZ,2/2] a2dp: error return paths in a2dp_reconfig must free allocated setup

Message ID 20220605122927.110627-2-pav@iki.fi (mailing list archive)
State Accepted
Commit 9c288dd23a3bbd4a4e41c69882f5f18212da62b5
Headers show
Series [BlueZ,1/2] a2dp: disallow multiple SetConfiguration to same local SEP | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/checkpatch success Checkpatch PASS
tedd_an/gitlint success Gitlint PASS

Commit Message

Pauli Virtanen June 5, 2022, 12:29 p.m. UTC 
---
 profiles/audio/a2dp.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/profiles/audio/a2dp.c b/profiles/audio/a2dp.c
index f3e2cdd9e..276512208 100644
--- a/profiles/audio/a2dp.c
+++ b/profiles/audio/a2dp.c
@@ -1876,8 +1876,10 @@  static int a2dp_reconfig(struct a2dp_channel *chan, const char *sender,
 		if (tmp->stream) {
 			/* Only allow switching sep from the same sender */
 			if (strcmp(sender, tmp->endpoint->get_name(tmp,
-							tmp->user_data)))
-				return -EPERM;
+							tmp->user_data))) {
+				err = -EPERM;
+				goto fail;
+			}
 
 			/* Check if stream is for the channel */
 			if (!avdtp_has_stream(chan->session, tmp->stream))