| Message ID | 20220801103633.27772-2-sven@svenpeter.dev (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Broadcom/Apple Bluetooth driver for Apple Silicon | expand |
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=664458
---Test result---
Test Summary:
CheckPatch FAIL 4.23 seconds
GitLint FAIL 1.36 seconds
SubjectPrefix FAIL 0.58 seconds
BuildKernel PASS 44.19 seconds
BuildKernel32 PASS 38.19 seconds
Incremental Build with patchesPASS 136.13 seconds
TestRunner: Setup PASS 638.46 seconds
TestRunner: l2cap-tester PASS 20.84 seconds
TestRunner: bnep-tester PASS 8.28 seconds
TestRunner: mgmt-tester PASS 130.01 seconds
TestRunner: rfcomm-tester PASS 12.10 seconds
TestRunner: sco-tester PASS 12.07 seconds
TestRunner: smp-tester PASS 11.87 seconds
TestRunner: userchan-tester PASS 8.45 seconds
Details
##############################
Test: CheckPatch - FAIL - 4.23 seconds
Run checkpatch.pl script with rule in .checkpatch.conf
[1/5] dt-bindings: net: Add generic Bluetooth controller\Traceback (most recent call last):
File "scripts/spdxcheck.py", line 6, in <module>
from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#118:
new file mode 100644
total: 0 errors, 1 warnings, 36 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/12933676.patch has style problems, please review.
NOTE: Ignored message types: UNKNOWN_COMMIT_ID
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
[3/5] Bluetooth: hci_event: Add quirk to ignore byte in LE Extended Adv Report\WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#113:
> HCI Event: LE Meta Event (0x3e) plen 55 #1 [hci0] 0.912271
ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit fatal: unsaf ("ace/src' is owned by someone else)")'
#142:
Data: 311f013c86ab
total: 1 errors, 1 warnings, 0 checks, 27 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/12933678.patch has style problems, please review.
NOTE: Ignored message types: UNKNOWN_COMMIT_ID
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
[4/5] Bluetooth: Add quirk to disable extended scanning\WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#106:
< HCI Command: LE Read Supported St.. (0x08|0x001c) plen 0 #27 [hci0] 2.971839
total: 0 errors, 1 warnings, 26 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/12933679.patch has style problems, please review.
NOTE: Ignored message types: UNKNOWN_COMMIT_ID
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
##############################
Test: GitLint - FAIL - 1.36 seconds
Run gitlint with rule in .gitlint
[1/5] dt-bindings: net: Add generic Bluetooth controller
14: B1 Line exceeds max length (83>80): " create mode 100644 Documentation/devicetree/bindings/net/bluetooth-controller.yaml"
[2/5] dt-bindings: net: Add Broadcom BCM4377 family PCI Bluetooth
13: B1 Line exceeds max length (85>80): " create mode 100644 Documentation/devicetree/bindings/net/brcm,bcm4377-bluetooth.yaml"
[3/5] Bluetooth: hci_event: Add quirk to ignore byte in LE Extended Adv Report
25: B1 Line exceeds max length (101>80): " Address: XX:XX:XX:XX:XX:XX (Shenzhen Jingxun Software Telecommunication Technology Co.,Ltd)"
##############################
Test: SubjectPrefix - FAIL - 0.58 seconds
Check subject contains "Bluetooth" prefix
"Bluetooth: " is not specified in the subject
"Bluetooth: " is not specified in the subject
---
Regards,
Linux Bluetooth
On Mon, Aug 01, 2022 at 12:36:29PM +0200, Sven Peter wrote: > Bluetooth controllers share the common local-bd-address property. > Add a generic YAML schema to replace bluetooth.txt for those. > > Signed-off-by: Sven Peter <sven@svenpeter.dev> > --- > I hope it's fine to list the current Bluetooth maintainers in here > as well. > > .../bindings/net/bluetooth-controller.yaml | 30 +++++++++++++++++++ > .../devicetree/bindings/net/bluetooth.txt | 6 +--- > 2 files changed, 31 insertions(+), 5 deletions(-) > create mode 100644 Documentation/devicetree/bindings/net/bluetooth-controller.yaml > > diff --git a/Documentation/devicetree/bindings/net/bluetooth-controller.yaml b/Documentation/devicetree/bindings/net/bluetooth-controller.yaml > new file mode 100644 > index 000000000000..0ea8a20e30f9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/bluetooth-controller.yaml > @@ -0,0 +1,30 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/bluetooth-controller.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Bluetooth Controller Generic Binding > + > +maintainers: > + - Marcel Holtmann <marcel@holtmann.org> > + - Johan Hedberg <johan.hedberg@gmail.com> > + - Luiz Augusto von Dentz <luiz.dentz@gmail.com> > + > +properties: > + $nodename: > + pattern: "^bluetooth(@.*)?$" > + > + local-bd-address: > + $ref: /schemas/types.yaml#/definitions/uint8-array > + minItems: 6 > + maxItems: 6 > + description: > + Specifies the BD address that was uniquely assigned to the Bluetooth > + device. Formatted with least significant byte first (little-endian), e.g. > + in order to assign the address 00:11:22:33:44:55 this property must have > + the value [55 44 33 22 11 00]. > + > +additionalProperties: true > + > +... > diff --git a/Documentation/devicetree/bindings/net/bluetooth.txt b/Documentation/devicetree/bindings/net/bluetooth.txt > index 94797df751b8..3cb5a7b8e5ad 100644 > --- a/Documentation/devicetree/bindings/net/bluetooth.txt > +++ b/Documentation/devicetree/bindings/net/bluetooth.txt > @@ -1,5 +1 @@ > -The following properties are common to the Bluetooth controllers: > - > -- local-bd-address: array of 6 bytes, specifies the BD address that was > - uniquely assigned to the Bluetooth device, formatted with least significant > - byte first (little-endian). > +This file has been moved to bluetooth-controller.yaml. There's one reference to bluetooth.txt. Update it and remove this file. Rob
Hi, On Mon, Aug 1, 2022, at 17:23, Rob Herring wrote: > On Mon, Aug 01, 2022 at 12:36:29PM +0200, Sven Peter wrote: >> Bluetooth controllers share the common local-bd-address property. >> Add a generic YAML schema to replace bluetooth.txt for those. >> >> Signed-off-by: Sven Peter <sven@svenpeter.dev> >> --- >> I hope it's fine to list the current Bluetooth maintainers in here >> as well. >> >> .../bindings/net/bluetooth-controller.yaml | 30 +++++++++++++++++++ >> .../devicetree/bindings/net/bluetooth.txt | 6 +--- >> 2 files changed, 31 insertions(+), 5 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/net/bluetooth-controller.yaml >> >> diff --git a/Documentation/devicetree/bindings/net/bluetooth-controller.yaml b/Documentation/devicetree/bindings/net/bluetooth-controller.yaml >> new file mode 100644 >> index 000000000000..0ea8a20e30f9 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/bluetooth-controller.yaml >> @@ -0,0 +1,30 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/net/bluetooth-controller.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Bluetooth Controller Generic Binding >> + >> +maintainers: >> + - Marcel Holtmann <marcel@holtmann.org> >> + - Johan Hedberg <johan.hedberg@gmail.com> >> + - Luiz Augusto von Dentz <luiz.dentz@gmail.com> >> + >> +properties: >> + $nodename: >> + pattern: "^bluetooth(@.*)?$" >> + >> + local-bd-address: >> + $ref: /schemas/types.yaml#/definitions/uint8-array >> + minItems: 6 >> + maxItems: 6 >> + description: >> + Specifies the BD address that was uniquely assigned to the Bluetooth >> + device. Formatted with least significant byte first (little-endian), e.g. >> + in order to assign the address 00:11:22:33:44:55 this property must have >> + the value [55 44 33 22 11 00]. >> + >> +additionalProperties: true >> + >> +... >> diff --git a/Documentation/devicetree/bindings/net/bluetooth.txt b/Documentation/devicetree/bindings/net/bluetooth.txt >> index 94797df751b8..3cb5a7b8e5ad 100644 >> --- a/Documentation/devicetree/bindings/net/bluetooth.txt >> +++ b/Documentation/devicetree/bindings/net/bluetooth.txt >> @@ -1,5 +1 @@ >> -The following properties are common to the Bluetooth controllers: >> - >> -- local-bd-address: array of 6 bytes, specifies the BD address that was >> - uniquely assigned to the Bluetooth device, formatted with least significant >> - byte first (little-endian). >> +This file has been moved to bluetooth-controller.yaml. > > There's one reference to bluetooth.txt. Update it and remove this file. Sure, I've just checked and found Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml and Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml and will update both for v2 and remove bluetooth.txt. Thanks, Sven
diff --git a/Documentation/devicetree/bindings/net/bluetooth-controller.yaml b/Documentation/devicetree/bindings/net/bluetooth-controller.yaml new file mode 100644 index 000000000000..0ea8a20e30f9 --- /dev/null +++ b/Documentation/devicetree/bindings/net/bluetooth-controller.yaml @@ -0,0 +1,30 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/bluetooth-controller.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Bluetooth Controller Generic Binding + +maintainers: + - Marcel Holtmann <marcel@holtmann.org> + - Johan Hedberg <johan.hedberg@gmail.com> + - Luiz Augusto von Dentz <luiz.dentz@gmail.com> + +properties: + $nodename: + pattern: "^bluetooth(@.*)?$" + + local-bd-address: + $ref: /schemas/types.yaml#/definitions/uint8-array + minItems: 6 + maxItems: 6 + description: + Specifies the BD address that was uniquely assigned to the Bluetooth + device. Formatted with least significant byte first (little-endian), e.g. + in order to assign the address 00:11:22:33:44:55 this property must have + the value [55 44 33 22 11 00]. + +additionalProperties: true + +... diff --git a/Documentation/devicetree/bindings/net/bluetooth.txt b/Documentation/devicetree/bindings/net/bluetooth.txt index 94797df751b8..3cb5a7b8e5ad 100644 --- a/Documentation/devicetree/bindings/net/bluetooth.txt +++ b/Documentation/devicetree/bindings/net/bluetooth.txt @@ -1,5 +1 @@ -The following properties are common to the Bluetooth controllers: - -- local-bd-address: array of 6 bytes, specifies the BD address that was - uniquely assigned to the Bluetooth device, formatted with least significant - byte first (little-endian). +This file has been moved to bluetooth-controller.yaml.
Bluetooth controllers share the common local-bd-address property. Add a generic YAML schema to replace bluetooth.txt for those. Signed-off-by: Sven Peter <sven@svenpeter.dev> --- I hope it's fine to list the current Bluetooth maintainers in here as well. .../bindings/net/bluetooth-controller.yaml | 30 +++++++++++++++++++ .../devicetree/bindings/net/bluetooth.txt | 6 +--- 2 files changed, 31 insertions(+), 5 deletions(-) create mode 100644 Documentation/devicetree/bindings/net/bluetooth-controller.yaml