diff mbox series

[BlueZ,1/2] hostname: Add '' around printed strings

Message ID 20221109151756.96673-1-hadess@hadess.net (mailing list archive)
State Accepted
Commit e515f4b6e25c971c47ab79e9cbdfa17119bbde23
Headers show
Series [BlueZ,1/2] hostname: Add '' around printed strings | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/checkpatch success Checkpatch PASS
tedd_an/gitlint success Gitlint PASS
tedd_an/setupell success Setup ELL PASS
tedd_an/buildprep success Build Prep PASS
tedd_an/build success Build Configuration PASS
tedd_an/makecheck success Make Check PASS
tedd_an/makecheckvalgrind success Make Check PASS
tedd_an/makedistcheck success Make Distcheck PASS
tedd_an/build_extell success Build External ELL PASS
tedd_an/build_extell_make success Build Make with External ELL PASS
tedd_an/incremental_build success Pass
tedd_an/scan_build success Pass

Commit Message

Bastien Nocera Nov. 9, 2022, 3:17 p.m. UTC 
Otherwise we can't see whether the string is nul, or empty.
---
 plugins/hostname.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

bluez.test.bot@gmail.com Nov. 9, 2022, 4:11 p.m. UTC | #1 
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=693693

---Test result---

Test Summary:
CheckPatch                    FAIL      2.47 seconds
GitLint                       PASS      1.55 seconds
Prep - Setup ELL              PASS      27.77 seconds
Build - Prep                  PASS      0.72 seconds
Build - Configure             PASS      8.90 seconds
Build - Make                  PASS      897.96 seconds
Make Check                    PASS      11.55 seconds
Make Check w/Valgrind         PASS      297.53 seconds
Make Distcheck                PASS      245.83 seconds
Build w/ext ELL - Configure   PASS      8.99 seconds
Build w/ext ELL - Make        PASS      87.66 seconds
Incremental Build w/ patches  PASS      205.65 seconds
Scan Build                    PASS      519.08 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
Output:
[BlueZ,2/2] hostname: Fallback to transient hostname
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#57: 
https://www.freedesktop.org/software/systemd/man/org.freedesktop.hostname1.html

ERROR:INITIALISED_STATIC: do not initialise statics to NULL
#80: FILE: plugins/hostname.c:48:
+static char *pretty_hostname    = NULL;

ERROR:INITIALISED_STATIC: do not initialise statics to NULL
#81: FILE: plugins/hostname.c:49:
+static char *static_hostname    = NULL;

ERROR:INITIALISED_STATIC: do not initialise statics to NULL
#82: FILE: plugins/hostname.c:50:
+static char *transient_hostname = NULL;

ERROR:INITIALISED_STATIC: do not initialise statics to 0
#83: FILE: plugins/hostname.c:51:
+static guint hostname_id = 0;

WARNING:LONG_LINE: line length of 84 exceeds 80 columns
#147: FILE: plugins/hostname.c:327:
+	hostname_io = g_io_channel_new_file("/proc/sys/kernel/hostname", "r", NULL);

WARNING:LONG_LINE: line length of 87 exceeds 80 columns
#149: FILE: plugins/hostname.c:329:
+		hostname_id = g_io_add_watch(hostname_io, G_IO_ERR, hostname_cb, NULL);

/github/workspace/src/13037643.patch total: 4 errors, 3 warnings, 100 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/13037643.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.




---
Regards,
Linux Bluetooth
patchwork-bot+bluetooth@kernel.org Nov. 16, 2022, 10 p.m. UTC | #2 
Hello:

This series was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Wed,  9 Nov 2022 16:17:55 +0100 you wrote:
> Otherwise we can't see whether the string is nul, or empty.
> ---
>  plugins/hostname.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Here is the summary with links:
  - [BlueZ,1/2] hostname: Add '' around printed strings
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=e515f4b6e25c
  - [BlueZ,2/2] hostname: Fallback to transient hostname
    (no matching commit)

You are awesome, thank you!
diff mbox series

Patch

diff --git a/plugins/hostname.c b/plugins/hostname.c
index 1a9513adb..14b6450b5 100644
--- a/plugins/hostname.c
+++ b/plugins/hostname.c
@@ -128,7 +128,7 @@  static void property_changed(GDBusProxy *proxy, const char *name,
 
 			dbus_message_iter_get_basic(iter, &str);
 
-			DBG("pretty hostname: %s", str);
+			DBG("pretty hostname: '%s'", str);
 
 			g_free(pretty_hostname);
 			pretty_hostname = g_strdup(str);
@@ -146,7 +146,7 @@  static void property_changed(GDBusProxy *proxy, const char *name,
 
 			dbus_message_iter_get_basic(iter, &str);
 
-			DBG("static hostname: %s", str);
+			DBG("static hostname: '%s'", str);
 
 			g_free(static_hostname);
 			static_hostname = g_strdup(str);
@@ -165,7 +165,7 @@  static void property_changed(GDBusProxy *proxy, const char *name,
 
 			dbus_message_iter_get_basic(iter, &str);
 
-			DBG("chassis: %s", str);
+			DBG("chassis: '%s'", str);
 
 			for (i = 0; chassis_table[i].chassis; i++) {
 				if (strcmp(chassis_table[i].chassis, str))