| Message ID | 20230514074731.70614-2-rudi@heitbaum.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Bluetooth: btrtl: Add support for RTL8822BS | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | success | Gitlint PASS |
| tedd_an/SubjectPrefix | fail | "Bluetooth: " prefix is not specified in the subject |
| tedd_an/BuildKernel | success | BuildKernel PASS |
| tedd_an/CheckAllWarning | warning | CheckSparse WARNING drivers/bluetooth/btrtl.c: In function ‘btrtl_set_quirks’:drivers/bluetooth/btrtl.c:1194:3: warning: this statement may fall through [-Wimplicit-fallthrough=] 1194 | set_bit(HCI_QUIRK_BROKEN_LOCAL_EXT_FEATURES_PAGE_2, &hdev->quirks); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~drivers/bluetooth/btrtl.c:1195:2: note: here 1195 | default: | ^~~~~~~ |
| tedd_an/CheckSparse | warning | CheckSparse WARNING drivers/bluetooth/btrtl.c: In function ‘btrtl_set_quirks’:drivers/bluetooth/btrtl.c:1194:3: warning: this statement may fall through [-Wimplicit-fallthrough=]drivers/bluetooth/btrtl.c:1195:2: note: here |
| tedd_an/CheckSmatch | warning | CheckSparse WARNING drivers/bluetooth/btrtl.c: In function ‘btrtl_set_quirks’:drivers/bluetooth/btrtl.c:1194:3: warning: this statement may fall through [-Wimplicit-fallthrough=]drivers/bluetooth/btrtl.c:1195:2: note: here |
| tedd_an/BuildKernel32 | success | BuildKernel32 PASS |
| tedd_an/TestRunnerSetup | success | TestRunnerSetup PASS |
| tedd_an/TestRunner_l2cap-tester | success | TestRunner PASS |
| tedd_an/TestRunner_iso-tester | success | TestRunner PASS |
| tedd_an/TestRunner_bnep-tester | success | TestRunner PASS |
| tedd_an/TestRunner_mgmt-tester | success | TestRunner PASS |
| tedd_an/TestRunner_rfcomm-tester | success | TestRunner PASS |
| tedd_an/TestRunner_sco-tester | success | TestRunner PASS |
| tedd_an/TestRunner_ioctl-tester | success | TestRunner PASS |
| tedd_an/TestRunner_mesh-tester | success | TestRunner PASS |
| tedd_an/TestRunner_smp-tester | success | TestRunner PASS |
| tedd_an/TestRunner_userchan-tester | success | TestRunner PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=747318 ---Test result--- Test Summary: CheckPatch PASS 2.04 seconds GitLint PASS 0.89 seconds SubjectPrefix FAIL 0.60 seconds BuildKernel PASS 32.50 seconds CheckAllWarning WARNING 35.62 seconds CheckSparse WARNING 40.87 seconds CheckSmatch WARNING 110.27 seconds BuildKernel32 PASS 31.83 seconds TestRunnerSetup PASS 457.47 seconds TestRunner_l2cap-tester PASS 17.22 seconds TestRunner_iso-tester PASS 21.84 seconds TestRunner_bnep-tester PASS 5.67 seconds TestRunner_mgmt-tester PASS 117.57 seconds TestRunner_rfcomm-tester PASS 9.11 seconds TestRunner_sco-tester PASS 8.41 seconds TestRunner_ioctl-tester PASS 9.88 seconds TestRunner_mesh-tester PASS 7.20 seconds TestRunner_smp-tester PASS 8.31 seconds TestRunner_userchan-tester PASS 6.02 seconds IncrementalBuild PASS 39.59 seconds Details ############################## Test: SubjectPrefix - FAIL Desc: Check subject contains "Bluetooth" prefix Output: "Bluetooth: " prefix is not specified in the subject "Bluetooth: " prefix is not specified in the subject ############################## Test: CheckAllWarning - WARNING Desc: Run linux kernel with all warning enabled Output: drivers/bluetooth/btrtl.c: In function ‘btrtl_set_quirks’:drivers/bluetooth/btrtl.c:1194:3: warning: this statement may fall through [-Wimplicit-fallthrough=] 1194 | set_bit(HCI_QUIRK_BROKEN_LOCAL_EXT_FEATURES_PAGE_2, &hdev->quirks); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~drivers/bluetooth/btrtl.c:1195:2: note: here 1195 | default: | ^~~~~~~ ############################## Test: CheckSparse - WARNING Desc: Run sparse tool with linux kernel Output: drivers/bluetooth/btrtl.c: In function ‘btrtl_set_quirks’:drivers/bluetooth/btrtl.c:1194:3: warning: this statement may fall through [-Wimplicit-fallthrough=]drivers/bluetooth/btrtl.c:1195:2: note: here ############################## Test: CheckSmatch - WARNING Desc: Run smatch tool with source Output: drivers/bluetooth/btrtl.c: In function ‘btrtl_set_quirks’:drivers/bluetooth/btrtl.c:1194:3: warning: this statement may fall through [-Wimplicit-fallthrough=]drivers/bluetooth/btrtl.c:1195:2: note: here --- Regards, Linux Bluetooth
On Sun, 14 May 2023 07:47:29 +0000, Rudi Heitbaum wrote: > Add compatible string for RTL8822BS for existing Realtek Bluetooth > driver. > > Signed-off-by: Rudi Heitbaum <rudi@heitbaum.com> > --- > .../devicetree/bindings/net/realtek-bluetooth.yaml | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml: properties:compatible:oneOf:1:items: 'oneOf' conditional failed, one must be fixed: [{'enum': ['realtek,rtl8821cs-bt']}, {'const': ['realtek,rtl8822bs-bt', 'realtek,rtl8822cs-bt']}] is not of type 'object' ['realtek,rtl8822bs-bt', 'realtek,rtl8822cs-bt'] is not of type 'integer', 'string' from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml: properties:compatible:oneOf:1:items: 'oneOf' conditional failed, one must be fixed: [{'enum': ['realtek,rtl8821cs-bt']}, {'const': ['realtek,rtl8822bs-bt', 'realtek,rtl8822cs-bt']}] is not of type 'object' ['realtek,rtl8822bs-bt', 'realtek,rtl8822cs-bt'] is not of type 'string' from schema $id: http://devicetree.org/meta-schemas/string-array.yaml# Traceback (most recent call last): File "/usr/local/bin/dt-validate", line 167, in <module> sg.check_trees(filename, testtree) ... File "/usr/lib/python3.10/sre_parse.py", line 599, in _parse raise source.error(msg, len(this) + 1 + len(that)) re.error: bad character range s-b at position 18 Note: You even broke the dtschema :) See https://patchwork.ozlabs.org/patch/1781021 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On 14/05/2023 09:47, Rudi Heitbaum wrote: > Add compatible string for RTL8822BS for existing Realtek Bluetooth > driver. > > Signed-off-by: Rudi Heitbaum <rudi@heitbaum.com> > --- > .../devicetree/bindings/net/realtek-bluetooth.yaml | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml b/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml > index 8cc2b9924680..d2103931fc1c 100644 > --- a/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml > +++ b/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml > @@ -4,16 +4,16 @@ > $id: http://devicetree.org/schemas/net/realtek-bluetooth.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: RTL8723BS/RTL8723CS/RTL8821CS/RTL8822CS Bluetooth > +title: RTL8723BS/RTL8723CS/RTL8821CS/RTL8822BS/RTL8822CS Bluetooth > > maintainers: > - Vasily Khoruzhick <anarsoul@gmail.com> > - Alistair Francis <alistair@alistair23.me> > > description: > - RTL8723CS/RTL8723CS/RTL8821CS/RTL8822CS is a WiFi + BT chip. WiFi part > - is connected over SDIO, while BT is connected over serial. It speaks > - H5 protocol with few extra commands to upload firmware and change > + RTL8723CS/RTL8723CS/RTL8821CS/RTL8822BS/RTL8822CS is a WiFi + BT chip. > + WiFi part is connected over SDIO, while BT is connected over serial. It > + speaks H5 protocol with few extra commands to upload firmware and change > module speed. > > properties: > @@ -23,11 +23,14 @@ properties: > - realtek,rtl8723bs-bt > - realtek,rtl8723cs-bt > - realtek,rtl8723ds-bt > + - realtek,rtl8822bs-bt > - realtek,rtl8822cs-bt > - items: > - enum: > - realtek,rtl8821cs-bt > - - const: realtek,rtl8822cs-bt > + - const: > + - realtek,rtl8822bs-bt > + - realtek,rtl8822cs-bt This won't work, wasn't tested and does not actually make sense. Depending on your goal this could be added to the enum above... or anything else. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml b/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml index 8cc2b9924680..d2103931fc1c 100644 --- a/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml +++ b/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml @@ -4,16 +4,16 @@ $id: http://devicetree.org/schemas/net/realtek-bluetooth.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: RTL8723BS/RTL8723CS/RTL8821CS/RTL8822CS Bluetooth +title: RTL8723BS/RTL8723CS/RTL8821CS/RTL8822BS/RTL8822CS Bluetooth maintainers: - Vasily Khoruzhick <anarsoul@gmail.com> - Alistair Francis <alistair@alistair23.me> description: - RTL8723CS/RTL8723CS/RTL8821CS/RTL8822CS is a WiFi + BT chip. WiFi part - is connected over SDIO, while BT is connected over serial. It speaks - H5 protocol with few extra commands to upload firmware and change + RTL8723CS/RTL8723CS/RTL8821CS/RTL8822BS/RTL8822CS is a WiFi + BT chip. + WiFi part is connected over SDIO, while BT is connected over serial. It + speaks H5 protocol with few extra commands to upload firmware and change module speed. properties: @@ -23,11 +23,14 @@ properties: - realtek,rtl8723bs-bt - realtek,rtl8723cs-bt - realtek,rtl8723ds-bt + - realtek,rtl8822bs-bt - realtek,rtl8822cs-bt - items: - enum: - realtek,rtl8821cs-bt - - const: realtek,rtl8822cs-bt + - const: + - realtek,rtl8822bs-bt + - realtek,rtl8822cs-bt device-wake-gpios: maxItems: 1
Add compatible string for RTL8822BS for existing Realtek Bluetooth driver. Signed-off-by: Rudi Heitbaum <rudi@heitbaum.com> --- .../devicetree/bindings/net/realtek-bluetooth.yaml | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-)