Message ID | 20230518050826.27316-1-quic_tjiang@quicinc.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | [v1] dt-bindings: net: Add QCA2066 Bluetooth | expand |
Context | Check | Description |
---|---|---|
tedd_an/pre-ci_am | success | Success |
tedd_an/CheckPatch | success | CheckPatch PASS |
tedd_an/GitLint | success | Gitlint PASS |
tedd_an/SubjectPrefix | fail | "Bluetooth: " prefix is not specified in the subject |
tedd_an/BuildKernel | success | BuildKernel PASS |
tedd_an/CheckAllWarning | success | CheckAllWarning PASS |
tedd_an/CheckSparse | success | CheckSparse PASS |
tedd_an/CheckSmatch | success | CheckSparse PASS |
tedd_an/BuildKernel32 | success | BuildKernel32 PASS |
tedd_an/TestRunnerSetup | success | TestRunnerSetup PASS |
tedd_an/TestRunner_l2cap-tester | success | TestRunner PASS |
tedd_an/TestRunner_iso-tester | success | TestRunner PASS |
tedd_an/TestRunner_bnep-tester | success | TestRunner PASS |
tedd_an/TestRunner_mgmt-tester | success | TestRunner PASS |
tedd_an/TestRunner_rfcomm-tester | success | TestRunner PASS |
tedd_an/TestRunner_sco-tester | success | TestRunner PASS |
tedd_an/TestRunner_ioctl-tester | success | TestRunner PASS |
tedd_an/TestRunner_mesh-tester | success | TestRunner PASS |
tedd_an/TestRunner_smp-tester | success | TestRunner PASS |
tedd_an/TestRunner_userchan-tester | success | TestRunner PASS |
tedd_an/IncrementalBuild | success | Incremental Build PASS |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=748749 ---Test result--- Test Summary: CheckPatch PASS 0.66 seconds GitLint PASS 0.35 seconds SubjectPrefix FAIL 0.38 seconds BuildKernel PASS 31.50 seconds CheckAllWarning PASS 34.17 seconds CheckSparse PASS 38.91 seconds CheckSmatch PASS 107.24 seconds BuildKernel32 PASS 30.27 seconds TestRunnerSetup PASS 436.00 seconds TestRunner_l2cap-tester PASS 16.87 seconds TestRunner_iso-tester PASS 21.34 seconds TestRunner_bnep-tester PASS 5.62 seconds TestRunner_mgmt-tester PASS 114.77 seconds TestRunner_rfcomm-tester PASS 9.18 seconds TestRunner_sco-tester PASS 8.23 seconds TestRunner_ioctl-tester PASS 9.65 seconds TestRunner_mesh-tester PASS 7.07 seconds TestRunner_smp-tester PASS 8.18 seconds TestRunner_userchan-tester PASS 5.91 seconds IncrementalBuild PASS 28.64 seconds Details ############################## Test: SubjectPrefix - FAIL Desc: Check subject contains "Bluetooth" prefix Output: "Bluetooth: " prefix is not specified in the subject --- Regards, Linux Bluetooth
On 18/05/2023 07:08, Tim Jiang wrote: > Add bindings for the QCA2066 chipset. > > Signed-off-by: Tim Jiang <quic_tjiang@quicinc.com> Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. You missed at least DT list (maybe more), so this won't be tested. Please resend and include all necessary entries. Beside that patch looks incomplete. Best regards, Krzysztof
Krzysztof: Thanks for your reply, Inline comments Regards. Tim -----Original Message----- From: Krzysztof Kozlowski <krzk@kernel.org> Sent: Thursday, May 18, 2023 4:21 PM To: Tim Jiang (QUIC) <quic_tjiang@quicinc.com>; marcel@holtmann.org Cc: linux-kernel@vger.kernel.org; linux-bluetooth@vger.kernel.org; linux-arm-msm@vger.kernel.org; Balakrishna Godavarthi (QUIC) <quic_bgodavar@quicinc.com>; Hemant Gupta (QUIC) <quic_hemantg@quicinc.com>; mka@chromium.org Subject: Re: [PATCH v1] dt-bindings: net: Add QCA2066 Bluetooth On 18/05/2023 07:08, Tim Jiang wrote: > Add bindings for the QCA2066 chipset. > > Signed-off-by: Tim Jiang <quic_tjiang@quicinc.com> Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. [Tim] ok , I will update my linux kernel You missed at least DT list (maybe more), so this won't be tested. [Tim] do you mean email CC list ? Please resend and include all necessary entries. Beside that patch looks incomplete. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml index 68f78b90d23a..f51b0e8ad086 100644 --- a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml +++ b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml @@ -16,6 +16,7 @@ description: properties: compatible: enum: + - qcom,qca2066-bt - qcom,qca6174-bt - qcom,qca9377-bt - qcom,wcn3990-bt
Add bindings for the QCA2066 chipset. Signed-off-by: Tim Jiang <quic_tjiang@quicinc.com> --- .../devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml | 1 + 1 file changed, 1 insertion(+)