Bluetooth: btintel: fix dereference after free in btintel_ppag_callback()

Commit Message

Konstantin Meskhidze (A) Aug. 17, 2023, 9:35 a.m. UTC

'buffer.pointer' is freed and then dereferenced via 'p' pointer at
'bt_dev_warn' function call.

Fixes: c585a92b2f9c ("Bluetooth: btintel: Set Per Platform Antenna Gain(PPAG)")
Co-developed-by: Ivanov Mikhail <[e-mail]>
Signed-off-by: Konstantin Meskhidze <[e-mail]>
---
 drivers/bluetooth/btintel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

[e-mail] Aug. 17, 2023, 10:45 a.m. UTC | #1

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=776931

---Test result---

Test Summary:
CheckPatch                    FAIL      0.99 seconds
GitLint                       PASS      0.33 seconds
SubjectPrefix                 PASS      0.10 seconds
BuildKernel                   PASS      45.39 seconds
CheckAllWarning               PASS      51.63 seconds
CheckSparse                   PASS      57.38 seconds
CheckSmatch                   PASS      154.80 seconds
BuildKernel32                 PASS      44.78 seconds
TestRunnerSetup               PASS      683.76 seconds
TestRunner_l2cap-tester       PASS      39.79 seconds
TestRunner_iso-tester         PASS      112.43 seconds
TestRunner_bnep-tester        PASS      16.63 seconds
TestRunner_mgmt-tester        PASS      282.19 seconds
TestRunner_rfcomm-tester      PASS      25.00 seconds
TestRunner_sco-tester         PASS      27.23 seconds
TestRunner_ioctl-tester       PASS      27.91 seconds
TestRunner_mesh-tester        PASS      21.51 seconds
TestRunner_smp-tester         PASS      23.08 seconds
TestRunner_userchan-tester    PASS      17.92 seconds
IncrementalBuild              PASS      42.96 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
Bluetooth: btintel: fix dereference after free in btintel_ppag_callback()
WARNING: Co-developed-by and Signed-off-by: name/email do not match
#58: 
Co-developed-by: Ivanov Mikhail <[e-mail]>
Signed-off-by: Konstantin Meskhidze <[e-mail]>

total: 0 errors, 1 warnings, 12 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/src/13356210.patch has style problems, please review.

NOTE: Ignored message types: UNKNOWN_COMMIT_ID

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.




---
Regards,
Linux Bluetooth

Patch

diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
index d9349ba48..4ac1eba9c 100644
--- a/drivers/bluetooth/btintel.c
+++ b/drivers/bluetooth/btintel.c
@@ -1340,11 +1340,11 @@  static acpi_status btintel_ppag_callback(acpi_handle handle, u32 lvl, void *data
 	p = buffer.pointer;
 	ppag = (struct btintel_ppag *)data;
 
 	if (p->type != ACPI_TYPE_PACKAGE || p->package.count != 2) {
-		kfree(buffer.pointer);
 		bt_dev_warn(hdev, "PPAG-BT: Invalid object type: %d or package count: %d",
 			    p->type, p->package.count);
+		kfree(buffer.pointer);
 		ppag->status = AE_ERROR;
 		return AE_ERROR;
 	}