diff mbox series

[v2,1/1] Bluetooth: ISO: Set CIS bit only for devices with CIS support

Message ID 20230908100618.63986-2-vlad.pruteanu@nxp.com (mailing list archive)
State Superseded
Headers show
Series Bluetooth: ISO: Set CIS bit only for devices with CIS support | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/CheckPatch success CheckPatch PASS
tedd_an/GitLint success Gitlint PASS
tedd_an/SubjectPrefix success Gitlint PASS
tedd_an/BuildKernel success BuildKernel PASS
tedd_an/CheckAllWarning success CheckAllWarning PASS
tedd_an/CheckSparse success CheckSparse PASS
tedd_an/CheckSmatch success CheckSparse PASS
tedd_an/BuildKernel32 success BuildKernel32 PASS
tedd_an/TestRunnerSetup success TestRunnerSetup PASS
tedd_an/TestRunner_l2cap-tester success TestRunner PASS
tedd_an/TestRunner_iso-tester success TestRunner PASS
tedd_an/TestRunner_bnep-tester success TestRunner PASS
tedd_an/TestRunner_mgmt-tester success TestRunner PASS
tedd_an/TestRunner_rfcomm-tester success TestRunner PASS
tedd_an/TestRunner_sco-tester success TestRunner PASS
tedd_an/TestRunner_ioctl-tester success TestRunner PASS
tedd_an/TestRunner_mesh-tester success TestRunner PASS
tedd_an/TestRunner_smp-tester success TestRunner PASS
tedd_an/TestRunner_userchan-tester success TestRunner PASS
tedd_an/IncrementalBuild success Incremental Build PASS

Commit Message

Vlad Pruteanu Sept. 8, 2023, 10:06 a.m. UTC
Currently the CIS bit that can be set by the host is set for any device
that has CIS or BIS support. In reality, devices that support BIS may not
allow that bit to be set and so, the HCI bring up fails for them.

This commit fixes this by only setting the bit for CIS capable devices.

Signed-off-by: Vlad Pruteanu <vlad.pruteanu@nxp.com>
---
 net/bluetooth/hci_sync.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

bluez.test.bot@gmail.com Sept. 8, 2023, 10:38 a.m. UTC | #1
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=782474

---Test result---

Test Summary:
CheckPatch                    PASS      0.66 seconds
GitLint                       PASS      0.40 seconds
SubjectPrefix                 PASS      0.11 seconds
BuildKernel                   PASS      34.16 seconds
CheckAllWarning               PASS      38.32 seconds
CheckSparse                   PASS      42.85 seconds
CheckSmatch                   PASS      115.77 seconds
BuildKernel32                 PASS      33.23 seconds
TestRunnerSetup               PASS      506.87 seconds
TestRunner_l2cap-tester       PASS      29.39 seconds
TestRunner_iso-tester         PASS      56.22 seconds
TestRunner_bnep-tester        PASS      11.61 seconds
TestRunner_mgmt-tester        PASS      228.81 seconds
TestRunner_rfcomm-tester      PASS      16.97 seconds
TestRunner_sco-tester         PASS      20.26 seconds
TestRunner_ioctl-tester       PASS      19.18 seconds
TestRunner_mesh-tester        PASS      14.31 seconds
TestRunner_smp-tester         PASS      15.21 seconds
TestRunner_userchan-tester    PASS      11.92 seconds
IncrementalBuild              PASS      31.64 seconds



---
Regards,
Linux Bluetooth
diff mbox series

Patch

diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c
index ec4dfc4c5749..f09c5812c247 100644
--- a/net/bluetooth/hci_sync.c
+++ b/net/bluetooth/hci_sync.c
@@ -4264,7 +4264,7 @@  static int hci_le_set_host_feature_sync(struct hci_dev *hdev)
 {
 	struct hci_cp_le_set_host_feature cp;
 
-	if (!iso_capable(hdev))
+	if (!cis_capable(hdev))
 		return 0;
 
 	memset(&cp, 0, sizeof(cp));