[v3,1/1] Bluetooth: ISO: Set CIS bit only for devices with CIS support

Commit Message

Vlad Pruteanu Sept. 12, 2023, 6:17 a.m. UTC

As mentioned in the Bluetooth Specification the full name of this bit is
"Connected Isochronous Stream (Host Support)", thus it should be set only
for CIS capable devices. Currently, it is set for any device that has CIS
or BIS support. In reality, devices that support BIS may not allow that 
bit to be set and so, the HCI bring up fails for them.

This commit fixes this by only setting the bit for CIS capable devices.

Signed-off-by: Vlad Pruteanu <[e-mail]>
---
 net/bluetooth/hci_sync.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

[e-mail] Sept. 12, 2023, 7:02 a.m. UTC | #1

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=783271

---Test result---

Test Summary:
CheckPatch                    PASS      0.73 seconds
GitLint                       FAIL      0.58 seconds
SubjectPrefix                 PASS      1.10 seconds
BuildKernel                   PASS      33.73 seconds
CheckAllWarning               PASS      36.94 seconds
CheckSparse                   PASS      41.98 seconds
CheckSmatch                   PASS      114.21 seconds
BuildKernel32                 PASS      32.44 seconds
TestRunnerSetup               PASS      494.07 seconds
TestRunner_l2cap-tester       PASS      28.52 seconds
TestRunner_iso-tester         PASS      51.49 seconds
TestRunner_bnep-tester        PASS      11.20 seconds
TestRunner_mgmt-tester        PASS      224.21 seconds
TestRunner_rfcomm-tester      PASS      17.49 seconds
TestRunner_sco-tester         PASS      20.52 seconds
TestRunner_ioctl-tester       PASS      19.08 seconds
TestRunner_mesh-tester        PASS      14.06 seconds
TestRunner_smp-tester         PASS      15.03 seconds
TestRunner_userchan-tester    PASS      11.81 seconds
IncrementalBuild              PASS      30.97 seconds

Details
##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
[v3,1/1] Bluetooth: ISO: Set CIS bit only for devices with CIS support

WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
6: B2 Line has trailing whitespace: "or BIS support. In reality, devices that support BIS may not allow that "


---
Regards,
Linux Bluetooth

Patch

diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c
index ec4dfc4c5749..1be5763c261c 100644
--- a/net/bluetooth/hci_sync.c
+++ b/net/bluetooth/hci_sync.c
@@ -4264,12 +4264,12 @@  static int hci_le_set_host_feature_sync(struct hci_dev *hdev)
 {
 	struct hci_cp_le_set_host_feature cp;
 
-	if (!iso_capable(hdev))
+	if (!cis_capable(hdev))
 		return 0;
 
 	memset(&cp, 0, sizeof(cp));
 
-	/* Isochronous Channels (Host Support) */
+	/* Connected Isochronous Channels (Host Support) */
 	cp.bit_number = 32;
 	cp.bit_value = 1;