[v4,1/1] Bluetooth: ISO: Set CIS bit only for devices with CIS support

Commit Message

Vlad Pruteanu Sept. 12, 2023, 6:33 a.m. UTC

Currently the CIS bit that can be set by the host is set for any device
that has CIS or BIS support. In reality, devices that support BIS may not
allow that bit to be set and so, the HCI bring up fails for them.

This commit fixes this by only setting the bit for CIS capable devices.

Signed-off-by: Vlad Pruteanu <[e-mail]>
---
 net/bluetooth/hci_sync.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

[e-mail] Sept. 12, 2023, 7:36 a.m. UTC | #1

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=783273

---Test result---

Test Summary:
CheckPatch                    PASS      0.60 seconds
GitLint                       PASS      0.62 seconds
SubjectPrefix                 PASS      0.29 seconds
BuildKernel                   PASS      33.18 seconds
CheckAllWarning               PASS      36.60 seconds
CheckSparse                   PASS      41.50 seconds
CheckSmatch                   PASS      113.13 seconds
BuildKernel32                 PASS      31.92 seconds
TestRunnerSetup               PASS      489.78 seconds
TestRunner_l2cap-tester       PASS      28.39 seconds
TestRunner_iso-tester         PASS      50.72 seconds
TestRunner_bnep-tester        PASS      11.17 seconds
TestRunner_mgmt-tester        PASS      226.93 seconds
TestRunner_rfcomm-tester      PASS      16.69 seconds
TestRunner_sco-tester         PASS      20.01 seconds
TestRunner_ioctl-tester       PASS      18.94 seconds
TestRunner_mesh-tester        PASS      14.00 seconds
TestRunner_smp-tester         PASS      14.85 seconds
TestRunner_userchan-tester    PASS      11.68 seconds
IncrementalBuild              PASS      30.04 seconds



---
Regards,
Linux Bluetooth

Patch

diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c
index ec4dfc4c5749..1be5763c261c 100644
--- a/net/bluetooth/hci_sync.c
+++ b/net/bluetooth/hci_sync.c
@@ -4264,12 +4264,12 @@  static int hci_le_set_host_feature_sync(struct hci_dev *hdev)
 {
 	struct hci_cp_le_set_host_feature cp;
 
-	if (!iso_capable(hdev))
+	if (!cis_capable(hdev))
 		return 0;
 
 	memset(&cp, 0, sizeof(cp));
 
-	/* Isochronous Channels (Host Support) */
+	/* Connected Isochronous Channels (Host Support) */
 	cp.bit_number = 32;
 	cp.bit_value = 1;