| Message ID | 20230921234738.929423-1-luiz.dentz@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [BlueZ,1/5] media-api: Update to reflect the last code changes | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | success | Gitlint PASS |
| tedd_an/BuildEll | success | Build ELL PASS |
| tedd_an/BluezMake | success | Bluez Make PASS |
| tedd_an/MakeCheck | success | Bluez Make Check PASS |
| tedd_an/MakeDistcheck | success | Make Distcheck PASS |
| tedd_an/CheckValgrind | success | Check Valgrind PASS |
| tedd_an/CheckSmatch | success | CheckSparse PASS |
| tedd_an/bluezmakeextell | success | Make External ELL PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
| tedd_an/ScanBuild | success | Scan Build PASS |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=786455 ---Test result--- Test Summary: CheckPatch PASS 2.52 seconds GitLint FAIL 1.58 seconds BuildEll PASS 34.31 seconds BluezMake PASS 1192.51 seconds MakeCheck PASS 13.44 seconds MakeDistcheck PASS 195.33 seconds CheckValgrind PASS 314.03 seconds CheckSmatch PASS 437.84 seconds bluezmakeextell PASS 131.38 seconds IncrementalBuild PASS 5145.48 seconds ScanBuild PASS 1374.82 seconds Details ############################## Test: GitLint - FAIL Desc: Run gitlint Output: [BlueZ,3/5] client: Make transport.show to print QoS property WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search 10: B3 Line contains hard tab characters (\t): " UUID: 00002bcb-0000-1000-8000-00805f9b34fb" 11: B3 Line contains hard tab characters (\t): " Codec: 0x06 (6)" 12: B3 Line contains hard tab characters (\t): " Configuration:" 14: B3 Line contains hard tab characters (\t): " Device: /org/bluez/hci0/dev_00_AA_01_01_00_03" 15: B3 Line contains hard tab characters (\t): " State: idle" 16: B3 Line contains hard tab characters (\t): " Endpoint: /org/bluez/hci0/dev_00_AA_01_01_00_03/pac_sink0" 17: B3 Line contains hard tab characters (\t): " QoS Key: CIG" 18: B3 Line contains hard tab characters (\t): " QoS Value: 0x00 (0)" 19: B3 Line contains hard tab characters (\t): " QoS Key: CIS" 20: B3 Line contains hard tab characters (\t): " QoS Value: 0x00 (0)" 21: B3 Line contains hard tab characters (\t): " QoS Key: Framing" 22: B3 Line contains hard tab characters (\t): " QoS Value: 0x00 (0)" 23: B3 Line contains hard tab characters (\t): " QoS Key: PresentationDelay" 24: B3 Line contains hard tab characters (\t): " QoS Value: 0x00009c40 (40000)" 25: B3 Line contains hard tab characters (\t): " QoS Key: Interval" 26: B3 Line contains hard tab characters (\t): " QoS Value: 0x00002710 (10000)" 27: B3 Line contains hard tab characters (\t): " QoS Key: Latency" 28: B3 Line contains hard tab characters (\t): " QoS Value: 0x000a (10)" 29: B3 Line contains hard tab characters (\t): " QoS Key: SDU" 30: B3 Line contains hard tab characters (\t): " QoS Value: 0x0028 (40)" 31: B3 Line contains hard tab characters (\t): " QoS Key: PHY" 32: B3 Line contains hard tab characters (\t): " QoS Value: 0x02 (2)" 33: B3 Line contains hard tab characters (\t): " QoS Key: Retransmissions" 34: B3 Line contains hard tab characters (\t): " QoS Value: 0x02 (2)" 35: B3 Line contains hard tab characters (\t): " Location: 0x00000003 (3)" 36: B3 Line contains hard tab characters (\t): " Links: /org/bluez/hci0/dev_00_AA_01_01_00_03/pac_source0/fd0" --- Regards, Linux Bluetooth
Hi, On Thu, Sep 21, 2023 at 8:23 PM <bluez.test.bot@gmail.com> wrote: > > This is automated email and please do not reply to this email! > > Dear submitter, > > Thank you for submitting the patches to the linux bluetooth mailing list. > This is a CI test results with your patch series: > PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=786455 Have a look if I capture everything correctly, Ive made sure the bluetoothctl works with QoS being a single property but we still have to do the changes at upper layers. @Pauli Virtanen You can use bluetoothctl as an example how to encode the QoS property, note that there are multiple containers involved because the QoS dict becomes the variant portion of the outer dictionary but you will notice if the daemon is not able to parse it. I could consider supporting the old format though if you think we should maintain backwards compatibility. > ---Test result--- > > Test Summary: > CheckPatch PASS 2.52 seconds > GitLint FAIL 1.58 seconds > BuildEll PASS 34.31 seconds > BluezMake PASS 1192.51 seconds > MakeCheck PASS 13.44 seconds > MakeDistcheck PASS 195.33 seconds > CheckValgrind PASS 314.03 seconds > CheckSmatch PASS 437.84 seconds > bluezmakeextell PASS 131.38 seconds > IncrementalBuild PASS 5145.48 seconds > ScanBuild PASS 1374.82 seconds > > Details > ############################## > Test: GitLint - FAIL > Desc: Run gitlint > Output: > [BlueZ,3/5] client: Make transport.show to print QoS property > > WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search > 10: B3 Line contains hard tab characters (\t): " UUID: 00002bcb-0000-1000-8000-00805f9b34fb" > 11: B3 Line contains hard tab characters (\t): " Codec: 0x06 (6)" > 12: B3 Line contains hard tab characters (\t): " Configuration:" > 14: B3 Line contains hard tab characters (\t): " Device: /org/bluez/hci0/dev_00_AA_01_01_00_03" > 15: B3 Line contains hard tab characters (\t): " State: idle" > 16: B3 Line contains hard tab characters (\t): " Endpoint: /org/bluez/hci0/dev_00_AA_01_01_00_03/pac_sink0" > 17: B3 Line contains hard tab characters (\t): " QoS Key: CIG" > 18: B3 Line contains hard tab characters (\t): " QoS Value: 0x00 (0)" > 19: B3 Line contains hard tab characters (\t): " QoS Key: CIS" > 20: B3 Line contains hard tab characters (\t): " QoS Value: 0x00 (0)" > 21: B3 Line contains hard tab characters (\t): " QoS Key: Framing" > 22: B3 Line contains hard tab characters (\t): " QoS Value: 0x00 (0)" > 23: B3 Line contains hard tab characters (\t): " QoS Key: PresentationDelay" > 24: B3 Line contains hard tab characters (\t): " QoS Value: 0x00009c40 (40000)" > 25: B3 Line contains hard tab characters (\t): " QoS Key: Interval" > 26: B3 Line contains hard tab characters (\t): " QoS Value: 0x00002710 (10000)" > 27: B3 Line contains hard tab characters (\t): " QoS Key: Latency" > 28: B3 Line contains hard tab characters (\t): " QoS Value: 0x000a (10)" > 29: B3 Line contains hard tab characters (\t): " QoS Key: SDU" > 30: B3 Line contains hard tab characters (\t): " QoS Value: 0x0028 (40)" > 31: B3 Line contains hard tab characters (\t): " QoS Key: PHY" > 32: B3 Line contains hard tab characters (\t): " QoS Value: 0x02 (2)" > 33: B3 Line contains hard tab characters (\t): " QoS Key: Retransmissions" > 34: B3 Line contains hard tab characters (\t): " QoS Value: 0x02 (2)" > 35: B3 Line contains hard tab characters (\t): " Location: 0x00000003 (3)" > 36: B3 Line contains hard tab characters (\t): " Links: /org/bluez/hci0/dev_00_AA_01_01_00_03/pac_source0/fd0" > > > --- > Regards, > Linux Bluetooth >
diff --git a/doc/media-api.rst b/doc/media-api.rst index 34bf44e8ffbb..b37ae8f01630 100644 --- a/doc/media-api.rst +++ b/doc/media-api.rst @@ -710,28 +710,45 @@ void SetConfiguration(object transport, dict properties) properties: :array{byte} Capabilities [Mandatory]: + + See Endpoint.Capabilities property. + :array{byte} Metadata [ISO only]: - :byte CIG [ISO only]: - :byte CIS [ISO only]: - :uint32 Interval [ISO only]: - :bool Framing [ISO only]: - :string PHY [ISO only]: - :uint16 SDU [ISO only]: - :byte Retransmissions [ISO only]: - :uint16 Latency [ISO only]: - :uint32 Delay [ISO only]: - :uint8 TargetLatency [ISO Latency]: - :byte BIG [ISO broadcast only]: - :byte BIS [ISO broadcast only]: - :byte SyncInterval [ISO broadcast only]: - :byte Encryption [ISO broadcast only]: - :byte Options [ISO broadcast only]: - :uint16 Skip [ISO broadcast only]: - :uint16 SyncTimeout [ISO broadcast only]: - :byte SyncCteType [ISO broadcast only]: - :byte MSE [ISO broadcast only]: - :uint16 Timeout [ISO broadcast only]: - :array{byte} BroadcastCode [ISO broadcast only]: + + See Endpoint.Metadata property. + + :uint32 Location [ISO only]: + + See Endpoint.Location property. + + :byte Framing [ISO only]: + + See Endpoint.Framing property. + + :byte PHY [ISO only]: + + See Endpoint.PHY property. + + :uint16 MaximumLatency [ISO only]: + + See Endpoint.MaximumLatency property. + + :uint32 MinimumDelay [ISO only]: + + See Endpoint.MinimumDelay property. + + :uint32 MaximumDelay [ISO only]: + + See Endpoint.MaximumDelay property. + + :uint32 PreferredMinimumDelay [ISO only]: + + See Endpoint.PreferredMinimumDelay property. + + :uint32 PreferredMaximumDelay [ISO only]: + + See Endpoint.PreferredMaximumDelay property. + array{byte} SelectConfiguration(array{byte} capabilities) ````````````````````````````````````````````````````````` @@ -984,33 +1001,65 @@ dict QoS [readonly, optional, ISO only, experimental] Indicates configured CIG. + Possible values: + + :0x00 - 0xef: + + Valid ID range. + + :0xff: + + Auto allocate. + :byte CIS: Indicates configured CIS. - :uint32 Interval: + Possible values: - Indicates configured ISO interval. + :0x00 - 0xef: - :boolean Framing: + Valid ID range. + + :0xff: + + Auto allocate. + + :byte Framing: Indicates configured framing. - :byte PHY: + Possible values: - Indicates configured PHY. + :0x00: - :uint16 SDU: + Unframed. - Indicates configured SDU. + :0x01: - :byte Retransmissions: + Framed. - Indicates configured retransmissions. + :uint32 PresentationDelay: - :uint16 Latency: + Indicates configured transport presentation delay (us). - Indicates configured transport latency. + :byte TargetLatency: + + Indicates the requested target latency. + + Possible values: + + :0x01: + + Low Latency. + + :0x02: + + Balanced Latency/Reliability. + + :0x03: + + High Reliability. Possible values for Broadcast: @@ -1022,26 +1071,74 @@ dict QoS [readonly, optional, ISO only, experimental] Indicates configured BIS. - :uint32 SyncFactor: + :byte SyncFactor: - Indicates configured sync factor. + Indicates configured broadcast sync factor. - :uint32 Interval: + :byte Packing: - Indicates configured ISO interval. + Indicates configured packing. - :byte PHY: + :byte Framing: - Indicates configured PHY. + Indicates configured framing. - :uint16 SDU: + :byte Options: - Indicates configured maximum SDU. + Indicates configured broadcast options. + + :uint16 Skip: + + Indicates configured broadcast skip. :byte SyncTimeout: Indicates configured broadcast sync timeout. + :byte SyncType: + + Indicates configured broadcast sync CTE type. + + :byte MSE: + + Indicates configured broadcast MSE. + + :uint16 Timeout: + + Indicates configured broadcast timeout. + + Possible values for both Unicast and Broadcast: + + :uint32 Interval: + + Indicates configured ISO interval (us). + :uint16 Latency: - Indicates configured transport latency. + Indicates configured transport latency (ms). + + :uint16 SDU: + + Indicates configured maximum SDU. + + :byte PHY: + + Indicates configured PHY. + + Possible values: + + :bit 0: + + LE 1M + + :bit 1: + + LE 2M + + :bit 2: + + LE Coded + + :byte Retransmissions: + + Indicates configured retransmissions.
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> This reflect the last code changes adding the missing Broadcast properties. --- doc/media-api.rst | 179 +++++++++++++++++++++++++++++++++++----------- 1 file changed, 138 insertions(+), 41 deletions(-)