diff mbox series

[v4,03/12] client: Make transport.show to print QoS configuration

Message ID 20230927215354.1874835-3-luiz.dentz@gmail.com (mailing list archive)
State Accepted
Commit d1bb05e3edbce3f474fff4ff592aa39b4a2f667d
Headers show
Series [v4,01/12] media-api: Update to reflect the last code changes | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/CheckPatch success CheckPatch PASS
tedd_an/GitLint fail WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search 10: B3 Line contains hard tab characters (\t): " UUID: 00002bcb-0000-1000-8000-00805f9b34fb" 11: B3 Line contains hard tab characters (\t): " Codec: 0x06 (6)" 12: B3 Line contains hard tab characters (\t): " Configuration:" 14: B3 Line contains hard tab characters (\t): " Device: /org/bluez/hci0/dev_00_AA_01_01_00_03" 15: B3 Line contains hard tab characters (\t): " State: idle" 16: B3 Line contains hard tab characters (\t): " Endpoint: /org/bluez/hci0/dev_00_AA_01_01_00_03/pac_sink0" 17: B3 Line contains hard tab characters (\t): " QoS Key: CIG" 18: B3 Line contains hard tab characters (\t): " QoS Value: 0x00 (0)" 19: B3 Line contains hard tab characters (\t): " QoS Key: CIS" 20: B3 Line contains hard tab characters (\t): " QoS Value: 0x00 (0)" 21: B3 Line contains hard tab characters (\t): " QoS Key: Framing" 22: B3 Line contains hard tab characters (\t): " QoS Value: 0x00 (0)" 23: B3 Line contains hard tab characters (\t): " QoS Key: PresentationDelay" 24: B3 Line contains hard tab characters (\t): " QoS Value: 0x00009c40 (40000)" 25: B3 Line contains hard tab characters (\t): " QoS Key: Interval" 26: B3 Line contains hard tab characters (\t): " QoS Value: 0x00002710 (10000)" 27: B3 Line contains hard tab characters (\t): " QoS Key: Latency" 28: B3 Line contains hard tab characters (\t): " QoS Value: 0x000a (10)" 29: B3 Line contains hard tab characters (\t): " QoS Key: SDU" 30: B3 Line contains hard tab characters (\t): " QoS Value: 0x0028 (40)" 31: B3 Line contains hard tab characters (\t): " QoS Key: PHY" 32: B3 Line contains hard tab characters (\t): " QoS Value: 0x02 (2)" 33: B3 Line contains hard tab characters (\t): " QoS Key: Retransmissions" 34: B3 Line contains hard tab characters (\t): " QoS Value: 0x02 (2)" 35: B3 Line contains hard tab characters (\t): " Location: 0x00000003 (3)" 36: B3 Line contains hard tab characters (\t): " Links: /org/bluez/hci0/dev_00_AA_01_01_00_03/pac_source0/fd0"
tedd_an/IncrementalBuild success Incremental Build PASS

Commit Message

Luiz Augusto von Dentz Sept. 27, 2023, 9:53 p.m. UTC
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

This makes transport.show to print QoS configuration since it is now a
single property:

transport.show <transport>
Transport /org/bluez/hci0/dev_00_AA_01_01_00_03/pac_sink0/fd1
	UUID: 00002bcb-0000-1000-8000-00805f9b34fb
	Codec: 0x06 (6)
	Configuration:
  02 01 03 02 02 01 03 04 28 00                    ........(.
	Device: /org/bluez/hci0/dev_00_AA_01_01_00_03
	State: idle
	Endpoint: /org/bluez/hci0/dev_00_AA_01_01_00_03/pac_sink0
	QoS Key: CIG
	QoS Value: 0x00 (0)
	QoS Key: CIS
	QoS Value: 0x00 (0)
	QoS Key: Framing
	QoS Value: 0x00 (0)
	QoS Key: PresentationDelay
	QoS Value: 0x00009c40 (40000)
	QoS Key: Interval
	QoS Value: 0x00002710 (10000)
	QoS Key: Latency
	QoS Value: 0x000a (10)
	QoS Key: SDU
	QoS Value: 0x0028 (40)
	QoS Key: PHY
	QoS Value: 0x02 (2)
	QoS Key: Retransmissions
	QoS Value: 0x02 (2)
	Location: 0x00000003 (3)
	Links: /org/bluez/hci0/dev_00_AA_01_01_00_03/pac_source0/fd0
---
 client/player.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
diff mbox series

Patch

diff --git a/client/player.c b/client/player.c
index fdc27c281ed8..d72ad6a5da01 100644
--- a/client/player.c
+++ b/client/player.c
@@ -3799,11 +3799,7 @@  static void cmd_show_transport(int argc, char *argv[])
 	print_property(proxy, "Volume");
 	print_property(proxy, "Endpoint");
 
-	print_property(proxy, "Interval");
-	print_property(proxy, "Framing");
-	print_property(proxy, "SDU");
-	print_property(proxy, "Retransmissions");
-	print_property(proxy, "Latency");
+	print_property(proxy, "QoS");
 	print_property(proxy, "Location");
 	print_property(proxy, "Metadata");
 	print_property(proxy, "Links");