diff mbox series

[net,5/7] MAINTAINERS: Bluetooth: retire Johan (for now?)

Message ID 20240109164517.3063131-6-kuba@kernel.org (mailing list archive)
State Accepted
Commit 0bfcdce867f70a8309fe120eb5a9fff2fc54e8b6
Headers show
Series None | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/CheckPatch fail ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit da9065caa594 ("Bluetooth: Fix atomicity violation in {min,max}_key_size_set")' #67: Committer da9065caa594 2023-12-22 00:00:00 341 ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit da9065caa594 ("Bluetooth: Fix atomicity violation in {min,max}_key_size_set")' #68: Tags da9065caa594 2023-12-22 00:00:00 493 total: 2 errors, 0 warnings, 17 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. /github/workspace/src/src/13515071.patch has style problems, please review. NOTE: Ignored message types: UNKNOWN_COMMIT_ID NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.
tedd_an/GitLint success Gitlint PASS
tedd_an/SubjectPrefix success Gitlint PASS
tedd_an/BuildKernel success BuildKernel PASS
tedd_an/CheckAllWarning success CheckAllWarning PASS
tedd_an/CheckSparse success CheckSparse PASS
tedd_an/CheckSmatch success CheckSparse PASS
tedd_an/BuildKernel32 success BuildKernel32 PASS
tedd_an/TestRunnerSetup success TestRunnerSetup PASS
tedd_an/TestRunner_l2cap-tester success TestRunner PASS
tedd_an/TestRunner_iso-tester success TestRunner PASS
tedd_an/TestRunner_bnep-tester success TestRunner PASS
tedd_an/TestRunner_mgmt-tester success TestRunner PASS
tedd_an/TestRunner_rfcomm-tester success TestRunner PASS
tedd_an/TestRunner_sco-tester success TestRunner PASS
tedd_an/TestRunner_ioctl-tester success TestRunner PASS
tedd_an/TestRunner_mesh-tester success TestRunner PASS
tedd_an/TestRunner_smp-tester success TestRunner PASS
tedd_an/TestRunner_userchan-tester success TestRunner PASS
tedd_an/IncrementalBuild success Incremental Build PASS

Commit Message

Jakub Kicinski Jan. 9, 2024, 4:45 p.m. UTC 
Johan moved to maintaining the Zephyr Bluetooth stack,
and we haven't heard from him on the ML in 3 years
(according to lore), and seen any tags in git in 4 years.
Trade the MAINTAINER entry for CREDITS, we can revert
whenever Johan comes back to Linux hacking :)

Subsystem BLUETOOTH SUBSYSTEM
  Changes 173 / 986 (17%)
  Last activity: 2023-12-22
  Marcel Holtmann <marcel@holtmann.org>:
    Author 91cb4c19118a 2022-01-27 00:00:00 52
    Committer edcb185fa9c4 2022-05-23 00:00:00 446
    Tags 000c2fa2c144 2023-04-23 00:00:00 523
  Johan Hedberg <johan.hedberg@gmail.com>:
  Luiz Augusto von Dentz <luiz.dentz@gmail.com>:
    Author d03376c18592 2023-12-22 00:00:00 241
    Committer da9065caa594 2023-12-22 00:00:00 341
    Tags da9065caa594 2023-12-22 00:00:00 493
  Top reviewers:
    [33]: alainm@chromium.org
    [31]: mcchou@chromium.org
    [27]: abhishekpandit@chromium.org
  INACTIVE MAINTAINER Johan Hedberg <johan.hedberg@gmail.com>

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: Marcel Holtmann <marcel@holtmann.org>
CC: Johan Hedberg <johan.hedberg@gmail.com>
CC: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
CC: linux-bluetooth@vger.kernel.org
---
 CREDITS     | 4 ++++
 MAINTAINERS | 1 -
 2 files changed, 4 insertions(+), 1 deletion(-)

Comments

Simon Horman Jan. 10, 2024, 3:13 p.m. UTC | #1 
+ Johan Hedberg <johan.hedberg@intel.com>

On Tue, Jan 09, 2024 at 08:45:15AM -0800, Jakub Kicinski wrote:
> Johan moved to maintaining the Zephyr Bluetooth stack,
> and we haven't heard from him on the ML in 3 years
> (according to lore), and seen any tags in git in 4 years.
> Trade the MAINTAINER entry for CREDITS, we can revert
> whenever Johan comes back to Linux hacking :)
> 
> Subsystem BLUETOOTH SUBSYSTEM
>   Changes 173 / 986 (17%)
>   Last activity: 2023-12-22
>   Marcel Holtmann <marcel@holtmann.org>:
>     Author 91cb4c19118a 2022-01-27 00:00:00 52
>     Committer edcb185fa9c4 2022-05-23 00:00:00 446
>     Tags 000c2fa2c144 2023-04-23 00:00:00 523
>   Johan Hedberg <johan.hedberg@gmail.com>:

I'm not arguing that this change isn't appropriate.
But, nit picking the description above,
I do think there has been some git activity within
the last 4 years, albeit from a different email address.

The most recent Bluetooth Drivers patch I found committed by Johan is:

commit 0671c0662383eefc272e107364cba7fe229dee44
Author:     Hans de Goede <hdegoede@redhat.com>
AuthorDate: Sat Dec 5 16:02:01 2020 +0100
Commit:     Johan Hedberg <johan.hedberg@intel.com>
CommitDate: Mon Dec 7 17:01:54 2020 +0200

For reference, the most recent patched that I could
find authored by Johan for Bluetooth Drivers is:

commit 6c3711ec64fd23a9abc8aaf59a9429569a6282df
Author:     Johan Hedberg <johan.hedberg@intel.com>
AuthorDate: Sat Aug 4 23:40:26 2018 +0300
Commit:     Marcel Holtmann <marcel@holtmann.org>
CommitDate: Sat Aug 4 23:23:32 2018 +0200

>   Luiz Augusto von Dentz <luiz.dentz@gmail.com>:
>     Author d03376c18592 2023-12-22 00:00:00 241
>     Committer da9065caa594 2023-12-22 00:00:00 341
>     Tags da9065caa594 2023-12-22 00:00:00 493
>   Top reviewers:
>     [33]: alainm@chromium.org
>     [31]: mcchou@chromium.org
>     [27]: abhishekpandit@chromium.org
>   INACTIVE MAINTAINER Johan Hedberg <johan.hedberg@gmail.com>
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: Marcel Holtmann <marcel@holtmann.org>
> CC: Johan Hedberg <johan.hedberg@gmail.com>
> CC: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
> CC: linux-bluetooth@vger.kernel.org
> ---
>  CREDITS     | 4 ++++
>  MAINTAINERS | 1 -
>  2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/CREDITS b/CREDITS
> index 18ce75d81234..1228f96110c4 100644
> --- a/CREDITS
> +++ b/CREDITS
> @@ -1543,6 +1543,10 @@ N: Andrew Haylett
>  E: ajh@primag.co.uk
>  D: Selection mechanism
>  
> +N: Johan Hedberg
> +E: johan.hedberg@gmail.com
> +D: Bluetooth subsystem maintainer
> +
>  N: Andre Hedrick
>  E: andre@linux-ide.org
>  E: andre@linuxdiskcert.org
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 1e375699ebb7..388fe7baf89a 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3595,7 +3595,6 @@ F:	drivers/mtd/devices/block2mtd.c
>  
>  BLUETOOTH DRIVERS
>  M:	Marcel Holtmann <marcel@holtmann.org>
> -M:	Johan Hedberg <johan.hedberg@gmail.com>
>  M:	Luiz Augusto von Dentz <luiz.dentz@gmail.com>
>  L:	linux-bluetooth@vger.kernel.org
>  S:	Supported
> -- 
> 2.43.0
>
Jakub Kicinski Jan. 12, 2024, 12:21 a.m. UTC | #2 
On Wed, 10 Jan 2024 15:13:09 +0000 Simon Horman wrote:
> + Johan Hedberg <johan.hedberg@intel.com>
> 
> On Tue, Jan 09, 2024 at 08:45:15AM -0800, Jakub Kicinski wrote:
> > Johan moved to maintaining the Zephyr Bluetooth stack,
> > and we haven't heard from him on the ML in 3 years
> > (according to lore), and seen any tags in git in 4 years.
> > Trade the MAINTAINER entry for CREDITS, we can revert
> > whenever Johan comes back to Linux hacking :)
> > 
> > Subsystem BLUETOOTH SUBSYSTEM
> >   Changes 173 / 986 (17%)
> >   Last activity: 2023-12-22
> >   Marcel Holtmann <marcel@holtmann.org>:
> >     Author 91cb4c19118a 2022-01-27 00:00:00 52
> >     Committer edcb185fa9c4 2022-05-23 00:00:00 446
> >     Tags 000c2fa2c144 2023-04-23 00:00:00 523
> >   Johan Hedberg <johan.hedberg@gmail.com>:  
> 
> I'm not arguing that this change isn't appropriate.
> But, nit picking the description above,
> I do think there has been some git activity within
> the last 4 years, albeit from a different email address.
> 
> The most recent Bluetooth Drivers patch I found committed by Johan is:
> 
> commit 0671c0662383eefc272e107364cba7fe229dee44
> Author:     Hans de Goede <hdegoede@redhat.com>
> AuthorDate: Sat Dec 5 16:02:01 2020 +0100
> Commit:     Johan Hedberg <johan.hedberg@intel.com>
> CommitDate: Mon Dec 7 17:01:54 2020 +0200
> 
> For reference, the most recent patched that I could
> find authored by Johan for Bluetooth Drivers is:
> 
> commit 6c3711ec64fd23a9abc8aaf59a9429569a6282df
> Author:     Johan Hedberg <johan.hedberg@intel.com>
> AuthorDate: Sat Aug 4 23:40:26 2018 +0300
> Commit:     Marcel Holtmann <marcel@holtmann.org>
> CommitDate: Sat Aug 4 23:23:32 2018 +0200

Indeed, my grepping must have failed me :(
If someone pops up in the top three reviewers at the end of the report
it's fairly easy to catch that they use a different address, but that
wasn't the case here. In any case, here is the report after having
added the correct email alias -- just to confirm that the script itself
is not buggy :)

Subsystem BLUETOOTH SUBSYSTEM
  Changes 173 / 986 (17%)
  Last activity: 2023-12-22
  Marcel Holtmann <marcel@holtmann.org>:
    Author 91cb4c19118a 2022-01-27 00:00:00 52
    Committer edcb185fa9c4 2022-05-23 00:00:00 446
    Tags 000c2fa2c144 2023-04-23 00:00:00 523
  Johan Hedberg <johan.hedberg@gmail.com>:
    Committer e6ed8b78eae5 2020-12-07 00:00:00 60
    Tags e6ed8b78eae5 2020-12-07 00:00:00 69
  Luiz Augusto von Dentz <luiz.dentz@gmail.com>:
    Author d03376c18592 2023-12-22 00:00:00 241
    Committer da9065caa594 2023-12-22 00:00:00 341
    Tags da9065caa594 2023-12-22 00:00:00 493
  Top reviewers:
    [33]: alainm@chromium.org
    [31]: mcchou@chromium.org
    [27]: abhishekpandit@chromium.org
patchwork-bot+bluetooth@kernel.org Feb. 2, 2024, 9:22 p.m. UTC | #3 
Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Tue,  9 Jan 2024 08:45:15 -0800 you wrote:
> Johan moved to maintaining the Zephyr Bluetooth stack,
> and we haven't heard from him on the ML in 3 years
> (according to lore), and seen any tags in git in 4 years.
> Trade the MAINTAINER entry for CREDITS, we can revert
> whenever Johan comes back to Linux hacking :)
> 
> Subsystem BLUETOOTH SUBSYSTEM
>   Changes 173 / 986 (17%)
>   Last activity: 2023-12-22
>   Marcel Holtmann <marcel@holtmann.org>:
>     Author 91cb4c19118a 2022-01-27 00:00:00 52
>     Committer edcb185fa9c4 2022-05-23 00:00:00 446
>     Tags 000c2fa2c144 2023-04-23 00:00:00 523
>   Johan Hedberg <johan.hedberg@gmail.com>:
>   Luiz Augusto von Dentz <luiz.dentz@gmail.com>:
>     Author d03376c18592 2023-12-22 00:00:00 241
>     Committer da9065caa594 2023-12-22 00:00:00 341
>     Tags da9065caa594 2023-12-22 00:00:00 493
>   Top reviewers:
>     [33]: alainm@chromium.org
>     [31]: mcchou@chromium.org
>     [27]: abhishekpandit@chromium.org
>   INACTIVE MAINTAINER Johan Hedberg <johan.hedberg@gmail.com>
> 
> [...]

Here is the summary with links:
  - [net,5/7] MAINTAINERS: Bluetooth: retire Johan (for now?)
    https://git.kernel.org/bluetooth/bluetooth-next/c/0bfcdce867f7

You are awesome, thank you!
diff mbox series

Patch

diff --git a/CREDITS b/CREDITS
index 18ce75d81234..1228f96110c4 100644
--- a/CREDITS
+++ b/CREDITS
@@ -1543,6 +1543,10 @@  N: Andrew Haylett
 E: ajh@primag.co.uk
 D: Selection mechanism
 
+N: Johan Hedberg
+E: johan.hedberg@gmail.com
+D: Bluetooth subsystem maintainer
+
 N: Andre Hedrick
 E: andre@linux-ide.org
 E: andre@linuxdiskcert.org
diff --git a/MAINTAINERS b/MAINTAINERS
index 1e375699ebb7..388fe7baf89a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3595,7 +3595,6 @@  F:	drivers/mtd/devices/block2mtd.c
 
 BLUETOOTH DRIVERS
 M:	Marcel Holtmann <marcel@holtmann.org>
-M:	Johan Hedberg <johan.hedberg@gmail.com>
 M:	Luiz Augusto von Dentz <luiz.dentz@gmail.com>
 L:	linux-bluetooth@vger.kernel.org
 S:	Supported