| Message ID | 20240128173352.2714442-2-andreas@kemnade.info (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | bluetooth/gnss: GNSS support for TiWi chips | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | fail | WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search 1: T3 Title has trailing punctuation (.): "[RFC,v2,1/3] gnss: Add AI2 protocol used by some TI combo chips." |
| tedd_an/SubjectPrefix | fail | "Bluetooth: " prefix is not specified in the subject |
| tedd_an/BuildKernel | success | BuildKernel PASS |
| tedd_an/CheckAllWarning | success | CheckAllWarning PASS |
| tedd_an/CheckSparse | success | CheckSparse PASS |
| tedd_an/CheckSmatch | success | CheckSparse PASS |
| tedd_an/BuildKernel32 | success | BuildKernel32 PASS |
| tedd_an/TestRunnerSetup | success | TestRunnerSetup PASS |
| tedd_an/TestRunner_l2cap-tester | success | TestRunner PASS |
| tedd_an/TestRunner_iso-tester | success | TestRunner PASS |
| tedd_an/TestRunner_bnep-tester | success | TestRunner PASS |
| tedd_an/TestRunner_mgmt-tester | success | TestRunner PASS |
| tedd_an/TestRunner_rfcomm-tester | success | TestRunner PASS |
| tedd_an/TestRunner_sco-tester | success | TestRunner PASS |
| tedd_an/TestRunner_ioctl-tester | success | TestRunner PASS |
| tedd_an/TestRunner_mesh-tester | success | TestRunner PASS |
| tedd_an/TestRunner_smp-tester | success | TestRunner PASS |
| tedd_an/TestRunner_userchan-tester | success | TestRunner PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=820664
---Test result---
Test Summary:
CheckPatch FAIL 3.09 seconds
GitLint FAIL 1.20 seconds
SubjectPrefix FAIL 0.82 seconds
BuildKernel PASS 28.15 seconds
CheckAllWarning PASS 30.57 seconds
CheckSparse PASS 36.49 seconds
CheckSmatch PASS 99.37 seconds
BuildKernel32 PASS 27.31 seconds
TestRunnerSetup PASS 436.50 seconds
TestRunner_l2cap-tester PASS 22.88 seconds
TestRunner_iso-tester PASS 45.29 seconds
TestRunner_bnep-tester PASS 6.89 seconds
TestRunner_mgmt-tester PASS 157.82 seconds
TestRunner_rfcomm-tester PASS 10.83 seconds
TestRunner_sco-tester PASS 14.24 seconds
TestRunner_ioctl-tester PASS 12.03 seconds
TestRunner_mesh-tester PASS 9.11 seconds
TestRunner_smp-tester PASS 9.70 seconds
TestRunner_userchan-tester PASS 7.20 seconds
IncrementalBuild PASS 35.02 seconds
Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
[RFC,v2,3/3] gnss: Add driver for AI2 protocol
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#128:
new file mode 100644
total: 0 errors, 1 warnings, 546 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/src/13534589.patch has style problems, please review.
NOTE: Ignored message types: UNKNOWN_COMMIT_ID
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
[RFC,v2,1/3] gnss: Add AI2 protocol used by some TI combo chips.
WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
1: T3 Title has trailing punctuation (.): "[RFC,v2,1/3] gnss: Add AI2 protocol used by some TI combo chips."
##############################
Test: SubjectPrefix - FAIL
Desc: Check subject contains "Bluetooth" prefix
Output:
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
---
Regards,
Linux Bluetooth
Dear Andreas, Thank you for your patch. I think Linux Bluetooth patches need to be have Bluetooth as the prefix for the commit message summary/title. Also, it’d be great if you removed the dot/period at the end of the commit message summary/title. Am 28.01.24 um 18:33 schrieb Andreas Kemnade: > Texas Instruments uses something called Air Independent Interface (AI2) for > their WLAN/BT/GPS combo chips. > No public documentation is available, but allow that protocol to be > specified. I’d add a blank line between paragraphs. > Signed-off-by: Andreas Kemnade <andreas@kemnade.info> > --- > drivers/gnss/core.c | 1 + > include/linux/gnss.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/gnss/core.c b/drivers/gnss/core.c > index 48f2ee0f78c4d..cac9f45aec4b2 100644 > --- a/drivers/gnss/core.c > +++ b/drivers/gnss/core.c > @@ -335,6 +335,7 @@ static const char * const gnss_type_names[GNSS_TYPE_COUNT] = { > [GNSS_TYPE_SIRF] = "SiRF", > [GNSS_TYPE_UBX] = "UBX", > [GNSS_TYPE_MTK] = "MTK", > + [GNSS_TYPE_AI2] = "AI2", > }; > > static const char *gnss_type_name(const struct gnss_device *gdev) > diff --git a/include/linux/gnss.h b/include/linux/gnss.h > index 36968a0f33e8d..16b565dab83ea 100644 > --- a/include/linux/gnss.h > +++ b/include/linux/gnss.h > @@ -23,6 +23,7 @@ enum gnss_type { > GNSS_TYPE_SIRF, > GNSS_TYPE_UBX, > GNSS_TYPE_MTK, > + GNSS_TYPE_AI2, > > GNSS_TYPE_COUNT > }; Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de> Kind regards, Paul
Hi, On Mon, 29 Jan 2024 08:40:58 +0100 Paul Menzel <pmenzel@molgen.mpg.de> wrote: > Dear Andreas, > > > Thank you for your patch. I think Linux Bluetooth patches need to be > have Bluetooth as the prefix for the commit message summary/title. Also, > it’d be great if you removed the dot/period at the end of the commit > message summary/title. > well, it is not a Bluetooth patch, although sent in a series with a Bluetooth patch included, so having Bluetooth as th prefix just does not make any sense. Regards, Andreas
diff --git a/drivers/gnss/core.c b/drivers/gnss/core.c index 48f2ee0f78c4d..cac9f45aec4b2 100644 --- a/drivers/gnss/core.c +++ b/drivers/gnss/core.c @@ -335,6 +335,7 @@ static const char * const gnss_type_names[GNSS_TYPE_COUNT] = { [GNSS_TYPE_SIRF] = "SiRF", [GNSS_TYPE_UBX] = "UBX", [GNSS_TYPE_MTK] = "MTK", + [GNSS_TYPE_AI2] = "AI2", }; static const char *gnss_type_name(const struct gnss_device *gdev) diff --git a/include/linux/gnss.h b/include/linux/gnss.h index 36968a0f33e8d..16b565dab83ea 100644 --- a/include/linux/gnss.h +++ b/include/linux/gnss.h @@ -23,6 +23,7 @@ enum gnss_type { GNSS_TYPE_SIRF, GNSS_TYPE_UBX, GNSS_TYPE_MTK, + GNSS_TYPE_AI2, GNSS_TYPE_COUNT };
Texas Instruments uses something called Air Independent Interface (AI2) for their WLAN/BT/GPS combo chips. No public documentation is available, but allow that protocol to be specified. Signed-off-by: Andreas Kemnade <andreas@kemnade.info> --- drivers/gnss/core.c | 1 + include/linux/gnss.h | 1 + 2 files changed, 2 insertions(+)