| Message ID | 20240214155019.325715-1-hadess@hadess.net (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [[BlueZ] ] mesh-gatt: Fix JSON files missing from dist | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | warning | WARNING:BAD_FIXES_TAG: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: ("build: Deprecate meshctl tool")' #50: Fixes: 1f6553edd8a5c ("build: Deprecate meshctl tool") WARNING:UNKNOWN_COMMIT_ID: Unknown commit id '1f6553edd8a5c', maybe rebased or not pulled? #50: Fixes: 1f6553edd8a5c ("build: Deprecate meshctl tool") /github/workspace/src/src/13556710.patch total: 0 errors, 2 warnings, 10 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. /github/workspace/src/src/13556710.patch has style problems, please review. NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Use of uninitialized value $cid in concatenation (.) or string at /usr/bin/checkpatch.pl line 3196. |
| tedd_an/GitLint | success | Gitlint PASS |
| tedd_an/BuildEll | success | Build ELL PASS |
| tedd_an/BluezMake | success | Bluez Make PASS |
| tedd_an/MakeCheck | success | Bluez Make Check PASS |
| tedd_an/MakeDistcheck | success | Make Distcheck PASS |
| tedd_an/CheckValgrind | success | Check Valgrind PASS |
| tedd_an/CheckSmatch | success | CheckSparse PASS |
| tedd_an/bluezmakeextell | success | Make External ELL PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
| tedd_an/ScanBuild | success | Scan Build PASS |
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=826064
---Test result---
Test Summary:
CheckPatch FAIL 0.50 seconds
GitLint PASS 0.22 seconds
BuildEll PASS 24.12 seconds
BluezMake PASS 704.47 seconds
MakeCheck PASS 11.79 seconds
MakeDistcheck PASS 165.83 seconds
CheckValgrind PASS 227.25 seconds
CheckSmatch PASS 330.46 seconds
bluezmakeextell PASS 107.33 seconds
IncrementalBuild PASS 665.70 seconds
ScanBuild PASS 956.84 seconds
Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
[[BlueZ] ] mesh-gatt: Fix JSON files missing from dist
WARNING:BAD_FIXES_TAG: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: ("build: Deprecate meshctl tool")'
#50:
Fixes: 1f6553edd8a5c ("build: Deprecate meshctl tool")
WARNING:UNKNOWN_COMMIT_ID: Unknown commit id '1f6553edd8a5c', maybe rebased or not pulled?
#50:
Fixes: 1f6553edd8a5c ("build: Deprecate meshctl tool")
/github/workspace/src/src/13556710.patch total: 0 errors, 2 warnings, 10 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/src/13556710.patch has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
Use of uninitialized value $cid in concatenation (.) or string at /usr/bin/checkpatch.pl line 3196.
---
Regards,
Linux Bluetooth
diff --git a/Makefile.tools b/Makefile.tools index 044342e29bc6..4178940bf066 100644 --- a/Makefile.tools +++ b/Makefile.tools @@ -378,9 +378,8 @@ tools_meshctl_SOURCES = tools/meshctl.c \ tools_meshctl_LDADD = gdbus/libgdbus-internal.la src/libshared-glib.la \ lib/libbluetooth-internal.la \ $(GLIB_LIBS) $(DBUS_LIBS) -ljson-c -lreadline - -EXTRA_DIST += tools/mesh-gatt/local_node.json tools/mesh-gatt/prov_db.json endif +EXTRA_DIST += tools/mesh-gatt/local_node.json tools/mesh-gatt/prov_db.json bin_PROGRAMS += tools/mesh-cfgclient
Moving EXTRA_DIST into a conditional means that if the dist isn't made with the deprecated tools enabled, then files will be missing from the distribution. Fixes: 1f6553edd8a5c ("build: Deprecate meshctl tool") --- Makefile.tools | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)