| Message ID | 20240216203215.40870-7-brgl@bgdev.pl (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | power: sequencing: implement the subsystem and add first users | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
Bartosz Golaszewski <brgl@bgdev.pl> writes: > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > Add device-tree bindings for the ATH12K module found in the WCN7850 > package. > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > --- > .../net/wireless/qcom,ath12k-pci.yaml | 103 ++++++++++++++++++ > 1 file changed, 103 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml > > diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml > new file mode 100644 > index 000000000000..063c576b99a0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml > @@ -0,0 +1,103 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (c) 2024 Linaro Limited > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/wireless/qcom,ath12k-pci.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Technologies ath12k wireless devices (PCIe) > + > +maintainers: > + - Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Jeff and me are the ath12k driver maintainers so shouldn't we listed here as well? Jeff, this reminds me that we should add you to qcom,ath10k.yaml, qcom,ath11k-pci.yaml and qcom,ath11k.yaml as maintainer.
On Sat, Feb 17, 2024 at 7:35 AM Kalle Valo <kvalo@kernel.org> wrote: > > Bartosz Golaszewski <brgl@bgdev.pl> writes: > > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > > > Add device-tree bindings for the ATH12K module found in the WCN7850 > > package. > > > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > --- > > .../net/wireless/qcom,ath12k-pci.yaml | 103 ++++++++++++++++++ > > 1 file changed, 103 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml > > > > diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml > > new file mode 100644 > > index 000000000000..063c576b99a0 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml > > @@ -0,0 +1,103 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +# Copyright (c) 2024 Linaro Limited > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/net/wireless/qcom,ath12k-pci.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Qualcomm Technologies ath12k wireless devices (PCIe) > > + > > +maintainers: > > + - Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > Jeff and me are the ath12k driver maintainers so shouldn't we listed > here as well? > Sure will do. I also noticed the subject is wrong, should have been "net" not "new". Also, Jeff is not showing up for ath12k bindings in get_maintainer.pl. You could consider adding an N: ath12k entry to MAINTAINERS. Bartosz > Jeff, this reminds me that we should add you to qcom,ath10k.yaml, > qcom,ath11k-pci.yaml and qcom,ath11k.yaml as maintainer. > > -- > https://patchwork.kernel.org/project/linux-wireless/list/ > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
On 2/17/2024 10:30 AM, Bartosz Golaszewski wrote: > On Sat, Feb 17, 2024 at 7:35 AM Kalle Valo <kvalo@kernel.org> wrote: >> >> Bartosz Golaszewski <brgl@bgdev.pl> writes: >> >>> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> >>> >>> Add device-tree bindings for the ATH12K module found in the WCN7850 >>> package. >>> >>> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> >>> --- >>> .../net/wireless/qcom,ath12k-pci.yaml | 103 ++++++++++++++++++ >>> 1 file changed, 103 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml >>> new file mode 100644 >>> index 000000000000..063c576b99a0 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml >>> @@ -0,0 +1,103 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +# Copyright (c) 2024 Linaro Limited >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/net/wireless/qcom,ath12k-pci.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Qualcomm Technologies ath12k wireless devices (PCIe) >>> + >>> +maintainers: >>> + - Bartosz Golaszewski <bartosz.golaszewski@linaro.org> >> >> Jeff and me are the ath12k driver maintainers so shouldn't we listed >> here as well? >> > > Sure will do. I also noticed the subject is wrong, should have been > "net" not "new". > > Also, Jeff is not showing up for ath12k bindings in get_maintainer.pl. > You could consider adding an N: ath12k entry to MAINTAINERS. > > Bartosz > >> Jeff, this reminds me that we should add you to qcom,ath10k.yaml, >> qcom,ath11k-pci.yaml and qcom,ath11k.yaml as maintainer. OK, I'll update those files. And looking at MAINTAINERS, in ath10 we have an explicit path: F: Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml And in ath11k we have an explicit path: F: Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml However the ath11k entry is missing: Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml So it looks like I have a few patches: - update my entries in MAINTAINERS to use my @kernel.org e-mail - add myself to the existing *ath1*k*.yaml files as a maintainer - update MAINTAINERS to replace F: *.yaml with N: ath1*k to match any related files, including the YAML files /jeff
On 16/02/2024 21:32, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > Add device-tree bindings for the ATH12K module found in the WCN7850 > package. > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > --- > .../net/wireless/qcom,ath12k-pci.yaml | 103 ++++++++++++++++++ > 1 file changed, 103 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml > > diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml > new file mode 100644 > index 000000000000..063c576b99a0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml This means there can be ath12k over AHB or some other bus, which would be quite different and not fit together in one schema file. It's that the case? > @@ -0,0 +1,103 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (c) 2024 Linaro Limited > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/wireless/qcom,ath12k-pci.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Technologies ath12k wireless devices (PCIe) > + > +maintainers: > + - Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > + > +description: | Do not need '|' unless you need to preserve formatting. > + Qualcomm Technologies IEEE 802.11ax PCIe devices > + > +properties: > + compatible: > + enum: > + - pci17cb,1107 # WCN7850 > + > + reg: > + maxItems: 1 > + > + enable-gpios: > + maxItems: 1 > + description: GPIO line enabling the WLAN module > + > + vdd-supply: > + description: VDD supply regulator handle > + > + vddio-supply: > + description: VDD_IO supply regulator handle > + > + vddio1p2-supply: > + description: VDD_IO_1P2 supply regulator handle > + > + vddaon-supply: > + description: VDD_AON supply regulator handle > + > + vdddig-supply: > + description: VDD_DIG supply regulator handle > + > + vddrfa1p2-supply: > + description: VDD_RFA_1P2 supply regulator handle > + > + vddrfa1p8-supply: > + description: VDD_PCIE_1P8 supply regulator handle > + > + clocks: > + maxItems: 1 > + description: > + Reference clock phandle These three could be just: items: - description: Reference clock (phandle is redundant in this context) Best regards, Krzysztof
On Fri, Feb 16, 2024 at 09:32:03PM +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> s/new/net/ in the subject. > > Add device-tree bindings for the ATH12K module found in the WCN7850 > package. > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > --- > .../net/wireless/qcom,ath12k-pci.yaml | 103 ++++++++++++++++++ > 1 file changed, 103 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml
diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml new file mode 100644 index 000000000000..063c576b99a0 --- /dev/null +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml @@ -0,0 +1,103 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# Copyright (c) 2024 Linaro Limited +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/wireless/qcom,ath12k-pci.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Qualcomm Technologies ath12k wireless devices (PCIe) + +maintainers: + - Bartosz Golaszewski <bartosz.golaszewski@linaro.org> + +description: | + Qualcomm Technologies IEEE 802.11ax PCIe devices + +properties: + compatible: + enum: + - pci17cb,1107 # WCN7850 + + reg: + maxItems: 1 + + enable-gpios: + maxItems: 1 + description: GPIO line enabling the WLAN module + + vdd-supply: + description: VDD supply regulator handle + + vddio-supply: + description: VDD_IO supply regulator handle + + vddio1p2-supply: + description: VDD_IO_1P2 supply regulator handle + + vddaon-supply: + description: VDD_AON supply regulator handle + + vdddig-supply: + description: VDD_DIG supply regulator handle + + vddrfa1p2-supply: + description: VDD_RFA_1P2 supply regulator handle + + vddrfa1p8-supply: + description: VDD_PCIE_1P8 supply regulator handle + + clocks: + maxItems: 1 + description: + Reference clock phandle + +required: + - compatible + - reg + - vdd-supply + - vddio-supply + - vddaon-supply + - vdddig-supply + - vddrfa1p2-supply + - vddrfa1p8-supply + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/qcom,rpmh.h> + #include <dt-bindings/gpio/gpio.h> + pcie { + #address-cells = <3>; + #size-cells = <2>; + + pcie@0 { + device_type = "pci"; + reg = <0x0 0x0 0x0 0x0 0x0>; + #address-cells = <3>; + #size-cells = <2>; + ranges; + + bus-range = <0x01 0xff>; + + wifi@0 { + compatible = "pci17cb,1107"; + reg = <0x10000 0x0 0x0 0x0 0x0>; + + pinctrl-names = "default"; + pinctrl-0 = <&wlan_en>; + + enable-gpios = <&tlmm 16 GPIO_ACTIVE_HIGH>; + + vdd-supply = <&vreg_s4i_0p85>; + vddio-supply = <&vreg_l15b_1p8>; + vddio1p2-supply = <&vreg_l3c_1p2>; + vddaon-supply = <&vreg_s2c_0p8>; + vdddig-supply = <&vreg_s3c_0p9>; + vddrfa1p2-supply = <&vreg_s1c_1p2>; + vddrfa1p8-supply = <&vreg_s6c_1p8>; + + clocks = <&rpmhcc RPMH_RF_CLK1>; + }; + }; + };