| Message ID | 20240329063534.56892-2-mahesh.talewad@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Autoconnecttimeout max value increased to 20000 msecs | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | fail | WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search 1: T1 Title exceeds max length (85>80): "[BlueZ,v1,1/1] Autoconnecttimeout max value increased to 20000 msecs from 16384 msecs" |
| tedd_an/BuildEll | success | Build ELL PASS |
| tedd_an/BluezMake | success | Bluez Make PASS |
| tedd_an/MakeCheck | success | Bluez Make Check PASS |
| tedd_an/MakeDistcheck | success | Make Distcheck PASS |
| tedd_an/CheckValgrind | success | Check Valgrind PASS |
| tedd_an/CheckSmatch | success | CheckSparse PASS |
| tedd_an/bluezmakeextell | success | Make External ELL PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
| tedd_an/ScanBuild | success | Scan Build PASS |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=839675 ---Test result--- Test Summary: CheckPatch PASS 0.48 seconds GitLint FAIL 0.48 seconds BuildEll PASS 24.42 seconds BluezMake PASS 1658.83 seconds MakeCheck PASS 13.87 seconds MakeDistcheck PASS 176.99 seconds CheckValgrind PASS 248.83 seconds CheckSmatch PASS 350.74 seconds bluezmakeextell PASS 119.39 seconds IncrementalBuild PASS 1440.37 seconds ScanBuild PASS 992.18 seconds Details ############################## Test: GitLint - FAIL Desc: Run gitlint Output: [BlueZ,v1,1/1] Autoconnecttimeout max value increased to 20000 msecs from 16384 msecs WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search 1: T1 Title exceeds max length (85>80): "[BlueZ,v1,1/1] Autoconnecttimeout max value increased to 20000 msecs from 16384 msecs" --- Regards, Linux Bluetooth
Dear Mahesh, Thank you for you patch. Am 29.03.24 um 07:35 schrieb Mahesh Talewad: > - In implementation Autoconnecttimeout max value is 16384 msecs. > Increased this Autoconnecttimeout max value to 20000 msecs. Please do *not* format it as a list item. I’d also rewrite the commit message summary/title to use imperative mood: > Increase autoconnect timeout max from 16.384 s to 20 s Please also add, why this change is necessary. > Signed-off-by: Mahesh Talewad <mahesh.talewad@nxp.com> > --- > src/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/main.c b/src/main.c > index b1339c230..8ce72badc 100644 > --- a/src/main.c > +++ b/src/main.c > @@ -656,7 +656,7 @@ static void parse_le_config(GKeyFile *config) > &btd_opts.defaults.le.autoconnect_timeout, > sizeof(btd_opts.defaults.le.autoconnect_timeout), > 0x0001, > - 0x4000}, > + 0x4E20}, Please add a comment with the decimal value. (Or why not use a decimal value?) Also, isn’t 2 * 16 + 15 * 256 + 4 * 16^3 = 20256 Why not just use 0x5000 (= 20480) to make it easier to calculate? > { "AdvMonAllowlistScanDuration", > &btd_opts.defaults.le.advmon_allowlist_scan_duration, > sizeof(btd_opts.defaults.le.advmon_allowlist_scan_duration),
diff --git a/src/main.c b/src/main.c index b1339c230..8ce72badc 100644 --- a/src/main.c +++ b/src/main.c @@ -656,7 +656,7 @@ static void parse_le_config(GKeyFile *config) &btd_opts.defaults.le.autoconnect_timeout, sizeof(btd_opts.defaults.le.autoconnect_timeout), 0x0001, - 0x4000}, + 0x4E20}, { "AdvMonAllowlistScanDuration", &btd_opts.defaults.le.advmon_allowlist_scan_duration, sizeof(btd_opts.defaults.le.advmon_allowlist_scan_duration),
- In implementation Autoconnecttimeout max value is 16384 msecs. Increased this Autoconnecttimeout max value to 20000 msecs. Signed-off-by: Mahesh Talewad <mahesh.talewad@nxp.com> --- src/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)