diff mbox series

PENDING: Bluetooth: Increase settling time for baudrate change VSC

Message ID 20240603125357.3035-1-quic_janathot@quicinc.com (mailing list archive)
State New, archived
Headers show
Series PENDING: Bluetooth: Increase settling time for baudrate change VSC | expand

Checks

Context Check Description
tedd_an/pre-ci_am fail error: patch failed: drivers/bluetooth/btqca.c:600 error: drivers/bluetooth/btqca.c: patch does not apply error: patch failed: drivers/bluetooth/hci_qca.c:1904 error: drivers/bluetooth/hci_qca.c: patch does not apply hint: Use 'git am --show-current-patch' to see the failed patch

Commit Message

Janaki Ramaiah Thota June 3, 2024, 12:53 p.m. UTC
From: Harish Bandi <quic_hbandi@quicinc.com>

This change is done to align the settling time and
synchronization for baudrate VSC for WCN6750.

In logging disabled builds and few devices
baudrate change and flow control is taking time
so increasing the wait time to controller and uart
to handle baudrate change request properly.

Change-Id: If0631cb886e53817f963f075e626c89a791b7be4
Signed-off-by: Harish Bandi <quic_hbandi@quicinc.com>
---

Comments

bluez.test.bot@gmail.com June 3, 2024, 1:05 p.m. UTC | #1
This is an automated email and please do not reply to this email.

Dear Submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
While preparing the CI tests, the patches you submitted couldn't be applied to the current HEAD of the repository.

----- Output -----

error: patch failed: drivers/bluetooth/btqca.c:600
error: drivers/bluetooth/btqca.c: patch does not apply
error: patch failed: drivers/bluetooth/hci_qca.c:1904
error: drivers/bluetooth/hci_qca.c: patch does not apply
hint: Use 'git am --show-current-patch' to see the failed patch

Please resolve the issue and submit the patches again.


---
Regards,
Linux Bluetooth
Janaki Ramaiah Thota June 3, 2024, 1:47 p.m. UTC | #2
> From: Janaki Ramaiah Thota (Temp) (QUIC) <quic_janathot@quicinc.com>
> Sent: Monday, June 3, 2024 6:24 PM
> To: Marcel Holtmann <marcel@holtmann.org>; Luiz Augusto von Dentz <luiz.dentz@gmail.com>
> Cc: Mohammed Sameer Mulla (QUIC) <quic_mohamull@quicinc.com>; Harish Bandi (QUIC) <quic_hbandi@quicinc.com>; linux-bluetooth@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] PENDING: Bluetooth: Increase settling time for baudrate change VSC
> 
> From: Harish Bandi <quic_hbandi@quicinc.com>
> 
> This change is done to align the settling time and synchronization for baudrate VSC for WCN6750.
> 
> In logging disabled builds and few devices baudrate change and flow control is taking time so increasing the wait time to controller and uart to handle baudrate change request properly.
> 
> Change-Id: If0631cb886e53817f963f075e626c89a791b7be4
> Signed-off-by: Harish Bandi <quic_hbandi@quicinc.com>
> ---
> 
> diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c index eba9165..a59b35e 100644
> --- a/drivers/bluetooth/btqca.c
> +++ b/drivers/bluetooth/btqca.c
> @@ -600,7 +600,6 @@
>                  rom_ver = ((soc_ver & 0x00000f00) >> 0x04) | (soc_ver & 0x0000000f);
> 
>          if (soc_type == QCA_WCN6750) {
> -               msleep(100);
>                  qca_send_patch_config_cmd(hdev);
>          }
> 
> diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c index d8abd27..0b41214 100644
> --- a/drivers/bluetooth/hci_qca.c
> +++ b/drivers/bluetooth/hci_qca.c
> @@ -1356,11 +1356,13 @@
>          case QCA_WCN3990:
>          case QCA_WCN3991:
>          case QCA_WCN3998:
> -       case QCA_WCN6750:
>          case QCA_WCN6855:
>          case QCA_WCN7850:
>                  usleep_range(1000, 10000);
>                  break;
> +       case QCA_WCN6750:
> +               msleep(30);
> +               break;
> 
>          default:
>                  msleep(300);
> @@ -1904,7 +1906,6 @@
>                  qca_set_speed(hu, QCA_INIT_SPEED);
>          }
> 
> -       usleep_range(1000, 20000);
>          /* Setup user speed if needed */
>          speed = qca_get_speed(hu, QCA_OPER_SPEED);
>          if (speed) {

Please ignore the above patch.

-Janaki Ram
diff mbox series

Patch

diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
index eba9165..a59b35e 100644
--- a/drivers/bluetooth/btqca.c
+++ b/drivers/bluetooth/btqca.c
@@ -600,7 +600,6 @@ 
 		rom_ver = ((soc_ver & 0x00000f00) >> 0x04) | (soc_ver & 0x0000000f);
 
 	if (soc_type == QCA_WCN6750) {
-		msleep(100);
 		qca_send_patch_config_cmd(hdev);
 	}
 
diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
index d8abd27..0b41214 100644
--- a/drivers/bluetooth/hci_qca.c
+++ b/drivers/bluetooth/hci_qca.c
@@ -1356,11 +1356,13 @@ 
 	case QCA_WCN3990:
 	case QCA_WCN3991:
 	case QCA_WCN3998:
-	case QCA_WCN6750:
 	case QCA_WCN6855:
 	case QCA_WCN7850:
 		usleep_range(1000, 10000);
 		break;
+	case QCA_WCN6750:
+		msleep(30);
+		break;
 
 	default:
 		msleep(300);
@@ -1904,7 +1906,6 @@ 
 		qca_set_speed(hu, QCA_INIT_SPEED);
 	}
 
-	usleep_range(1000, 20000);
 	/* Setup user speed if needed */
 	speed = qca_get_speed(hu, QCA_OPER_SPEED);
 	if (speed) {