| Message ID | 20240617070039.30824-1-quic_janathot@quicinc.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v1] Bluetooth: hci_qca: Increase settling time for baudrate change VSC | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | success | Gitlint PASS |
| tedd_an/SubjectPrefix | success | Gitlint PASS |
| tedd_an/BuildKernel | success | BuildKernel PASS |
| tedd_an/CheckAllWarning | success | CheckAllWarning PASS |
| tedd_an/CheckSparse | success | CheckSparse PASS |
| tedd_an/CheckSmatch | success | CheckSparse PASS |
| tedd_an/BuildKernel32 | success | BuildKernel32 PASS |
| tedd_an/TestRunnerSetup | success | TestRunnerSetup PASS |
| tedd_an/TestRunner_l2cap-tester | success | TestRunner PASS |
| tedd_an/TestRunner_iso-tester | fail | TestRunner_iso-tester: Total: 122, Passed: 117 (95.9%), Failed: 1, Not Run: 4 |
| tedd_an/TestRunner_bnep-tester | success | TestRunner PASS |
| tedd_an/TestRunner_mgmt-tester | fail | TestRunner_mgmt-tester: Total: 492, Passed: 488 (99.2%), Failed: 2, Not Run: 2 |
| tedd_an/TestRunner_rfcomm-tester | success | TestRunner PASS |
| tedd_an/TestRunner_sco-tester | success | TestRunner PASS |
| tedd_an/TestRunner_ioctl-tester | success | TestRunner PASS |
| tedd_an/TestRunner_mesh-tester | success | TestRunner PASS |
| tedd_an/TestRunner_smp-tester | success | TestRunner PASS |
| tedd_an/TestRunner_userchan-tester | success | TestRunner PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
Dear Janaki, Thank you for your patch. Please be more specific in the summary/title: > Increase settling time for baudrate change VSC to 30 ms Am 17.06.24 um 09:00 schrieb Janaki Ramaiah Thota: > This change is done to align the settling time and > synchronization for baudrate VSC for WCN6750. > > In logging disabled builds and few devices > baudrate change and flow control is taking time > so increasing the wait time to controller and uart > to handle baudrate change request properly. Is the 30 ms documented in some datasheet? Please use 75 characters per line. Please document the test system. > Signed-off-by: Janaki Ramaiah Thota <quic_janathot@quicinc.com> > --- > drivers/bluetooth/hci_qca.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c > index 0c9c9ee56592..667687835306 100644 > --- a/drivers/bluetooth/hci_qca.c > +++ b/drivers/bluetooth/hci_qca.c > @@ -1356,12 +1356,15 @@ static int qca_set_baudrate(struct hci_dev *hdev, uint8_t baudrate) > case QCA_WCN3990: > case QCA_WCN3991: > case QCA_WCN3998: > - case QCA_WCN6750: > case QCA_WCN6855: > case QCA_WCN7850: > usleep_range(1000, 10000); > break; > > + case QCA_WCN6750: > + msleep(30); Why not usleep_range? > + break; > + > default: > msleep(300); > } Kind regards, Paul
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=862483 ---Test result--- Test Summary: CheckPatch PASS 0.63 seconds GitLint PASS 0.52 seconds SubjectPrefix PASS 0.11 seconds BuildKernel PASS 31.03 seconds CheckAllWarning PASS 33.56 seconds CheckSparse PASS 39.37 seconds CheckSmatch PASS 105.21 seconds BuildKernel32 PASS 29.79 seconds TestRunnerSetup PASS 535.16 seconds TestRunner_l2cap-tester PASS 20.70 seconds TestRunner_iso-tester FAIL 39.66 seconds TestRunner_bnep-tester PASS 5.05 seconds TestRunner_mgmt-tester FAIL 115.36 seconds TestRunner_rfcomm-tester PASS 7.77 seconds TestRunner_sco-tester PASS 15.31 seconds TestRunner_ioctl-tester PASS 8.16 seconds TestRunner_mesh-tester PASS 6.14 seconds TestRunner_smp-tester PASS 7.17 seconds TestRunner_userchan-tester PASS 5.40 seconds IncrementalBuild PASS 29.33 seconds Details ############################## Test: TestRunner_iso-tester - FAIL Desc: Run iso-tester with test-runner Output: Total: 122, Passed: 117 (95.9%), Failed: 1, Not Run: 4 Failed Test Cases ISO Connect2 Suspend - Success Failed 6.165 seconds ############################## Test: TestRunner_mgmt-tester - FAIL Desc: Run mgmt-tester with test-runner Output: Total: 492, Passed: 488 (99.2%), Failed: 2, Not Run: 2 Failed Test Cases LL Privacy - Add Device 4 (2 Devices to AL) Failed 0.171 seconds LL Privacy - Add Device 7 (AL is full) Failed 0.206 seconds --- Regards, Linux Bluetooth
diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c index 0c9c9ee56592..667687835306 100644 --- a/drivers/bluetooth/hci_qca.c +++ b/drivers/bluetooth/hci_qca.c @@ -1356,12 +1356,15 @@ static int qca_set_baudrate(struct hci_dev *hdev, uint8_t baudrate) case QCA_WCN3990: case QCA_WCN3991: case QCA_WCN3998: - case QCA_WCN6750: case QCA_WCN6855: case QCA_WCN7850: usleep_range(1000, 10000); break; + case QCA_WCN6750: + msleep(30); + break; + default: msleep(300); }
This change is done to align the settling time and synchronization for baudrate VSC for WCN6750. In logging disabled builds and few devices baudrate change and flow control is taking time so increasing the wait time to controller and uart to handle baudrate change request properly. Signed-off-by: Janaki Ramaiah Thota <quic_janathot@quicinc.com> --- drivers/bluetooth/hci_qca.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)