Message ID | 20240619052300.233657-4-bearodark@gmail.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | bluetooth/btusb.c: Add extra mediatek btusb target | expand |
Context | Check | Description |
---|---|---|
tedd_an/pre-ci_am | success | Success |
tedd_an/CheckPatch | warning | WARNING: 'recieved' may be misspelled - perhaps 'received'? #98: not match the PCB that was recieved: ^^^^^^^^ total: 0 errors, 1 warnings, 9 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. /github/workspace/src/src/13703421.patch has style problems, please review. NOTE: Ignored message types: UNKNOWN_COMMIT_ID NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. |
tedd_an/GitLint | fail | WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search 6: B2 Line has trailing whitespace: "BT 5.3 M.2 chipset that I purchased from aliexpress (and which " 11: B2 Line has trailing whitespace: "The chipset was purchased from here, though the storefront image does " |
tedd_an/SubjectPrefix | fail | "Bluetooth: " prefix is not specified in the subject |
tedd_an/BuildKernel | success | BuildKernel PASS |
tedd_an/CheckAllWarning | success | CheckAllWarning PASS |
tedd_an/CheckSparse | success | CheckSparse PASS |
tedd_an/CheckSmatch | success | CheckSparse PASS |
tedd_an/BuildKernel32 | success | BuildKernel32 PASS |
tedd_an/TestRunnerSetup | success | TestRunnerSetup PASS |
Dear Alexander, Thank you for the patch, and welcome to the Linux kernel! Fore the summary, I’d use: Bluetooth: btusb: Add USB HW id 0x3604 for MediaTek MT7925B22M Am 19.06.24 um 07:23 schrieb ultrabear: > From: Alexander Hall <bearodark@gmail.com> > > This patch fixes bluetooth support on the MediaTek MT7925 WiFi 7 + > BT 5.3 M.2 chipset that I purchased from aliexpress (and which > arrived today). The PCB states that it is an MT7925B22M. > > I tested that this patch did fix my problem; bluetooth now works. > > The chipset was purchased from here, though the storefront image does > not match the PCB that was recieved: rec*ei*ved > https://www.aliexpress.com/item/3256806821207897.html Maybe save on archive.org and reference that. Please also add the output of `/sys/kernel/debug/usb/devices` to the commit message as done in other commits (`git log drivers/bluetooth/btusb.c`). > Signed-off-by: Alexander Hall <bearodark@gmail.com> > --- > This is my first submitted patch to the linux kernel, apologies if I > have misunderstood any portion of the process. Welcome! For this subsystem, your patch is going to be checked by a bot. It will probably ask you to use `Bluetooth:` as the prefix. Also, you should Cc: the maintainers. It can be integrated in git [1]. > drivers/bluetooth/btusb.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c > index e384ef6ff..2ea46a0e6 100644 > --- a/drivers/bluetooth/btusb.c > +++ b/drivers/bluetooth/btusb.c > @@ -691,6 +691,9 @@ static const struct usb_device_id quirks_table[] = { > { USB_DEVICE(0x13d3, 0x3603), .driver_info = BTUSB_MEDIATEK | > BTUSB_WIDEBAND_SPEECH | > BTUSB_VALID_LE_STATES }, > + { USB_DEVICE(0x13d3, 0x3604), .driver_info = BTUSB_MEDIATEK | > + BTUSB_WIDEBAND_SPEECH | > + BTUSB_VALID_LE_STATES }, > > /* Additional Realtek 8723AE Bluetooth devices */ > { USB_DEVICE(0x0930, 0x021d), .driver_info = BTUSB_REALTEK }, You can amend the commit message with `git commit --amend`, and then do `git format-patch -v2` to get *v2* into the subject/title. I am looking forward to more Linux contributions! ;-) Kind regards, Paul [1]: https://www.marcusfolkesson.se/blog/get_maintainers-and-git-send-email/
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index e384ef6ff..2ea46a0e6 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -691,6 +691,9 @@ static const struct usb_device_id quirks_table[] = { { USB_DEVICE(0x13d3, 0x3603), .driver_info = BTUSB_MEDIATEK | BTUSB_WIDEBAND_SPEECH | BTUSB_VALID_LE_STATES }, + { USB_DEVICE(0x13d3, 0x3604), .driver_info = BTUSB_MEDIATEK | + BTUSB_WIDEBAND_SPEECH | + BTUSB_VALID_LE_STATES }, /* Additional Realtek 8723AE Bluetooth devices */ { USB_DEVICE(0x0930, 0x021d), .driver_info = BTUSB_REALTEK },