| Message ID | 20240619120433.3666313-1-yauhen.kharuzhy@softeq.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a91471400f9702ff0126c016771661878cd84781 |
| Headers | show |
| Series | [BlueZ,v2,1/2] shared/mcp: Implement next/previous track commands | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | success | Gitlint PASS |
| tedd_an/BuildEll | success | Build ELL PASS |
| tedd_an/BluezMake | success | Bluez Make PASS |
| tedd_an/MakeCheck | success | Bluez Make Check PASS |
| tedd_an/MakeDistcheck | success | Make Distcheck PASS |
| tedd_an/CheckValgrind | success | Check Valgrind PASS |
| tedd_an/CheckSmatch | success | CheckSparse PASS |
| tedd_an/bluezmakeextell | success | Make External ELL PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
| tedd_an/ScanBuild | success | Scan Build PASS |
Hello: This series was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Wed, 19 Jun 2024 15:04:32 +0300 you wrote: > Add bt_mcp_{next,previous}_track functions to shared MCP client > profile code. This allows user to have basic control of the media player > in addition to simple play/pause/stop actions. > --- > src/shared/mcp.c | 20 ++++++++++++++++++++ > src/shared/mcp.h | 2 ++ > 2 files changed, 22 insertions(+) Here is the summary with links: - [BlueZ,v2,1/2] shared/mcp: Implement next/previous track commands https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=a91471400f97 - [BlueZ,v2,2/2] mcp: Implement Next Track and Previous Track commands https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=811e48d340d8 You are awesome, thank you!
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=863418
---Test result---
Test Summary:
CheckPatch FAIL 1.15 seconds
GitLint PASS 0.80 seconds
BuildEll PASS 24.92 seconds
BluezMake PASS 1708.96 seconds
MakeCheck PASS 13.42 seconds
MakeDistcheck PASS 181.15 seconds
CheckValgrind PASS 255.98 seconds
CheckSmatch PASS 366.72 seconds
bluezmakeextell PASS 124.83 seconds
IncrementalBuild PASS 3141.47 seconds
ScanBuild PASS 1103.64 seconds
Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
[BlueZ,v2,2/2] mcp: Implement Next Track and Previous Track commands
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#92:
Add implementation of Next/Previous Track commands to the audio/mcp profile.
/github/workspace/src/src/13703755.patch total: 0 errors, 1 warnings, 29 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/src/13703755.patch has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
---
Regards,
Linux Bluetooth
diff --git a/src/shared/mcp.c b/src/shared/mcp.c index b3726ebae..71fc2d151 100644 --- a/src/shared/mcp.c +++ b/src/shared/mcp.c @@ -628,6 +628,26 @@ unsigned int bt_mcp_stop(struct bt_mcp *mcp) return mcp_send(mcp, BT_MCS_CMD_STOP); } +unsigned int bt_mcp_next_track(struct bt_mcp *mcp) +{ + if (!(mcp->session.cp_op_supported & BT_MCS_CMD_NEXT_TRACK_SUPPORTED)) + return -ENOTSUP; + + DBG(mcp, "mcp %p", mcp); + + return mcp_send(mcp, BT_MCS_CMD_NEXT_TRACK); +} + +unsigned int bt_mcp_previous_track(struct bt_mcp *mcp) +{ + if (!(mcp->session.cp_op_supported & BT_MCS_CMD_PREV_TRACK_SUPPORTED)) + return -ENOTSUP; + + DBG(mcp, "mcp %p", mcp); + + return mcp_send(mcp, BT_MCS_CMD_PREV_TRACK); +} + static void mcp_mp_set_player_name(struct bt_mcp *mcp, const uint8_t *value, uint16_t length) { diff --git a/src/shared/mcp.h b/src/shared/mcp.h index a2cd6fc45..ee57ed4bf 100644 --- a/src/shared/mcp.h +++ b/src/shared/mcp.h @@ -59,3 +59,5 @@ void *bt_mcp_get_user_data(struct bt_mcp *mcp); unsigned int bt_mcp_play(struct bt_mcp *mcp); unsigned int bt_mcp_pause(struct bt_mcp *mcp); unsigned int bt_mcp_stop(struct bt_mcp *mcp); +unsigned int bt_mcp_next_track(struct bt_mcp *mcp); +unsigned int bt_mcp_previous_track(struct bt_mcp *mcp);
Add bt_mcp_{next,previous}_track functions to shared MCP client profile code. This allows user to have basic control of the media player in addition to simple play/pause/stop actions. --- src/shared/mcp.c | 20 ++++++++++++++++++++ src/shared/mcp.h | 2 ++ 2 files changed, 22 insertions(+)