| Message ID | 20240730154116.25336-4-bearodark@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v3] Bluetooth: btusb: Add MediaTek MT7925-B22M support ID 0x13d3:0x3604 | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | warning | WARNING: From:/Signed-off-by: email name mismatch: 'From: ultrabear <bearodark@gmail.com>' != 'Signed-off-by: Alexander Hall <bearodark@gmail.com>' total: 0 errors, 1 warnings, 9 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. /github/workspace/src/src/13747554.patch has style problems, please review. NOTE: Ignored message types: UNKNOWN_COMMIT_ID NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. |
| tedd_an/GitLint | fail | WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search 4: B2 Line has trailing whitespace: "BT 5.3 M.2 chipset that I purchased from aliexpress (and which " 61: B3 Line contains hard tab characters (\t): " archive.org, however aliexpress is incompatible with waybacks" 62: B3 Line contains hard tab characters (\t): " scraping tool, and as an alternative I have taken high resolution" 63: B3 Line contains hard tab characters (\t): " images of the actual chip I received and put them on archive.org." 66: B3 Line contains hard tab characters (\t): " get_maintainers.pl" 69: B3 Line contains hard tab characters (\t): " clearer" 70: B3 Line contains hard tab characters (\t): " web archive eventually came through so I have readded the link to that" 71: B3 Line contains hard tab characters (\t): " aswell" |
| tedd_an/SubjectPrefix | success | Gitlint PASS |
| tedd_an/BuildKernel | success | BuildKernel PASS |
| tedd_an/CheckAllWarning | success | CheckAllWarning PASS |
| tedd_an/CheckSparse | success | CheckSparse PASS |
| tedd_an/CheckSmatch | success | CheckSparse PASS |
| tedd_an/BuildKernel32 | success | BuildKernel32 PASS |
| tedd_an/TestRunnerSetup | success | TestRunnerSetup PASS |
| tedd_an/TestRunner_l2cap-tester | success | TestRunner PASS |
| tedd_an/TestRunner_iso-tester | success | TestRunner PASS |
| tedd_an/TestRunner_bnep-tester | success | TestRunner PASS |
| tedd_an/TestRunner_mgmt-tester | success | TestRunner PASS |
| tedd_an/TestRunner_rfcomm-tester | success | TestRunner PASS |
| tedd_an/TestRunner_sco-tester | success | TestRunner PASS |
| tedd_an/TestRunner_ioctl-tester | success | TestRunner PASS |
| tedd_an/TestRunner_mesh-tester | success | TestRunner PASS |
| tedd_an/TestRunner_smp-tester | success | TestRunner PASS |
| tedd_an/TestRunner_userchan-tester | success | TestRunner PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=875134
---Test result---
Test Summary:
CheckPatch FAIL 0.89 seconds
GitLint FAIL 0.53 seconds
SubjectPrefix PASS 0.12 seconds
BuildKernel PASS 29.96 seconds
CheckAllWarning PASS 32.32 seconds
CheckSparse PASS 37.78 seconds
CheckSmatch PASS 102.37 seconds
BuildKernel32 PASS 31.77 seconds
TestRunnerSetup PASS 531.76 seconds
TestRunner_l2cap-tester PASS 24.14 seconds
TestRunner_iso-tester PASS 37.51 seconds
TestRunner_bnep-tester PASS 5.01 seconds
TestRunner_mgmt-tester PASS 111.28 seconds
TestRunner_rfcomm-tester PASS 7.68 seconds
TestRunner_sco-tester PASS 15.23 seconds
TestRunner_ioctl-tester PASS 8.05 seconds
TestRunner_mesh-tester PASS 6.13 seconds
TestRunner_smp-tester PASS 7.13 seconds
TestRunner_userchan-tester PASS 5.30 seconds
IncrementalBuild PASS 28.21 seconds
Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
[v3] Bluetooth: btusb: Add MediaTek MT7925-B22M support ID 0x13d3:0x3604
WARNING: From:/Signed-off-by: email name mismatch: 'From: ultrabear <bearodark@gmail.com>' != 'Signed-off-by: Alexander Hall <bearodark@gmail.com>'
total: 0 errors, 1 warnings, 9 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/src/13747554.patch has style problems, please review.
NOTE: Ignored message types: UNKNOWN_COMMIT_ID
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
[v3] Bluetooth: btusb: Add MediaTek MT7925-B22M support ID 0x13d3:0x3604
WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
4: B2 Line has trailing whitespace: "BT 5.3 M.2 chipset that I purchased from aliexpress (and which "
61: B3 Line contains hard tab characters (\t): " archive.org, however aliexpress is incompatible with waybacks"
62: B3 Line contains hard tab characters (\t): " scraping tool, and as an alternative I have taken high resolution"
63: B3 Line contains hard tab characters (\t): " images of the actual chip I received and put them on archive.org."
66: B3 Line contains hard tab characters (\t): " get_maintainers.pl"
69: B3 Line contains hard tab characters (\t): " clearer"
70: B3 Line contains hard tab characters (\t): " web archive eventually came through so I have readded the link to that"
71: B3 Line contains hard tab characters (\t): " aswell"
---
Regards,
Linux Bluetooth
Dear Alexander,
Thank you for the patch. One formal nit.
Am 30.07.24 um 17:41 schrieb ultrabear:
[…]
> Signed-off-by: Alexander Hall <bearodark@gmail.com>
I think the author name, currently ultrabear, and the Signed-off-by line
should match. Is `git config --global author.name "Alexander Hall"` set?
Kind regards,
Paul
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index e384ef6ff..2ea46a0e6 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -691,6 +691,9 @@ static const struct usb_device_id quirks_table[] = { { USB_DEVICE(0x13d3, 0x3603), .driver_info = BTUSB_MEDIATEK | BTUSB_WIDEBAND_SPEECH | BTUSB_VALID_LE_STATES }, + { USB_DEVICE(0x13d3, 0x3604), .driver_info = BTUSB_MEDIATEK | + BTUSB_WIDEBAND_SPEECH | + BTUSB_VALID_LE_STATES }, /* Additional Realtek 8723AE Bluetooth devices */ { USB_DEVICE(0x0930, 0x021d), .driver_info = BTUSB_REALTEK },
This patch fixes bluetooth support on the MediaTek MT7925 WiFi 7 + BT 5.3 M.2 chipset that I purchased from aliexpress (and which arrived today). The PCB states that it is an MT7925B22M. Device from /sys/kernel/debug/usb/devices: T: Bus=03 Lev=02 Prnt=03 Port=02 Cnt=01 Dev#= 4 Spd=480 MxCh= 0 D: Ver= 2.10 Cls=ef(misc ) Sub=02 Prot=01 MxPS=64 #Cfgs= 1 P: Vendor=13d3 ProdID=3604 Rev= 1.00 S: Manufacturer=MediaTek Inc. S: Product=Wireless_Device S: SerialNumber=000000000 C:* #Ifs= 3 Cfg#= 1 Atr=e0 MxPwr=100mA A: FirstIf#= 0 IfCount= 3 Cls=e0(wlcon) Sub=01 Prot=01 I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=81(I) Atr=03(Int.) MxPS= 16 Ivl=125us E: Ad=82(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms E: Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=83(I) Atr=01(Isoc) MxPS= 0 Ivl=1ms E: Ad=03(O) Atr=01(Isoc) MxPS= 0 Ivl=1ms I: If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=83(I) Atr=01(Isoc) MxPS= 9 Ivl=1ms E: Ad=03(O) Atr=01(Isoc) MxPS= 9 Ivl=1ms I: If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=83(I) Atr=01(Isoc) MxPS= 17 Ivl=1ms E: Ad=03(O) Atr=01(Isoc) MxPS= 17 Ivl=1ms I: If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=83(I) Atr=01(Isoc) MxPS= 25 Ivl=1ms E: Ad=03(O) Atr=01(Isoc) MxPS= 25 Ivl=1ms I: If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=83(I) Atr=01(Isoc) MxPS= 33 Ivl=1ms E: Ad=03(O) Atr=01(Isoc) MxPS= 33 Ivl=1ms I: If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=83(I) Atr=01(Isoc) MxPS= 49 Ivl=1ms E: Ad=03(O) Atr=01(Isoc) MxPS= 49 Ivl=1ms I: If#= 1 Alt= 6 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=83(I) Atr=01(Isoc) MxPS= 63 Ivl=1ms E: Ad=03(O) Atr=01(Isoc) MxPS= 63 Ivl=1ms I:* If#= 2 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=(none) E: Ad=8a(I) Atr=03(Int.) MxPS= 64 Ivl=125us E: Ad=0a(O) Atr=03(Int.) MxPS= 64 Ivl=125us I: If#= 2 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=(none) E: Ad=8a(I) Atr=03(Int.) MxPS= 512 Ivl=125us E: Ad=0a(O) Atr=03(Int.) MxPS= 512 Ivl=125us High fidelity images I took of the chip itself for future reference: https://archive.org/details/MediaTek-MT7925B22M/ Webpage the chip was purchased from, note it is different from the images taken: https://web.archive.org/web/20240620021119/https://www.aliexpress. us/item/3256806821207897.html Signed-off-by: Alexander Hall <bearodark@gmail.com> --- Changes from v1: It was suggested that the (now removed) aliexpress link be run through archive.org, however aliexpress is incompatible with waybacks scraping tool, and as an alternative I have taken high resolution images of the actual chip I received and put them on archive.org. The prefix of this patch was changed to `Bluetooth:` as suggested Maintainers and open lists have been auto CC'd as suggested, via get_maintainers.pl Changes from v2: the commit name has been updated to include the device:vendor id to be clearer web archive eventually came through so I have readded the link to that aswell drivers/bluetooth/btusb.c | 3 +++ 1 file changed, 3 insertions(+)