| Message ID | 20240821012403.1947764-1-lizetao1@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a15c5bad17706e132334514a7502d6c0d67cd5d4 |
| Headers | show |
| Series | [-next] Bluetooth: btrtl: Use kvmemdup to simplify the code | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | success | Gitlint PASS |
| tedd_an/SubjectPrefix | success | Gitlint PASS |
| tedd_an/BuildKernel | success | BuildKernel PASS |
| tedd_an/CheckAllWarning | success | CheckAllWarning PASS |
| tedd_an/CheckSparse | success | CheckSparse PASS |
Hello: This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Wed, 21 Aug 2024 09:24:03 +0800 you wrote: > Use kvmemdup instead of kvmalloc() + memcpy() to simplify the code. > > No functional change intended. > > Signed-off-by: Li Zetao <lizetao1@huawei.com> > --- > drivers/bluetooth/btrtl.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) Here is the summary with links: - [-next] Bluetooth: btrtl: Use kvmemdup to simplify the code https://git.kernel.org/bluetooth/bluetooth-next/c/a15c5bad1770 You are awesome, thank you!
diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c index f2f37143c454..96754c8a4461 100644 --- a/drivers/bluetooth/btrtl.c +++ b/drivers/bluetooth/btrtl.c @@ -878,10 +878,8 @@ static int rtl_load_file(struct hci_dev *hdev, const char *name, u8 **buff) if (ret < 0) return ret; ret = fw->size; - *buff = kvmalloc(fw->size, GFP_KERNEL); - if (*buff) - memcpy(*buff, fw->data, ret); - else + *buff = kvmemdup(fw->data, fw->size, GFP_KERNEL); + if (!*buff) ret = -ENOMEM; release_firmware(fw);
Use kvmemdup instead of kvmalloc() + memcpy() to simplify the code. No functional change intended. Signed-off-by: Li Zetao <lizetao1@huawei.com> --- drivers/bluetooth/btrtl.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)