diff mbox series

[BlueZ] avdtp: Fix state check before sending delay report

Message ID 20241005211510.409471-1-arkadiusz.bokowy@gmail.com (mailing list archive)
State Accepted
Commit bd7d49d54aa3aa490ebdd67b3dd2317d29213d45
Headers show
Series [BlueZ] avdtp: Fix state check before sending delay report | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/CheckPatch success CheckPatch PASS
tedd_an/GitLint success Gitlint PASS
tedd_an/BuildEll success Build ELL PASS
tedd_an/BluezMake success Bluez Make PASS
tedd_an/MakeCheck success Bluez Make Check PASS
tedd_an/MakeDistcheck success Make Distcheck PASS
tedd_an/CheckValgrind success Check Valgrind PASS
tedd_an/CheckSmatch success CheckSparse PASS
tedd_an/bluezmakeextell success Make External ELL PASS
tedd_an/IncrementalBuild success Incremental Build PASS
tedd_an/ScanBuild success Scan Build PASS

Commit Message

Arkadiusz Bokowy Oct. 5, 2024, 9:15 p.m. UTC 
The function which handles the incoming delay report command was fixed
in 2fd62cd. However, the function which send such command was not
updated. This commit fixes that.

Also, indicate that the stream does not support delay reporting with an
appropriate error code.
---
 profiles/audio/avdtp.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

bluez.test.bot@gmail.com Oct. 5, 2024, 11 p.m. UTC | #1 
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=895894

---Test result---

Test Summary:
CheckPatch                    PASS      0.45 seconds
GitLint                       PASS      0.32 seconds
BuildEll                      PASS      23.99 seconds
BluezMake                     PASS      1517.49 seconds
MakeCheck                     PASS      13.42 seconds
MakeDistcheck                 PASS      175.51 seconds
CheckValgrind                 PASS      247.86 seconds
CheckSmatch                   PASS      349.28 seconds
bluezmakeextell               PASS      117.39 seconds
IncrementalBuild              PASS      1389.91 seconds
ScanBuild                     PASS      1007.73 seconds



---
Regards,
Linux Bluetooth
patchwork-bot+bluetooth@kernel.org Oct. 8, 2024, 2 p.m. UTC | #2 
Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Sat,  5 Oct 2024 23:15:10 +0200 you wrote:
> The function which handles the incoming delay report command was fixed
> in 2fd62cd. However, the function which send such command was not
> updated. This commit fixes that.
> 
> Also, indicate that the stream does not support delay reporting with an
> appropriate error code.
> 
> [...]

Here is the summary with links:
  - [BlueZ] avdtp: Fix state check before sending delay report
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=bd7d49d54aa3

You are awesome, thank you!
diff mbox series

Patch

diff --git a/profiles/audio/avdtp.c b/profiles/audio/avdtp.c
index 0a923ac6c..448ee2730 100644
--- a/profiles/audio/avdtp.c
+++ b/profiles/audio/avdtp.c
@@ -3769,11 +3769,12 @@  int avdtp_delay_report(struct avdtp *session, struct avdtp_stream *stream,
 		return -EINVAL;
 
 	if (stream->lsep->state != AVDTP_STATE_CONFIGURED &&
+				stream->lsep->state != AVDTP_STATE_OPEN &&
 				stream->lsep->state != AVDTP_STATE_STREAMING)
 		return -EINVAL;
 
 	if (!stream->delay_reporting || session->version < 0x0103)
-		return -EINVAL;
+		return -ENOTSUP;
 
 	stream->delay = delay;