diff mbox series

[v3] obex: Resolve SRM issue for PTS testcases

Message ID 20241023071448.1017724-1-quic_amisjain@quicinc.com (mailing list archive)
State Accepted
Commit d35bae15152bb61008f4ca5643184377ef31c7ff
Headers show
Series [v3] obex: Resolve SRM issue for PTS testcases | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/CheckPatch success CheckPatch PASS
tedd_an/GitLint success Gitlint PASS
tedd_an/BuildEll success Build ELL PASS
tedd_an/BluezMake success Bluez Make PASS
tedd_an/MakeCheck success Bluez Make Check PASS
tedd_an/MakeDistcheck success Make Distcheck PASS
tedd_an/CheckValgrind success Check Valgrind PASS
tedd_an/CheckSmatch success CheckSparse PASS
tedd_an/bluezmakeextell success Make External ELL PASS
tedd_an/IncrementalBuild success Incremental Build PASS
tedd_an/ScanBuild success Scan Build PASS

Commit Message

Amisha Jain Oct. 23, 2024, 7:14 a.m. UTC 
Add check for unknown/undefined srm value.

This fix is required to pass the below the PTS testcases :
1. OPP/SR/GOEP/SRM/BI-02-C
2. FTP/SR/GOEP/SRM/BI-02-C
3. PBAP/PSE/GOEP/SRM/BI-05-C

Description - Verify that the Server ignores a SRM header with an
invalid value in the PUT/GET request and carries on with the
PUT/GET operation with SRM disabled.

Current Behaviour - Server is sending SRM enable in the response even
though receiving the unknown SRM value.

To fix this, I have added the check to verify the valid SRM values
before continuing with SRM enable.

---
 gobex/gobex.c | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

bluez.test.bot@gmail.com Oct. 23, 2024, 9:07 a.m. UTC | #1 
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=902082

---Test result---

Test Summary:
CheckPatch                    PASS      0.43 seconds
GitLint                       PASS      0.30 seconds
BuildEll                      PASS      25.08 seconds
BluezMake                     PASS      1744.67 seconds
MakeCheck                     PASS      12.88 seconds
MakeDistcheck                 PASS      184.33 seconds
CheckValgrind                 PASS      256.52 seconds
CheckSmatch                   PASS      359.90 seconds
bluezmakeextell               PASS      121.76 seconds
IncrementalBuild              PASS      1491.25 seconds
ScanBuild                     PASS      1054.75 seconds



---
Regards,
Linux Bluetooth
patchwork-bot+bluetooth@kernel.org Oct. 24, 2024, 2:30 p.m. UTC | #2 
Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Wed, 23 Oct 2024 12:44:48 +0530 you wrote:
> Add check for unknown/undefined srm value.
> 
> This fix is required to pass the below the PTS testcases :
> 1. OPP/SR/GOEP/SRM/BI-02-C
> 2. FTP/SR/GOEP/SRM/BI-02-C
> 3. PBAP/PSE/GOEP/SRM/BI-05-C
> 
> [...]

Here is the summary with links:
  - [v3] obex: Resolve SRM issue for PTS testcases
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=d35bae15152b

You are awesome, thank you!
diff mbox series

Patch

diff --git a/gobex/gobex.c b/gobex/gobex.c
index 40d6b8129..07e46627a 100644
--- a/gobex/gobex.c
+++ b/gobex/gobex.c
@@ -317,6 +317,15 @@  static void set_srm(GObex *obex, guint8 op, guint8 srm)
 	struct srm_config *config = obex->srm;
 	gboolean enable;
 
+	switch (srm) {
+	case G_OBEX_SRM_ENABLE:
+	case G_OBEX_SRM_DISABLE:
+	case G_OBEX_SRM_INDICATE:
+		break;
+	default:
+		return;
+	}
+
 	if (config == NULL) {
 		if (srm == G_OBEX_SRM_DISABLE)
 			return;