| Message ID | 20241025202141.158946-1-daniel.beer@igorinstitute.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | fa1f2e5ee14dd740293fc5f491816cb185c6e7d7 |
| Headers | show |
| Series | [BlueZ,1/2] sink: clean up outstanding AVDTP requests if the stream goes away. | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | fail | WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search 1: T3 Title has trailing punctuation (.): "[BlueZ,1/2] sink: clean up outstanding AVDTP requests if the stream goes away." |
| tedd_an/BuildEll | success | Build ELL PASS |
| tedd_an/BluezMake | success | Bluez Make PASS |
| tedd_an/MakeCheck | success | Bluez Make Check PASS |
| tedd_an/MakeDistcheck | success | Make Distcheck PASS |
| tedd_an/CheckValgrind | success | Check Valgrind PASS |
| tedd_an/CheckSmatch | success | CheckSparse PASS |
| tedd_an/bluezmakeextell | success | Make External ELL PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
| tedd_an/ScanBuild | success | Scan Build PASS |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=903299 ---Test result--- Test Summary: CheckPatch PASS 0.91 seconds GitLint FAIL 0.83 seconds BuildEll PASS 25.55 seconds BluezMake PASS 1648.59 seconds MakeCheck PASS 13.47 seconds MakeDistcheck PASS 180.02 seconds CheckValgrind PASS 252.21 seconds CheckSmatch PASS 354.83 seconds bluezmakeextell PASS 119.91 seconds IncrementalBuild PASS 2958.71 seconds ScanBuild PASS 988.35 seconds Details ############################## Test: GitLint - FAIL Desc: Run gitlint Output: [BlueZ,1/2] sink: clean up outstanding AVDTP requests if the stream goes away. WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search 1: T3 Title has trailing punctuation (.): "[BlueZ,1/2] sink: clean up outstanding AVDTP requests if the stream goes away." [BlueZ,2/2] source: clean up outstanding AVDTP requests if the stream goes away. WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search 1: T3 Title has trailing punctuation (.): "[BlueZ,2/2] source: clean up outstanding AVDTP requests if the stream goes away." --- Regards, Linux Bluetooth
Hello: This series was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Sat, 26 Oct 2024 09:21:40 +1300 you wrote: > If the stream goes IDLE while we have an outstanding request, connect_id > stays non-zero and is never cleared via a completion callback. As a > consequence, the profile on this device will never be connected > successfully again until BlueZ restarts. > --- > profiles/audio/sink.c | 5 +++++ > 1 file changed, 5 insertions(+) Here is the summary with links: - [BlueZ,1/2] sink: clean up outstanding AVDTP requests if the stream goes away. https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=fa1f2e5ee14d - [BlueZ,2/2] source: clean up outstanding AVDTP requests if the stream goes away. https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=d7bb2abed626 You are awesome, thank you!
diff --git a/profiles/audio/sink.c b/profiles/audio/sink.c index a547dcb41..77f195436 100644 --- a/profiles/audio/sink.c +++ b/profiles/audio/sink.c @@ -137,6 +137,11 @@ static void stream_state_changed(struct avdtp_stream *stream, case AVDTP_STATE_IDLE: btd_service_disconnecting_complete(sink->service, 0); + if (sink->connect_id > 0) { + a2dp_cancel(sink->connect_id); + sink->connect_id = 0; + } + if (sink->disconnect_id > 0) { a2dp_cancel(sink->disconnect_id); sink->disconnect_id = 0;