| Message ID | 20241030084334.2740513-1-hildawu@realtek.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | dff8a64238a3f951dbf0930bac915eec7cae8200 |
| Headers | show |
| Series | [v3] Bluetooth: btrtl: Decrease HCI_OP_RESET timeout from 10 s to 2 s | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | success | Gitlint PASS |
| tedd_an/SubjectPrefix | success | Gitlint PASS |
| tedd_an/BuildKernel | success | BuildKernel PASS |
| tedd_an/CheckAllWarning | success | CheckAllWarning PASS |
| tedd_an/CheckSparse | success | CheckSparse PASS |
Hello: This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Wed, 30 Oct 2024 16:43:34 +0800 you wrote: > The original timeout setting for HCI Reset on shutdown is 10 seconds. > HCI Reset shouldn't take 10 seconds to complete so instead use the > default timeout for commands. > > Signed-off-by: Hilda Wu <hildawu@realtek.com> > --- > V2 -> V3: Update commit message > V1 -> V2: Modify commit message and summary > > [...] Here is the summary with links: - [v3] Bluetooth: btrtl: Decrease HCI_OP_RESET timeout from 10 s to 2 s https://git.kernel.org/bluetooth/bluetooth-next/c/dff8a64238a3 You are awesome, thank you!
diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c index 2d95b3ea046d..7128a8a0ba25 100644 --- a/drivers/bluetooth/btrtl.c +++ b/drivers/bluetooth/btrtl.c @@ -1371,7 +1371,7 @@ int btrtl_shutdown_realtek(struct hci_dev *hdev) /* According to the vendor driver, BT must be reset on close to avoid * firmware crash. */ - skb = __hci_cmd_sync(hdev, HCI_OP_RESET, 0, NULL, HCI_INIT_TIMEOUT); + skb = __hci_cmd_sync(hdev, HCI_OP_RESET, 0, NULL, HCI_CMD_TIMEOUT); if (IS_ERR(skb)) { ret = PTR_ERR(skb); bt_dev_err(hdev, "HCI reset during shutdown failed");
The original timeout setting for HCI Reset on shutdown is 10 seconds. HCI Reset shouldn't take 10 seconds to complete so instead use the default timeout for commands. Signed-off-by: Hilda Wu <hildawu@realtek.com> --- V2 -> V3: Update commit message V1 -> V2: Modify commit message and summary --- --- drivers/bluetooth/btrtl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)