diff mbox series

[v1] obex: Add Newmissedcalls tag in PBAP GET response

Message ID 20241111125518.2039073-1-quic_amisjain@quicinc.com (mailing list archive)
State Accepted
Commit 639fb80032cd7eb4d59e4a71e5235c647edf2af5
Headers show
Series [v1] obex: Add Newmissedcalls tag in PBAP GET response | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/CheckPatch success CheckPatch PASS
tedd_an/GitLint success Gitlint PASS
tedd_an/BuildEll success Build ELL PASS
tedd_an/BluezMake success Bluez Make PASS
tedd_an/MakeCheck success Bluez Make Check PASS
tedd_an/MakeDistcheck success Make Distcheck PASS
tedd_an/CheckValgrind success Check Valgrind PASS
tedd_an/CheckSmatch success CheckSparse PASS
tedd_an/bluezmakeextell success Make External ELL PASS
tedd_an/IncrementalBuild success Incremental Build PASS
tedd_an/ScanBuild success Scan Build PASS

Commit Message

Amisha Jain Nov. 11, 2024, 12:55 p.m. UTC 
This fix is required for passing below PTS testcases:

1. PBAP/PSE/PBD/BV-05-C
2. PBAP/PSE/PBD/BV-17-C
3. PBAP/PSE/PBB/BV-11-C

Even if the new missed calls value is zero, send it in GET response.
As per the PBAP spec, it is mandatory to include Newmissedcalls
tag in response incase of object name is 'mch.vcf' or 'cch.vcf'.
It will be better to include it in all GET response.

---
 obexd/plugins/pbap.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

Comments

bluez.test.bot@gmail.com Nov. 11, 2024, 2:35 p.m. UTC | #1 
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=908402

---Test result---

Test Summary:
CheckPatch                    PASS      0.27 seconds
GitLint                       PASS      0.20 seconds
BuildEll                      PASS      25.99 seconds
BluezMake                     PASS      1841.69 seconds
MakeCheck                     PASS      13.19 seconds
MakeDistcheck                 PASS      189.67 seconds
CheckValgrind                 PASS      265.82 seconds
CheckSmatch                   PASS      374.04 seconds
bluezmakeextell               PASS      126.17 seconds
IncrementalBuild              PASS      1611.11 seconds
ScanBuild                     PASS      1107.04 seconds



---
Regards,
Linux Bluetooth
patchwork-bot+bluetooth@kernel.org Nov. 11, 2024, 3:20 p.m. UTC | #2 
Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Mon, 11 Nov 2024 18:25:18 +0530 you wrote:
> This fix is required for passing below PTS testcases:
> 
> 1. PBAP/PSE/PBD/BV-05-C
> 2. PBAP/PSE/PBD/BV-17-C
> 3. PBAP/PSE/PBB/BV-11-C
> 
> Even if the new missed calls value is zero, send it in GET response.
> As per the PBAP spec, it is mandatory to include Newmissedcalls
> tag in response incase of object name is 'mch.vcf' or 'cch.vcf'.
> It will be better to include it in all GET response.
> 
> [...]

Here is the summary with links:
  - [v1] obex: Add Newmissedcalls tag in PBAP GET response
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=639fb80032cd

You are awesome, thank you!
diff mbox series

Patch

diff --git a/obexd/plugins/pbap.c b/obexd/plugins/pbap.c
index 64641c798..74976890d 100644
--- a/obexd/plugins/pbap.c
+++ b/obexd/plugins/pbap.c
@@ -184,12 +184,11 @@  static void phonebook_size_result(const char *buffer, size_t bufsize,
 
 	if (missed > 0)	{
 		DBG("missed %d", missed);
+	}
 
-		pbap->obj->apparam = g_obex_apparam_set_uint16(
-							pbap->obj->apparam,
+	pbap->obj->apparam = g_obex_apparam_set_uint16(pbap->obj->apparam,
 							NEWMISSEDCALLS_TAG,
 							missed);
-	}
 
 	obex_object_set_io_flags(pbap->obj, G_IO_IN, 0);
 }
@@ -223,12 +222,11 @@  static void query_result(const char *buffer, size_t bufsize, int vcards,
 		DBG("missed %d", missed);
 
 		pbap->obj->firstpacket = TRUE;
+	}
 
-		pbap->obj->apparam = g_obex_apparam_set_uint16(
-							pbap->obj->apparam,
+	pbap->obj->apparam = g_obex_apparam_set_uint16(pbap->obj->apparam,
 							NEWMISSEDCALLS_TAG,
 							missed);
-	}
 
 	obex_object_set_io_flags(pbap->obj, G_IO_IN, 0);
 }