[BlueZ,1/2] btdev: Unlink local BIS before removing

Commit Message

Iulia Tanasescu Nov. 28, 2024, 4:01 p.m. UTC

This unlinks the local BISes from the remote ones before removing them
in the handler for the LE BIG Terminate Sync command, because, otherwise,
the remote BISes will also be removed.
---
 emulator/btdev.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

[e-mail] Nov. 28, 2024, 5:13 p.m. UTC | #1

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=913158

---Test result---

Test Summary:
CheckPatch                    PENDING   0.30 seconds
GitLint                       PENDING   0.26 seconds
BuildEll                      PASS      20.25 seconds
BluezMake                     PASS      1490.88 seconds
MakeCheck                     PASS      13.35 seconds
MakeDistcheck                 PASS      156.09 seconds
CheckValgrind                 PASS      212.05 seconds
CheckSmatch                   WARNING   269.73 seconds
bluezmakeextell               PASS      98.80 seconds
IncrementalBuild              PENDING   0.30 seconds
ScanBuild                     PASS      836.16 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:
emulator/btdev.c:448:29: warning: Variable length array is used.
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth

Patch

diff --git a/emulator/btdev.c b/emulator/btdev.c
index 08af873a2..70229d9ee 100644
--- a/emulator/btdev.c
+++ b/emulator/btdev.c
@@ -6604,6 +6604,9 @@  static int cmd_big_term_sync(struct btdev *dev, const void *data, uint8_t len)
 	/* Cleanup existing connections */
 	while ((conn = queue_pop_head(big->bis))) {
 		rsp.status = BT_HCI_ERR_SUCCESS;
+
+		/* Unlink conn from remote BIS */
+		conn_unlink(conn, conn->link);
 		conn_remove(conn);
 	}