diff mbox series

[BlueZ,bluez] gatt: expand the max GATT Channels

Message ID 20250121-upstream-v1-1-7b6e450747f7@amlogic.com (mailing list archive)
State New
Headers show
Series [BlueZ,bluez] gatt: expand the max GATT Channels | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/BuildEll success Build ELL PASS
tedd_an/BluezMake success Bluez Make PASS
tedd_an/MakeCheck success Bluez Make Check PASS
tedd_an/MakeDistcheck success Make Distcheck PASS
tedd_an/CheckValgrind success Check Valgrind PASS
tedd_an/CheckSmatch success CheckSparse PASS
tedd_an/bluezmakeextell success Make External ELL PASS
tedd_an/ScanBuild success Scan Build PASS

Commit Message

Yang Li via B4 Relay Jan. 21, 2025, 10:04 a.m. UTC 
From: Yang Li <yang.li@amlogic.com>

Fixed the problem that Xiaomi K70 mobile phone takes too long to
connect to CIS.

L2CAP CB Connection (PSM=0x0027, MTU=517 bytes, MPS=251 bytes,
 Credits=255, Src=0x0056 › All Connections Refused –
 Insufficient Authorization)

Ref https://github.com/bluez/bluez/issues/1033

Signed-off-by: Yang Li <yang.li@amlogic.com>
---
 src/main.c    | 2 +-
 src/main.conf | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)


---
base-commit: 2ee08ffd4d469781dc627fa50b4a015d9ad68007
change-id: 20250121-upstream-fab070351ad3

Best regards,

Comments

bluez.test.bot@gmail.com Jan. 21, 2025, 11:09 a.m. UTC | #1 
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=927176

---Test result---

Test Summary:
CheckPatch                    PENDING   0.29 seconds
GitLint                       PENDING   0.30 seconds
BuildEll                      PASS      20.19 seconds
BluezMake                     PASS      1504.57 seconds
MakeCheck                     PASS      12.74 seconds
MakeDistcheck                 PASS      157.83 seconds
CheckValgrind                 PASS      213.59 seconds
CheckSmatch                   PASS      270.52 seconds
bluezmakeextell               PASS      97.87 seconds
IncrementalBuild              PENDING   0.30 seconds
ScanBuild                     PASS      855.73 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth
Luiz Augusto von Dentz Jan. 21, 2025, 4:05 p.m. UTC | #2 
Hi,

On Tue, Jan 21, 2025 at 5:05 AM Yang Li via B4 Relay
<devnull+yang.li.amlogic.com@kernel.org> wrote:
>
> From: Yang Li <yang.li@amlogic.com>
>
> Fixed the problem that Xiaomi K70 mobile phone takes too long to
> connect to CIS.
>
> L2CAP CB Connection (PSM=0x0027, MTU=517 bytes, MPS=251 bytes,
>  Credits=255, Src=0x0056 › All Connections Refused –
>  Insufficient Authorization)
>
> Ref https://github.com/bluez/bluez/issues/1033
>
> Signed-off-by: Yang Li <yang.li@amlogic.com>
> ---
>  src/main.c    | 2 +-
>  src/main.conf | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/main.c b/src/main.c
> index d13ada2af..e2243c824 100644
> --- a/src/main.c
> +++ b/src/main.c
> @@ -1119,7 +1119,7 @@ static void parse_gatt(GKeyFile *config)
>         parse_config_u16(config, "GATT", "ExchangeMTU", &btd_opts.gatt_mtu,
>                                 BT_ATT_DEFAULT_LE_MTU, BT_ATT_MAX_LE_MTU);
>         parse_config_u8(config, "GATT", "Channels", &btd_opts.gatt_channels,
> -                               1, 5);
> +                               1, 10);

Afaik if we set it to 5 because that is the maximum one could request:

BLUETOOTH CORE SPECIFICATION Version 5.4 | Vol 3, Part A
page 1067
Destination CID – (2 to 10 octets)
The Destination CID is an array of up to 5 two-octet values and represents
the channel endpoints on the device sending the
L2CAP_CREDIT_BASED_CONNECTION_RSP packet.

>         parse_config_bool(config, "GATT", "Client", &btd_opts.gatt_client);
>         parse_gatt_export(config);
>  }
> diff --git a/src/main.conf b/src/main.conf
> index 60ab60edc..95de56003 100644
> --- a/src/main.conf
> +++ b/src/main.conf
> @@ -264,7 +264,7 @@
>  #ExchangeMTU = 517
>
>  # Number of ATT channels
> -# Possible values: 1-5 (1 disables EATT)
> +# Possible values: 1-10 (1 disables EATT)
>  # Default to 1
>  #Channels = 1
>
>
> ---
> base-commit: 2ee08ffd4d469781dc627fa50b4a015d9ad68007
> change-id: 20250121-upstream-fab070351ad3
>
> Best regards,
> --
> Yang Li <yang.li@amlogic.com>
>
>
>
diff mbox series

Patch

diff --git a/src/main.c b/src/main.c
index d13ada2af..e2243c824 100644
--- a/src/main.c
+++ b/src/main.c
@@ -1119,7 +1119,7 @@  static void parse_gatt(GKeyFile *config)
 	parse_config_u16(config, "GATT", "ExchangeMTU", &btd_opts.gatt_mtu,
 				BT_ATT_DEFAULT_LE_MTU, BT_ATT_MAX_LE_MTU);
 	parse_config_u8(config, "GATT", "Channels", &btd_opts.gatt_channels,
-				1, 5);
+				1, 10);
 	parse_config_bool(config, "GATT", "Client", &btd_opts.gatt_client);
 	parse_gatt_export(config);
 }
diff --git a/src/main.conf b/src/main.conf
index 60ab60edc..95de56003 100644
--- a/src/main.conf
+++ b/src/main.conf
@@ -264,7 +264,7 @@ 
 #ExchangeMTU = 517
 
 # Number of ATT channels
-# Possible values: 1-5 (1 disables EATT)
+# Possible values: 1-10 (1 disables EATT)
 # Default to 1
 #Channels = 1