diff mbox series

[BlueZ,v1] dbus: Fix condition for invalidating path

Message ID 20250401134904.3721187-1-luiz.dentz@gmail.com (mailing list archive)
State Accepted
Commit da5846c096cd1006d512bbdbc466fc46a61417b8
Headers show
Series [BlueZ,v1] dbus: Fix condition for invalidating path | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/BuildEll success Build ELL PASS
tedd_an/BluezMake success Bluez Make PASS
tedd_an/MakeCheck success Bluez Make Check PASS
tedd_an/MakeDistcheck success Make Distcheck PASS
tedd_an/CheckValgrind success Check Valgrind PASS
tedd_an/CheckSmatch success CheckSparse PASS
tedd_an/bluezmakeextell success Make External ELL PASS
tedd_an/ScanBuild success Scan Build PASS

Commit Message

Luiz Augusto von Dentz April 1, 2025, 1:49 p.m. UTC
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

This fixes the condition introduced in cdd02afbb7ef
("dbus: Fix add invalid memory during interface removal") which was
reversed while applying the original fix.

Fixes: https://github.com/bluez/bluez/issues/1155
---
 gdbus/object.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

bluez.test.bot@gmail.com April 1, 2025, 3:11 p.m. UTC | #1
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=948957

---Test result---

Test Summary:
CheckPatch                    PENDING   0.39 seconds
GitLint                       PENDING   0.32 seconds
BuildEll                      PASS      20.49 seconds
BluezMake                     PASS      1501.79 seconds
MakeCheck                     PASS      12.93 seconds
MakeDistcheck                 PASS      157.66 seconds
CheckValgrind                 PASS      216.69 seconds
CheckSmatch                   PASS      283.78 seconds
bluezmakeextell               PASS      97.95 seconds
IncrementalBuild              PENDING   0.34 seconds
ScanBuild                     PASS      868.85 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth
patchwork-bot+bluetooth@kernel.org April 1, 2025, 9:40 p.m. UTC | #2
Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Tue,  1 Apr 2025 09:49:04 -0400 you wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> This fixes the condition introduced in cdd02afbb7ef
> ("dbus: Fix add invalid memory during interface removal") which was
> reversed while applying the original fix.
> 
> Fixes: https://github.com/bluez/bluez/issues/1155
> 
> [...]

Here is the summary with links:
  - [BlueZ,v1] dbus: Fix condition for invalidating path
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=da5846c096cd

You are awesome, thank you!
diff mbox series

Patch

diff --git a/gdbus/object.c b/gdbus/object.c
index 54e04b983a98..f8c694aaffdf 100644
--- a/gdbus/object.c
+++ b/gdbus/object.c
@@ -810,7 +810,7 @@  static struct generic_data *invalidate_parent_data(DBusConnection *conn,
 	if (child == NULL || g_slist_find(data->objects, child) != NULL)
 		goto done;
 
-	if (!g_slist_find(parent->objects, child))
+	if (g_slist_find(parent->objects, child))
 		goto done;
 
 	data->objects = g_slist_prepend(data->objects, child);