| Message ID | YMpUvvOUKGOKZWuH@fedora (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Bluetooth: hci_uart: Remove redundant assignment to fw_ptr | expand |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=501833 ---Test result--- Test Summary: CheckPatch PASS 0.74 seconds GitLint PASS 0.14 seconds BuildKernel PASS 688.25 seconds TestRunner: Setup PASS 443.25 seconds TestRunner: l2cap-tester PASS 3.19 seconds TestRunner: bnep-tester PASS 2.17 seconds TestRunner: mgmt-tester PASS 32.34 seconds TestRunner: rfcomm-tester PASS 2.47 seconds TestRunner: sco-tester PASS 2.40 seconds TestRunner: smp-tester PASS 2.40 seconds TestRunner: userchan-tester PASS 2.29 seconds Details ############################## Test: CheckPatch - PASS - 0.74 seconds Run checkpatch.pl script with rule in .checkpatch.conf ############################## Test: GitLint - PASS - 0.14 seconds Run gitlint with rule in .gitlint ############################## Test: BuildKernel - PASS - 688.25 seconds Build Kernel with minimal configuration supports Bluetooth ############################## Test: TestRunner: Setup - PASS - 443.25 seconds Setup environment for running Test Runner ############################## Test: TestRunner: l2cap-tester - PASS - 3.19 seconds Run test-runner with l2cap-tester Total: 40, Passed: 40 (100.0%), Failed: 0, Not Run: 0 ############################## Test: TestRunner: bnep-tester - PASS - 2.17 seconds Run test-runner with bnep-tester Total: 1, Passed: 1 (100.0%), Failed: 0, Not Run: 0 ############################## Test: TestRunner: mgmt-tester - PASS - 32.34 seconds Run test-runner with mgmt-tester Total: 446, Passed: 433 (97.1%), Failed: 0, Not Run: 13 ############################## Test: TestRunner: rfcomm-tester - PASS - 2.47 seconds Run test-runner with rfcomm-tester Total: 9, Passed: 9 (100.0%), Failed: 0, Not Run: 0 ############################## Test: TestRunner: sco-tester - PASS - 2.40 seconds Run test-runner with sco-tester Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0 ############################## Test: TestRunner: smp-tester - PASS - 2.40 seconds Run test-runner with smp-tester Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0 ############################## Test: TestRunner: userchan-tester - PASS - 2.29 seconds Run test-runner with userchan-tester Total: 3, Passed: 3 (100.0%), Failed: 0, Not Run: 0 --- Regards, Linux Bluetooth
Hi Nigel, > The variable fw_ptr is assigned a value that is not read and the same value > is assigned in the patch goto. The assignment is redundant and can be > removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Nigel Christian <nigel.l.christian@gmail.com> > --- > drivers/bluetooth/hci_ag6xx.c | 1 - > 1 file changed, 1 deletion(-) patch has been applied to bluetooth-next tree. Regards Marcel
diff --git a/drivers/bluetooth/hci_ag6xx.c b/drivers/bluetooth/hci_ag6xx.c index 1f55df93e4ce..2d40302409ff 100644 --- a/drivers/bluetooth/hci_ag6xx.c +++ b/drivers/bluetooth/hci_ag6xx.c @@ -199,7 +199,6 @@ static int ag6xx_setup(struct hci_uart *hu) fwname, err); goto patch; } - fw_ptr = fw->data; bt_dev_info(hdev, "Applying bddata (%s)", fwname);
The variable fw_ptr is assigned a value that is not read and the same value is assigned in the patch goto. The assignment is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Nigel Christian <nigel.l.christian@gmail.com> --- drivers/bluetooth/hci_ag6xx.c | 1 - 1 file changed, 1 deletion(-)