| Message ID | dd2310913558d6c63e193ea111ef2681e5911837.1592390407.git.marcel@holtmann.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Combination of pending patches | expand |
Hi Marcel, On Wed, Jun 17, 2020 at 6:43 AM Marcel Holtmann <marcel@holtmann.org> wrote: > > The command status reply is only for failure. When completing set system > config command, the reply has to be command complete. > Reviewed-by: Alain Michaud <alainm@chromium.org> > Signed-off-by: Marcel Holtmann <marcel@holtmann.org> > --- > net/bluetooth/mgmt_config.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/net/bluetooth/mgmt_config.c b/net/bluetooth/mgmt_config.c > index 8e7ad2a51dbb..8d01a8ff85e9 100644 > --- a/net/bluetooth/mgmt_config.c > +++ b/net/bluetooth/mgmt_config.c > @@ -247,9 +247,8 @@ int set_def_system_config(struct sock *sk, struct hci_dev *hdev, void *data, > buffer += exp_len; > } > > - return mgmt_cmd_status(sk, hdev->id, > - MGMT_OP_SET_DEF_SYSTEM_CONFIG, > - MGMT_STATUS_SUCCESS); > + return mgmt_cmd_complete(sk, hdev->id, > + MGMT_OP_SET_DEF_SYSTEM_CONFIG, 0, NULL, 0); > } > > int read_def_runtime_config(struct sock *sk, struct hci_dev *hdev, void *data, > -- > 2.26.2 > Thanks, Alain
diff --git a/net/bluetooth/mgmt_config.c b/net/bluetooth/mgmt_config.c index 8e7ad2a51dbb..8d01a8ff85e9 100644 --- a/net/bluetooth/mgmt_config.c +++ b/net/bluetooth/mgmt_config.c @@ -247,9 +247,8 @@ int set_def_system_config(struct sock *sk, struct hci_dev *hdev, void *data, buffer += exp_len; } - return mgmt_cmd_status(sk, hdev->id, - MGMT_OP_SET_DEF_SYSTEM_CONFIG, - MGMT_STATUS_SUCCESS); + return mgmt_cmd_complete(sk, hdev->id, + MGMT_OP_SET_DEF_SYSTEM_CONFIG, 0, NULL, 0); } int read_def_runtime_config(struct sock *sk, struct hci_dev *hdev, void *data,
The command status reply is only for failure. When completing set system config command, the reply has to be command complete. Signed-off-by: Marcel Holtmann <marcel@holtmann.org> --- net/bluetooth/mgmt_config.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)