Bluetooth: btusb HCI_QUIRK_NO_SUSPEND_NOTIFIER causes kernel panic on CSR 5.0 clones

Commit Message

Mihir Khatri Nov. 19, 2022, 6:54 p.m. UTC

It seems that setting the bit HCI_QUICK_NO_SUSPEND_NOTIFIER
on some fake CSR 5.0 clones can them to get 
registered 2 times causing a kernel panic. After not setting
the bit HCI_QUICK_NO_SUSPEND_NOTIFIER everything works fine 
and no kernel panic can be observed.

---
 drivers/bluetooth/btusb.c | 1 -
 1 file changed, 1 deletion(-)

Comments

[e-mail] Nov. 19, 2022, 7:29 p.m. UTC | #1

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=697285

---Test result---

Test Summary:
CheckPatch                    FAIL      0.82 seconds
GitLint                       FAIL      0.54 seconds
SubjectPrefix                 PASS      0.09 seconds
BuildKernel                   PASS      37.11 seconds
BuildKernel32                 PASS      34.17 seconds
TestRunnerSetup               PASS      456.41 seconds
TestRunner_l2cap-tester       PASS      17.58 seconds
TestRunner_iso-tester         PASS      18.12 seconds
TestRunner_bnep-tester        PASS      5.96 seconds
TestRunner_mgmt-tester        PASS      112.39 seconds
TestRunner_rfcomm-tester      PASS      9.83 seconds
TestRunner_sco-tester         PASS      9.26 seconds
TestRunner_ioctl-tester       PASS      10.61 seconds
TestRunner_mesh-tester        PASS      7.26 seconds
TestRunner_smp-tester         PASS      8.97 seconds
TestRunner_userchan-tester    PASS      6.22 seconds
IncrementalBuild              PASS      33.32 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
Bluetooth: btusb HCI_QUIRK_NO_SUSPEND_NOTIFIER causes kernel panic on CSR 5.0 clones
ERROR: Missing Signed-off-by: line(s)

total: 1 errors, 0 warnings, 7 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/src/13049772.patch has style problems, please review.

NOTE: Ignored message types: UNKNOWN_COMMIT_ID

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.


##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
Bluetooth: btusb HCI_QUIRK_NO_SUSPEND_NOTIFIER causes kernel panic on CSR 5.0 clones

1: T1 Title exceeds max length (84>80): "Bluetooth: btusb HCI_QUIRK_NO_SUSPEND_NOTIFIER causes kernel panic on CSR 5.0 clones"
4: B2 Line has trailing whitespace: "on some fake CSR 5.0 clones can them to get "
6: B2 Line has trailing whitespace: "the bit HCI_QUICK_NO_SUSPEND_NOTIFIER everything works fine "


---
Regards,
Linux Bluetooth

Patch

diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index e7914783d29e..1bb8d0f2e8b8 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -2267,7 +2267,6 @@  static int btusb_setup_csr(struct hci_dev *hdev)
 		set_bit(HCI_QUIRK_BROKEN_STORED_LINK_KEY, &hdev->quirks);
 		set_bit(HCI_QUIRK_BROKEN_ERR_DATA_REPORTING, &hdev->quirks);
 		set_bit(HCI_QUIRK_BROKEN_FILTER_CLEAR_ALL, &hdev->quirks);
-		set_bit(HCI_QUIRK_NO_SUSPEND_NOTIFIER, &hdev->quirks);
 
 		/* Clear the reset quirk since this is not an actual
 		 * early Bluetooth 1.1 device from CSR.