From patchwork Wed Jun 7 15:20:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Mikhalitsyn X-Patchwork-Id: 13270869 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CA69C7EE23 for ; Wed, 7 Jun 2023 15:21:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241286AbjFGPVL (ORCPT ); Wed, 7 Jun 2023 11:21:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235642AbjFGPVJ (ORCPT ); Wed, 7 Jun 2023 11:21:09 -0400 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA3D81BE5 for ; Wed, 7 Jun 2023 08:21:07 -0700 (PDT) Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 5572A3F0E8 for ; Wed, 7 Jun 2023 15:21:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1686151266; bh=8aY1VEWoPNEUlLBN7rmQq3eOh6/TfDDzDz8dWVmei8E=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=DmDAUP1TNFZPG+1XBqt6gwBW/5iv9ZWJv3vupEce3lzScE8DLpj1vyx6CbBKNAY8g 8mF+XJ/NKv2YhnDLwxMPpH5vOYy/cPYw2zyu8kuD4SmnmbMXWvaT7/EbMlwfMbHSaG o2nOYv/q0kD4f9NFBiFtupApkqzbSt4JrFw54yqZ1jXOCQntFZpyu0RAxh8kl7CiBI MpzbpnZfmxyd9SGGGMOBJTxZWXM9+wqGFsVce7r2+WjoW4v4GJ8iFiKvUYH61YRC70 XyTff0fwS664eeaG7N4jCdcWpyY7u1J6USNt2FL4Zx8PraVWlm0ebl6YgUjgIfETnB xUwbc8zdANhxQ== Received: by mail-ed1-f69.google.com with SMTP id 4fb4d7f45d1cf-513f337d478so831889a12.3 for ; Wed, 07 Jun 2023 08:21:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686151266; x=1688743266; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8aY1VEWoPNEUlLBN7rmQq3eOh6/TfDDzDz8dWVmei8E=; b=V2cH6F5Q+zqHnRyVqDqeCfoOSl1JRFiu/AgzuljThdrVWZv0AvNcovGTUk//AGcCQF 6zxi4K7vuH4dyRgSh/fFCjAT6jXlzGeuVUzuasXAM8ZbXov5qWV7FTw9SV5kWtU3kdTA z2LN2Hyjtd2Bo7sx1rPKY31mVhP8va2zJ3BRXM7M6RCd55vxz4WpFp2//nf373KCcZ0G xUQsND4Wr2SWFfMZJQvVSCf8qKuvEl6qGghs4ri6JIfO+i9bDDnM5tSOFEi2fElboTEQ CIMVi1XB4dxTMvSS0ja3qmZ+PcQfQF0g+RqHnUOWZ8BArVpnrfCergg6M23Fk61RzLqZ /C3g== X-Gm-Message-State: AC+VfDzIo7d4dJrEUOefNy1P9K59g9JC2b6FF6jhS7uRuXVJswlD4Z0P tMlEDQ5uRNNB6ljcXnWjO86qo17s8YbAjOr9MF7O8VwTyxaTn0tCxEMA6afc1dLRXXXVD2tCkf2 tLzp6HBknpR4MY4RYvTkSF7pJNownts8B9gHDO5g= X-Received: by 2002:aa7:cd7c:0:b0:514:98c8:9d7c with SMTP id ca28-20020aa7cd7c000000b0051498c89d7cmr4306409edb.4.1686151266033; Wed, 07 Jun 2023 08:21:06 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4jGoY1/cSqCCKJEhcMIh7TGVGPrCBczoHCXvlo5e6XW3XxFcEYbVqs7fQhicmHa1Zuso1ZOg== X-Received: by 2002:aa7:cd7c:0:b0:514:98c8:9d7c with SMTP id ca28-20020aa7cd7c000000b0051498c89d7cmr4306389edb.4.1686151265750; Wed, 07 Jun 2023 08:21:05 -0700 (PDT) Received: from amikhalitsyn.local (dslb-002-205-064-187.002.205.pools.vodafone-ip.de. [2.205.64.187]) by smtp.gmail.com with ESMTPSA id w17-20020a056402129100b005147503a238sm6263441edv.17.2023.06.07.08.21.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jun 2023 08:21:05 -0700 (PDT) From: Alexander Mikhalitsyn To: xiubli@redhat.com Cc: brauner@kernel.org, stgraber@ubuntu.com, linux-fsdevel@vger.kernel.org, Alexander Mikhalitsyn , Ilya Dryomov , Jeff Layton , ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 00/14] ceph: support idmapped mounts Date: Wed, 7 Jun 2023 17:20:24 +0200 Message-Id: <20230607152038.469739-1-aleksandr.mikhalitsyn@canonical.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: ceph-devel@vger.kernel.org Dear friends, This patchset was originally developed by Christian Brauner but I'll continue to push it forward. Christian allowed me to do that :) This feature is already actively used/tested with LXD/LXC project. Git tree (based on https://github.com/ceph/ceph-client.git master): https://github.com/mihalicyn/linux/tree/fs.idmapped.ceph In the version 3 I've changed only two commits: - fs: export mnt_idmap_get/mnt_idmap_put - ceph: allow idmapped setattr inode op and added a new one: - ceph: pass idmap to __ceph_setattr I can confirm that version 3 passes xfstests. Kind regards, Alex Original description from Christian: ======================================================================== This patch series enables cephfs to support idmapped mounts, i.e. the ability to alter ownership information on a per-mount basis. Container managers such as LXD support sharaing data via cephfs between the host and unprivileged containers and between unprivileged containers. They may all use different idmappings. Idmapped mounts can be used to create mounts with the idmapping used for the container (or a different one specific to the use-case). There are in fact more use-cases such as remapping ownership for mountpoints on the host itself to grant or restrict access to different users or to make it possible to enforce that programs running as root will write with a non-zero {g,u}id to disk. The patch series is simple overall and few changes are needed to cephfs. There is one cephfs specific issue that I would like to discuss and solve which I explain in detail in: [PATCH 02/12] ceph: handle idmapped mounts in create_request_message() It has to do with how to handle mds serves which have id-based access restrictions configured. I would ask you to please take a look at the explanation in the aforementioned patch. The patch series passes the vfs and idmapped mount testsuite as part of xfstests. To run it you will need a config like: [ceph] export FSTYP=ceph export TEST_DIR=/mnt/test export TEST_DEV=10.103.182.10:6789:/ export TEST_FS_MOUNT_OPTS="-o name=admin,secret=$password and then simply call sudo ./check -g idmapped ======================================================================== Alexander Mikhalitsyn (2): fs: export mnt_idmap_get/mnt_idmap_put ceph: pass idmap to __ceph_setattr Christian Brauner (12): ceph: stash idmapping in mdsc request ceph: handle idmapped mounts in create_request_message() ceph: allow idmapped mknod inode op ceph: allow idmapped symlink inode op ceph: allow idmapped mkdir inode op ceph: allow idmapped rename inode op ceph: allow idmapped getattr inode op ceph: allow idmapped permission inode op ceph: allow idmapped setattr inode op ceph/acl: allow idmapped set_acl inode op ceph/file: allow idmapped atomic_open inode op ceph: allow idmapped mounts fs/ceph/acl.c | 6 +++--- fs/ceph/dir.c | 4 ++++ fs/ceph/file.c | 10 +++++++-- fs/ceph/inode.c | 38 ++++++++++++++++++++++++----------- fs/ceph/mds_client.c | 29 ++++++++++++++++++++++---- fs/ceph/mds_client.h | 1 + fs/ceph/super.c | 2 +- fs/ceph/super.h | 3 ++- fs/mnt_idmapping.c | 2 ++ include/linux/mnt_idmapping.h | 3 +++ 10 files changed, 75 insertions(+), 23 deletions(-)