From patchwork Mon Nov 29 19:47:34 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yehuda Sadeh Weinraub X-Patchwork-Id: 365172 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id oATJmQVq002419 for ; Mon, 29 Nov 2010 19:48:26 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751790Ab0K2TsZ (ORCPT ); Mon, 29 Nov 2010 14:48:25 -0500 Received: from mail-fx0-f46.google.com ([209.85.161.46]:62006 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751074Ab0K2TsY (ORCPT ); Mon, 29 Nov 2010 14:48:24 -0500 Received: by fxm8 with SMTP id 8so447405fxm.19 for ; Mon, 29 Nov 2010 11:48:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:to:cc :in-reply-to:references:content-type:date:message-id:mime-version :x-mailer:content-transfer-encoding; bh=wwjDN7Ry0ui7OqPZb7DyI4Re1sXMgeyg/7KkfJK5tco=; b=TvK2/rkcSLXIo5MAKdHWAc22JQUOcf5nhZlQySxkD5PB8tCUbTt/LE9yxlE+PdHRVN RW16daTdpfgH7dIyABb0p3pkf0Rlz8a6TJfsTjcEV6JsEa0XUqaW4bgoqpoHJ4PuY2QV n9lXqaJ2HlCwbCBh0LvRi4HsX8yWvkFXc+aAY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:in-reply-to:references:content-type:date :message-id:mime-version:x-mailer:content-transfer-encoding; b=eRtJ6Coi7INuCbVevVjgXIXxHRCQqSGogR/oUWeUQ2DWhK3zRVigPkRu6h1BuaGbAj cF9LnGV886Cd6Fo1P07o+dYrf/DkhDA4mvHrPKntZHes5vbjhNvtLVtsEBclB8VeLJYV pr3ojQe2L1im2CMgTZ2DouyKrN2GO+1RnSd3g= Received: by 10.223.74.143 with SMTP id u15mr5741209faj.27.1291060102997; Mon, 29 Nov 2010 11:48:22 -0800 (PST) Received: from [10.0.1.20] (ip-66-33-206-8.dreamhost.com [66.33.206.8]) by mx.google.com with ESMTPS id f24sm780567fak.24.2010.11.29.11.48.20 (version=SSLv3 cipher=RC4-MD5); Mon, 29 Nov 2010 11:48:21 -0800 (PST) Subject: Re: [Qemu-devel] Re: [PATCH] ceph/rbd block driver for qemu-kvm (v8) From: Yehuda Sadeh Weinraub To: Kevin Wolf Cc: Stefan Hajnoczi , Christian Brunner , ceph-devel@vger.kernel.org, qemu-devel@nongnu.org, kvm@vger.kernel.org In-Reply-To: <4CF37A23.8010202@redhat.com> References: <20101117214223.GA31321@sir.home> <4CF36B79.4000008@redhat.com> <4CF37A23.8010202@redhat.com> Date: Mon, 29 Nov 2010 11:47:34 -0800 Message-ID: <1291060054.1792.88.camel@yehudasa-desktop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Sender: ceph-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: ceph-devel@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter1.kernel.org [140.211.167.41]); Mon, 29 Nov 2010 19:48:26 +0000 (UTC) diff --git a/configure b/configure index 5d8f620..18ae07c 100755 --- a/configure +++ b/configure @@ -1770,15 +1770,36 @@ int main(void) { rados_initialize(0, NULL); return 0; } EOF rbd_libs="-lrados -lcrypto" if compile_prog "" "$rbd_libs" ; then - rbd=yes - libs_tools="$rbd_libs $libs_tools" - libs_softmmu="$rbd_libs $libs_softmmu" + librados_too_old=no + cat > $TMPC < +#include +#ifndef CEPH_OSD_TMAP_SET +#error missing CEPH_OSD_TMAP_SET +#endif +int main(void) { + int (*func)(const rados_pool_t pool, uint64_t *snapid) = rados_selfmanaged_snap_create; + rados_initialize(0, NULL); + return 0; +} +EOF + if compile_prog "" "$rbd_libs" ; then + rbd=yes + libs_tools="$rbd_libs $libs_tools" + libs_softmmu="$rbd_libs $libs_softmmu" + else + rbd=no + librados_too_old=yes + fi else if test "$rbd" = "yes" ; then feature_not_found "rados block device" fi rbd=no fi + if test "$librados_too_old" = "yes" ; then + echo "-> Your librados version is too old - upgrade needed to have rbd support" + fi fi ##########################################