diff mbox

fix syncfs handling in error case

Message ID 1354029799-14465-1-git-send-email-danny.al-gaaf@bisect.de (mailing list archive)
State New, archived
Headers show

Commit Message

Danny Al-Gaaf Nov. 27, 2012, 3:23 p.m. UTC 
If the call to syncfs() fails, don't try to call syncfs again via
syscall(). If HAVE_SYS_SYNCFS is defined, don't use syscall() with
SYS_syncfs.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
---
 src/common/sync_filesystem.h | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Danny Al-Gaaf Nov. 27, 2012, 3:42 p.m. UTC | #1 
Hi,

forget this patch, I'll send a new version due to changes in master.

Danny

Am 27.11.2012 16:23, schrieb Danny Al-Gaaf:
> If the call to syncfs() fails, don't try to call syncfs again via
> syscall(). If HAVE_SYS_SYNCFS is defined, don't use syscall() with
> SYS_syncfs.
> 
> Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
> ---
>  src/common/sync_filesystem.h | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/src/common/sync_filesystem.h b/src/common/sync_filesystem.h
> index dc90b89..976400f 100644
> --- a/src/common/sync_filesystem.h
> +++ b/src/common/sync_filesystem.h
> @@ -34,9 +34,7 @@ inline int sync_filesystem(int fd)
>  #ifdef HAVE_SYS_SYNCFS
>    if (syncfs(fd) == 0)
>      return 0;
> -#endif
> -
> -#ifdef SYS_syncfs
> +#elif defined(SYS_syncfs)
>    if (syscall(SYS_syncfs, fd) == 0)
>      return 0;
>  #endif
> 

--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/src/common/sync_filesystem.h b/src/common/sync_filesystem.h
index dc90b89..976400f 100644
--- a/src/common/sync_filesystem.h
+++ b/src/common/sync_filesystem.h
@@ -34,9 +34,7 @@  inline int sync_filesystem(int fd)
 #ifdef HAVE_SYS_SYNCFS
   if (syncfs(fd) == 0)
     return 0;
-#endif
-
-#ifdef SYS_syncfs
+#elif defined(SYS_syncfs)
   if (syscall(SYS_syncfs, fd) == 0)
     return 0;
 #endif