From patchwork Fri Jan 4 09:01:56 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yan, Zheng" X-Patchwork-Id: 1931741 Return-Path: X-Original-To: patchwork-ceph-devel@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 06606DFABD for ; Fri, 4 Jan 2013 09:02:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753462Ab3ADJCk (ORCPT ); Fri, 4 Jan 2013 04:02:40 -0500 Received: from mga01.intel.com ([192.55.52.88]:47205 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752091Ab3ADJCb (ORCPT ); Fri, 4 Jan 2013 04:02:31 -0500 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 04 Jan 2013 01:02:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.84,409,1355126400"; d="scan'208";a="272789972" Received: from zyan5-mobl.sh.intel.com ([10.239.36.28]) by fmsmga002.fm.intel.com with ESMTP; 04 Jan 2013 01:02:29 -0800 From: "Yan, Zheng" To: ceph-devel@vger.kernel.org, sage@inktank.com Cc: "Yan, Zheng" Subject: [PATCH 05/29] mds: don't journal null dentry for overwrited remote linkage Date: Fri, 4 Jan 2013 17:01:56 +0800 Message-Id: <1357290140-17044-6-git-send-email-zheng.z.yan@intel.com> X-Mailer: git-send-email 1.7.11.7 In-Reply-To: <1357290140-17044-1-git-send-email-zheng.z.yan@intel.com> References: <1357290140-17044-1-git-send-email-zheng.z.yan@intel.com> Sender: ceph-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: ceph-devel@vger.kernel.org From: "Yan, Zheng" Server::_rename_prepare() adds null dest dentry to the EMetaBlob if the rename operation overwrites a remote linkage. This is incorrect because null dentry are processed after primary and remote dentries during journal replay. The erroneous null dentry makes the dentry of rename destination disappear. Signed-off-by: Yan, Zheng --- src/mds/Server.cc | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/mds/Server.cc b/src/mds/Server.cc index 064733c..23739ea 100644 --- a/src/mds/Server.cc +++ b/src/mds/Server.cc @@ -5794,10 +5794,6 @@ void Server::_rename_prepare(MDRequest *mdr, CEPH_NOSNAP, 0, destdnl); metablob->add_primary_dentry(oldin->get_projected_parent_dn(), true, oldin); } - if (destdn->is_auth()) { - // auth for dn, not targeti - metablob->add_null_dentry(destdn, true); - } } }